Patch Detail
Show a patch.
GET /api/patches/15566/?format=api
{ "id": 15566, "url": "https://patchwork.libcamera.org/api/patches/15566/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15566/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220328092433.69856-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2022-03-28T09:24:31", "name": "[libcamera-devel,v4,3/5] ipa: libipa: Histogram: Constify the constructor span", "commit_ref": "88c69f88089ba7f9ec8c25aa9f084e1143ad9f29", "pull_url": null, "state": "accepted", "archived": false, "hash": "77ba6e4f01dea52add6dc0d3a5ef459edbb09d86", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15566/mbox/", "series": [ { "id": 3005, "url": "https://patchwork.libcamera.org/api/series/3005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3005", "date": "2022-03-28T09:24:28", "name": "IPA RkISP1 awb and misc improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15566/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15566/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C8CAC3266\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Mar 2022 09:24:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D9DE65640;\n\tMon, 28 Mar 2022 11:24:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78E3A65633\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Mar 2022 11:24:42 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:4f49:c672:4655:7dbb])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DAE28E0A;\n\tMon, 28 Mar 2022 11:24:41 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648459486;\n\tbh=2HJTGIzy9CsO2/V/VvT4biuOy1qQF6ZkFGXJMTw/Myw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=HfI8VUbpLIE4MtKfv2UebHTAtKBNikAvcVgcSZAHX/U1h6aYPyjZje+CFRqFYN4/J\n\tphnGK/RPMZXvOIEc8Q1M6RpOENdnSCq0Y1fsbm678WrpBsmU06UoNCJ6fP4onJDqFM\n\tEWrhW3CnDib5jMsgTKQtIgN0mu8mMSWQJ85LFhx0hQczJEVxAs0s+rISMc7ZVNH+MS\n\tI9BnT7MS0a0hzF2p8YlPM6WMXvPdG7ynEbVEEOlixNA7lRdNjO2cB2ngJP4ZJW8+EX\n\tq4mFcc6Htvg8oXQY3vjRGtshOLUd65LC8QQpn8Qtn4qiJp+u3fTPxzTSo6EQG86J2n\n\tOWPInpPPyE/tg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648459482;\n\tbh=2HJTGIzy9CsO2/V/VvT4biuOy1qQF6ZkFGXJMTw/Myw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oVPXykPxmCF/NyHheEmci8/VHopV5QijU9n6Qols4ioMhh+RfI8l7KINEhTSAdEs8\n\tolXQe8yXrUW2PG0M2yt1yC8MeGx0MQqBCv4WCZaJ2V3/QpjdxizVrmceM321oZAf3d\n\tjAFejCMwpDjYXdCD5JjRd6f3Jhktj4fkIXSJIHnQ=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oVPXykPx\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Mar 2022 11:24:31 +0200", "Message-Id": "<20220328092433.69856-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220328092433.69856-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20220328092433.69856-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/5] ipa: libipa: Histogram: Constify\n\tthe constructor span", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jean-Michel Hautbois via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Histogram constructor does not modify the data. Pass it a\nSpan<const uint32_t> instead of a Span<uint32_t>.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/histogram.cpp | 2 +-\n src/ipa/libipa/histogram.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\nindex 4d94571f..d8ad1c89 100644\n--- a/src/ipa/libipa/histogram.cpp\n+++ b/src/ipa/libipa/histogram.cpp\n@@ -32,7 +32,7 @@ namespace ipa {\n * \\brief Create a cumulative histogram\n * \\param[in] data A pre-sorted histogram to be passed\n */\n-Histogram::Histogram(Span<uint32_t> data)\n+Histogram::Histogram(Span<const uint32_t> data)\n {\n \tcumulative_.reserve(data.size());\n \tcumulative_.push_back(0);\ndiff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\nindex c40a366b..164d4603 100644\n--- a/src/ipa/libipa/histogram.h\n+++ b/src/ipa/libipa/histogram.h\n@@ -22,7 +22,7 @@ namespace ipa {\n class Histogram\n {\n public:\n-\tHistogram(Span<uint32_t> data);\n+\tHistogram(Span<const uint32_t> data);\n \tsize_t bins() const { return cumulative_.size() - 1; }\n \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n \tuint64_t cumulativeFrequency(double bin) const;\n", "prefixes": [ "libcamera-devel", "v4", "3/5" ] }