Patch Detail
Show a patch.
GET /api/patches/15498/?format=api
{ "id": 15498, "url": "https://patchwork.libcamera.org/api/patches/15498/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15498/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220322092257.2713521-2-naush@raspberrypi.com>", "date": "2022-03-22T09:22:50", "name": "[libcamera-devel,v4,1/8] pipeline: raspberrypi: Avoid over-allocation for ISP Output 1", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53af004f828588596acebb54539b9c11ac8383f7", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15498/mbox/", "series": [ { "id": 2982, "url": "https://patchwork.libcamera.org/api/series/2982/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2982", "date": "2022-03-22T09:22:49", "name": "Raspberry Pi: Efficient start/stop/start sequences", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2982/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15498/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15498/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E92F1BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Mar 2022 09:23:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31B35610F8;\n\tTue, 22 Mar 2022 10:23:03 +0100 (CET)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E71C5604C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 10:23:01 +0100 (CET)", "by mail-wm1-x329.google.com with SMTP id\n\tj13-20020a05600c1c0d00b0038c8f94aac2so1016104wms.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 02:23:01 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:9e9a:99af:e5a6:319b])\n\tby smtp.gmail.com with ESMTPSA id\n\tr14-20020a05600c35ce00b0038c9f469979sm1471695wmq.40.2022.03.22.02.23.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Mar 2022 02:23:01 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647940983;\n\tbh=i63d6hUH3isSXt4iyQ9OeO4uzCK+/jYWFH31E+5m1HE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DTtBh0YwNX/6VLHB1MwbSXs2bWjcS/c1l0ThxbxqNt+PLIkcHf+AKl0Y2c9eScAXH\n\tmZJ8LU7FUfjrK+i/QF+wxUZyT4vsXGAiNKQFZPnosaIRVRi1ikyZdTOMSV9hrE7Y2R\n\txCTdAf2Sqq2BiOUy/fdahCisgVau5gklUL07wEM1KRSJ22Dh4sWvo2PPCopvHgK8F/\n\tew4aB93sT4E7JnoY4o0Yoy/F7Nk2d3iVZXk2bxrE0pKey/ifsoIYZDlPg4oPuvZ6zf\n\tNrqmje68U+V6DNh7h7FCxocqVQh6ncOnentP7mbPMcN3qPZsX3xT+GJXPA3KAdFR6z\n\tnB+pOmSQQhrYg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jcfkXUDyQsMHFwrfe/cenXQcfke3b/k+swts4GnZTjQ=;\n\tb=UoVdijD9k5czPIoKj/3QiCmKvQe52efw9ZGcCgunseFVsCDSh2LQprq2q1lp1LM4ih\n\tY8Stur8IfgONf4+RUiGSGeXkIIKq+fL6kaa06idGk8R5B2PO06so/3B0LpmAjtjAHsHG\n\t1N4xIt60VdD2G7RX9wJsHSKle/vdDjMyJeAbuPVsTzjRKePnCy0+z8NyT2xuib0I2ZS7\n\tCqByNxPt2AM3+xsx+XbnWEwFJcF2H+N8gbLfz77/4TAOv+Fe2adaAQ0cSbn5CnqNuDir\n\tFaJCzFWepxw7+nJ/i2mMszCVD36OBeR4xINyDgDs40C3dDYncKcQ1hyZl8hU/AEW78B6\n\tpOYQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"UoVdijD9\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=jcfkXUDyQsMHFwrfe/cenXQcfke3b/k+swts4GnZTjQ=;\n\tb=menPD9fCee8XKEYcZEZqnhs0wVsEmqpJiDQbLEfa0dMkeBBNTra0LpVWVYTvIfWXhI\n\tDd6BXInmm75MmcmrFPxvm3qTifrWpUfdEnHZmThdy/31wcLlcy9qWfLSK8CBatZ5/VCQ\n\t7eBSEOqQX2ixjUKkImgxhOHM3vurU9lru5o8utvmBzGWEgDQ8/ieJM5JdPJo5N4lblFP\n\tvXRnYeMQL36+OAX78sUl7Kc3JddSzZ6ZkPvSaDVZPNB1jtgEwi4XGB7Hb9lhU/vwNBdt\n\tyedDOllJwws+0lZaVgv7rooJw0cYyQrTEhW8x0p80ADmxh8oszGnTw7iNtSEDF3KmLrD\n\tzoVA==", "X-Gm-Message-State": "AOAM533enRoo3VmPzloptKogNmXzZR+OFYQ7RGOxphiOn76l5EL7Kxmh\n\tEB6kaEuxa9ty9lDdF+HZ3B+iSeXMeiAGdg==", "X-Google-Smtp-Source": "ABdhPJwG7XQLDbZiTQq9Ioawk6fZI2nGATWWfG75sX1OoIqPPErz4xg5fFWVy+6HtbDKPfSjqvPNrQ==", "X-Received": "by 2002:a5d:59a1:0:b0:204:1777:fc08 with SMTP id\n\tp1-20020a5d59a1000000b002041777fc08mr5875151wrr.545.1647940981434; \n\tTue, 22 Mar 2022 02:23:01 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 22 Mar 2022 09:22:50 +0000", "Message-Id": "<20220322092257.2713521-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220322092257.2713521-1-naush@raspberrypi.com>", "References": "<20220322092257.2713521-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 1/8] pipeline: raspberrypi: Avoid\n\tover-allocation for ISP Output 1", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The V4L2DeviceFormat structure for the ISP Output 1 node was a copy of what is\nused ISP Output 0 node, but with the size changed. However, the plane size and\nstride values were not updated. So there is a possibility that the buffer might\nbe over-sized for the requested resolution.\n\nFix this by only copying the relevant fields from the ISP Output 0\nV4L2DeviceFormat structure, and let the device driver size the planes as needed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c2230199fed7..43e87a406036 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -845,11 +845,13 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t * colour denoise will not run.\n \t */\n \tif (!output1Set) {\n-\t\tV4L2DeviceFormat output1Format = format;\n+\t\tV4L2DeviceFormat output1Format;\n \t\tconstexpr Size maxDimensions(1200, 1200);\n \t\tconst Size limit = maxDimensions.boundedToAspectRatio(format.size);\n \n \t\toutput1Format.size = (format.size / 2).boundedTo(limit).alignedDownTo(2, 2);\n+\t\toutput1Format.colorSpace = format.colorSpace;\n+\t\toutput1Format.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420);\n \n \t\tLOG(RPI, Debug) << \"Setting ISP Output1 (internal) to \"\n \t\t\t\t<< output1Format.toString();\n", "prefixes": [ "libcamera-devel", "v4", "1/8" ] }