Patch Detail
Show a patch.
GET /api/patches/15496/?format=api
{ "id": 15496, "url": "https://patchwork.libcamera.org/api/patches/15496/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15496/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220322024155.6528-5-hpa@redhat.com>", "date": "2022-03-22T02:41:55", "name": "[libcamera-devel,4/4] ipa: ipu3: agc: AE lock for AF scanning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8701ad95d7fd07e73e715c1d6269f5c01c530433", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15496/mbox/", "series": [ { "id": 2981, "url": "https://patchwork.libcamera.org/api/series/2981/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2981", "date": "2022-03-22T02:41:51", "name": "ipa: ipu3: af: Temporarily suspend AWB and AE during AF scanning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2981/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15496/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15496/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 666B0C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Mar 2022 02:42:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14E84604D4;\n\tTue, 22 Mar 2022 03:42:29 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B8BE604C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 03:42:27 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n\t[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-127-cyZcmdKFM2Gmu6mBSs5Hxg-1; Mon, 21 Mar 2022 22:42:25 -0400", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7D033C153A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 02:42:24 +0000 (UTC)", "from fedora.redhat.com (unknown [10.39.192.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 45CC7C26EA4;\n\tTue, 22 Mar 2022 02:42:22 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647916949;\n\tbh=AKwXqEAqL5AIaqoYdO07ZPKDFy9dBeD9BuCB7UzkghY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=yu/UkJumFmQdopedHZJoeVmZ5S72I94SDLrQ+FmNvG/fk05xWdu2cmErRHRIYNlnJ\n\ts1xopHQd3JlTFhNLrlToNu+Hg+oYy0OiIFbbdpbZ2X4rINXfTN/R4VNL1eq+VezgcZ\n\tfthHqKahNJvtzfV55YSZzEHE0SgtoNM/I3sXmJmjqDgbSJUTJMxv9xO+rappqDhJUT\n\ton7Z8lALdk1ae6wUZrkK7gCobzgyRfL79T2rqVA8dG9iSBVHonvaO1grronfzQ2S7p\n\telMAu23nQC/4nBl6CDFCEoTyL8uyG0E1FAQ9Byy0C7ySQy1Ooh7yma90RzlGOpCn+f\n\t0WzyzCaQpo+wg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1647916946;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=uHTuIVd9uI1qjYZ8rDDAXJfmO4GBGoSuLckQojWTq48=;\n\tb=EZvUDEJ73M17cT1pWdEd6IXlNynSGYtNbAr+alkH0LVKuFVYDdwH84WbtEdFKYA9qXvjUg\n\t74bwd0qmDNgiVYRZpgYlM0tXeNpw2f8pnmXTkDiG20xGvXp8Hb302XM9cXeEUxhX8sZE1+\n\tzyMbJWHypYhrDGWOfmNH9Aomq6TPIEQ=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"EZvUDEJ7\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com" ], "X-MC-Unique": "cyZcmdKFM2Gmu6mBSs5Hxg-1", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 22 Mar 2022 10:41:55 +0800", "Message-Id": "<20220322024155.6528-5-hpa@redhat.com>", "In-Reply-To": "<20220322024155.6528-1-hpa@redhat.com>", "References": "<20220322024155.6528-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[libcamera-devel] [PATCH 4/4] ipa: ipu3: agc: AE lock for AF\n\tscanning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kate Hsuan via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Kate Hsuan <hpa@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the AF starts to perform the scan, AWB will be suspended to maintain\nthe AF scene variance and improve the AF performance. Any changes in\nthe exposure value will lead to an incorrect focus value during scanning.\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 ++++++++++++++\n src/ipa/ipu3/algorithms/agc.h | 1 +\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 7d4b3503..2f28747a 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -314,6 +314,17 @@ double Agc::estimateLuminance(IPAFrameContext &frameContext,\n \treturn ySum / (grid.height * grid.width) / 255;\n }\n \n+/**\n+ * \\brief Test the AF requested lock is exist.\n+ */\n+bool Agc::isAfRequestedLock(IPAContext context)\n+{\n+\tif (context.configuration.af.requireAeAwbLock)\n+\t\treturn true;\n+\telse\n+\t\treturn false;\n+}\n+\n /**\n * \\brief Process IPU3 statistics, and run AGC operations\n * \\param[in] context The shared IPA context\n@@ -343,6 +354,9 @@ void Agc::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n \tdouble yGain = 1.0;\n \tdouble yTarget = kRelativeLuminanceTarget;\n \n+\tif (isAfRequestedLock(context))\n+\t\treturn;\n+\n \tfor (unsigned int i = 0; i < 8; i++) {\n \t\tdouble yValue = estimateLuminance(context.frameContext,\n \t\t\t\t\t\t context.configuration.grid.bdsGrid,\ndiff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\nindex ad705605..e00b28e5 100644\n--- a/src/ipa/ipu3/algorithms/agc.h\n+++ b/src/ipa/ipu3/algorithms/agc.h\n@@ -40,6 +40,7 @@ private:\n \t\t\t\t const ipu3_uapi_grid_config &grid,\n \t\t\t\t const ipu3_uapi_stats_3a *stats,\n \t\t\t\t double gain);\n+\tbool isAfRequestedLock(IPAContext context);\n \n \tuint64_t frameCount_;\n \n", "prefixes": [ "libcamera-devel", "4/4" ] }