Patch Detail
Show a patch.
GET /api/patches/15478/?format=api
{ "id": 15478, "url": "https://patchwork.libcamera.org/api/patches/15478/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15478/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220317150327.14073-1-david.plowman@raspberrypi.com>", "date": "2022-03-17T15:03:27", "name": "[libcamera-devel] ipa: raspberrypi: awb: Fix typo in AWB mode conversion table", "commit_ref": "b9b5e776f60ba5e679d744315df63378e2067dd4", "pull_url": null, "state": "accepted", "archived": false, "hash": "641a5b63ac4a432286383271eebc4605d50a070e", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15478/mbox/", "series": [ { "id": 2974, "url": "https://patchwork.libcamera.org/api/series/2974/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2974", "date": "2022-03-17T15:03:27", "name": "[libcamera-devel] ipa: raspberrypi: awb: Fix typo in AWB mode conversion table", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2974/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15478/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15478/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15A49BDE17\r\n\tfor <parsemail@patchwork.libcamera.org>;\r\n\tThu, 17 Mar 2022 15:03:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77C4D604DC;\r\n\tThu, 17 Mar 2022 16:03:32 +0100 (CET)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\r\n\t[IPv6:2a00:1450:4864:20::436])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5E5B601F8\r\n\tfor <libcamera-devel@lists.libcamera.org>;\r\n\tThu, 17 Mar 2022 16:03:30 +0100 (CET)", "by mail-wr1-x436.google.com with SMTP id x15so7727005wru.13\r\n\tfor <libcamera-devel@lists.libcamera.org>;\r\n\tThu, 17 Mar 2022 08:03:30 -0700 (PDT)", "from pi4-davidp.pitowers.org\r\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\r\n\tby smtp.gmail.com with ESMTPSA id\r\n\tr9-20020a05600c35c900b0038c7626c454sm2498116wmq.12.2022.03.17.08.03.29\r\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\r\n\tThu, 17 Mar 2022 08:03:29 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647529412;\r\n\tbh=T9tuBibbeomWnKC5S/jYicMMg4i3vmsItP/pmBWF1VM=;\r\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\r\n\tList-Help:List-Subscribe:From:Reply-To:From;\r\n\tb=nVtFxgMsu9XStdygf8zOkJ3v7Qg2UpJWaeABiTRgNjly6nkMmi87CbWPYiz6iEe46\r\n\tWg5Mp32O44py1H4xwpozoe7LNHR0Ri6pIW1djyE6UaQCpI+hTjRw/CXsr+IohEbEO+\r\n\taw8gPjU05zFoE5jq0JBM+jUYp+u+ZEgLI7j+ERbm1yQpihGdqSYdOwWkl7ep9P37yq\r\n\twPFIO/CNolSRMgEeAQ1Ln14gU3YC7p0fMBFd/oyIHYokPHGe0rs1ei0E2/BhduxDGB\r\n\t/4XrlI6CEPWERwxuXYZzZ3a5Z8XsZayAvJsIIlW6loQ6mWKjZ9rucGjNiWyrFvimZ/\r\n\toLlq3AI6rZ7Zg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\r\n\td=raspberrypi.com; s=google;\r\n\th=from:to:cc:subject:date:message-id:mime-version\r\n\t:content-transfer-encoding;\r\n\tbh=zxD+iyMZ5tDxR8vIih6izQLI3EQTQw5qE9HDLzm13dU=;\r\n\tb=HWguUzGT+ZIbhFFf+7Gnx6jbRPQ2rFUfPvBfHDc2uSS+mTmnJui1LBDEkMnAO7gTLB\r\n\tyo+urVSAl+hUJ2p4v8kiqO5vht27JB4ZFUdo8UveMjeFVra1jkP6eApS0HXmPJDFMzAl\r\n\tRmUxjhsQ3Z6Oa+FKhYUB6aa7PrDoYwePrrdIv5MosoqU16uhgJ7+UZ9ggpI4jobj8dQu\r\n\tG4hZs5fO3E/ZNxexyRU43PrDsF2Sw0B7O1bFH6H27OMLJLXWpJcsUVy8HMzzjC5npNs0\r\n\thffvmSz4Zfl75dOmLcNKou2Ejfz6uxs6pCStSH4PyGkZ4iO8Pw2+QBa72dCvcn2tcmfN\r\n\tgXqQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \r\n\tunprotected) header.d=raspberrypi.com\r\n\theader.i=@raspberrypi.com\r\n\theader.b=\"HWguUzGT\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\r\n\td=1e100.net; s=20210112;\r\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\r\n\t:content-transfer-encoding;\r\n\tbh=zxD+iyMZ5tDxR8vIih6izQLI3EQTQw5qE9HDLzm13dU=;\r\n\tb=t+wK3uybWtPvo29TQzlGfnuhJXTvhk92U35uLTfZ6z6TxSCvn+twxwM+vcFQb2ygVE\r\n\t2bgsrhjMACiXMaYECNrAwvZRwvcyy/tOyVggft0oy35qcZXIYbUx7+H6nhzFsenKCUWK\r\n\te7q/WHDqLnIF6nCOThEs+umt1GD+eyF4ZfYQTXJB9aHABpiiFQxH+LGRaqqV6nUd4QQf\r\n\tQ2v0bFLFIJrbK4C0R+R6iMzU3KtHiXcKA88zsD8zlCqcZwDXd6nvoBRg6Mauk2vpewFd\r\n\tYJ6xXL38gMP7SeAjFYTSOFX3qCYnjI/LkLQnIqHOXN2mbaJIyWtEcb333ybT0TnWKr7Y\r\n\tOByg==", "X-Gm-Message-State": "AOAM530p/FVwgg10yInHOfDdZfVhcKUupsTr4GCB8jnvQYE9AQB3bstC\r\n\tJZEN1KzfV3r8jEbdOGDJBHdCzVXIgMOY7A==", "X-Google-Smtp-Source": "ABdhPJx0NQP6Rx6+N/rpWujWBsASw41hAP4+YNkjhiD9s536qyaujhVNZTZXiy8vJrE080esi+WW/Q==", "X-Received": "by 2002:a05:6000:1704:b0:203:f042:156d with SMTP id\r\n\tn4-20020a056000170400b00203f042156dmr1579239wrc.164.1647529409980; \r\n\tThu, 17 Mar 2022 08:03:29 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 17 Mar 2022 15:03:27 +0000", "Message-Id": "<20220317150327.14073-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: awb: Fix typo in AWB\r\n\tmode conversion table", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AwbAuto mode is defined in all the JSON tuning files as \"auto\",\nnot \"normal\". The effect of this was that you couldn't switch back to\n\"auto\" mode once you had switched away.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\r\nindex fd8fecb0..1bf4e270 100644\r\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\r\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\r\n@@ -604,7 +604,7 @@ static const std::map<int32_t, std::string> ExposureModeTable = {\r\n };\r\n \r\n static const std::map<int32_t, std::string> AwbModeTable = {\r\n-\t{ controls::AwbAuto, \"normal\" },\r\n+\t{ controls::AwbAuto, \"auto\" },\r\n \t{ controls::AwbIncandescent, \"incandescent\" },\r\n \t{ controls::AwbTungsten, \"tungsten\" },\r\n \t{ controls::AwbFluorescent, \"fluorescent\" },", "prefixes": [ "libcamera-devel" ] }