Patch Detail
Show a patch.
GET /api/patches/15462/?format=api
{ "id": 15462, "url": "https://patchwork.libcamera.org/api/patches/15462/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15462/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220316222245.132315-3-djrscally@gmail.com>", "date": "2022-03-16T22:22:45", "name": "[libcamera-devel,2/2] libipa: Add CameraSensorHelper for OV2740", "commit_ref": "727428749c0566bc8861175b6b23d944562f1186", "pull_url": null, "state": "accepted", "archived": false, "hash": "d6e91a380345233b8efe3f86514e755696ddc32f", "submitter": { "id": 90, "url": "https://patchwork.libcamera.org/api/people/90/?format=api", "name": "Daniel Scally", "email": "djrscally@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15462/mbox/", "series": [ { "id": 2968, "url": "https://patchwork.libcamera.org/api/series/2968/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2968", "date": "2022-03-16T22:22:43", "name": "Add config for OV2740", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2968/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15462/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15462/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51C15BF415\r\n\tfor <parsemail@patchwork.libcamera.org>;\r\n\tWed, 16 Mar 2022 22:23:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6CA5610F8;\r\n\tWed, 16 Mar 2022 23:23:08 +0100 (CET)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\r\n\t[IPv6:2a00:1450:4864:20::42e])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4210610F8\r\n\tfor <libcamera-devel@lists.libcamera.org>;\r\n\tWed, 16 Mar 2022 23:23:06 +0100 (CET)", "by mail-wr1-x42e.google.com with SMTP id u10so4887833wra.9\r\n\tfor <libcamera-devel@lists.libcamera.org>;\r\n\tWed, 16 Mar 2022 15:23:06 -0700 (PDT)", "from localhost.localdomain\r\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\r\n\tby smtp.gmail.com with ESMTPSA id\r\n\t185-20020a1c19c2000000b0038a1d06e862sm6050969wmz.14.2022.03.16.15.23.04\r\n\tfor <libcamera-devel@lists.libcamera.org>\r\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\r\n\tWed, 16 Mar 2022 15:23:05 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647469388;\r\n\tbh=AavhEJBaaEFiZvXfiSzgvvaZn3Bp+oqgIWqFDpkeX54=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=tRyl55HUThEe5ijLspRZWHl7rKCRPsJuffpZW1GlP2x+NxtXGKypdZKjccWelmSlM\r\n\t5XPVQ0q8NRllXNKyXcc1O1lII6YUTg7MPhhIrCIpEyKcrxTUepQ7p7LH5Zwfbw0d1y\r\n\tGEeajvb18ZVNTVcATlt4qbycypRB4NKqu8wLgKB2hjr3og07KLitU8nu+L8mP3zWYO\r\n\t88kfRL+EZwwGQ2vJJHFSoa7ifUm44G1cUmrJYti4nu4b/XAbKev0UDkotvKl/bUgLA\r\n\tMIFFoEyettkqygFks7oHoC4geURnMxC9Mbst83zMoDxkkGun7EI4pksnaNSn7DXl/U\r\n\t5AbOtE7btYMyg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\r\n\th=from:to:subject:date:message-id:in-reply-to:references:mime-version\r\n\t:content-transfer-encoding;\r\n\tbh=HaX2Mqb30RxFycSjHLK1+3M+WLZBfYfkjiqsCZa0byk=;\r\n\tb=hwDFQsOK3UTivLS49XL/vW4WqyPDzRDhrHF4YADiih4i4s2uKEuBdKpNm+tH4g07bH\r\n\t4C3gOy7G88binje9MaIGKFzGj3jQki8+QLSW9MDhUW6sTF6S8gBCQmXChSlEwrRjCqun\r\n\tWTO6+hsTOI8QHYk/FyZt/4Kt/dEuGWwauUrhBI3fGmzo11eNKyZgK0iu/eIrq3o343D8\r\n\trzIDtRkhCVZy7vQ2fBfY0ndFnYUguzXStRE/hvnw7u3giUyKRyrvozCy+kgxovEBDSiy\r\n\tcxfEo49hDUIBGcSUZXsiZEtmoCI+G8rDAORoKgRPSX7buTNQQ++ha+3REjJhrrRt0M28\r\n\tRrIg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \r\n\tunprotected) header.d=gmail.com header.i=@gmail.com\r\n\theader.b=\"hwDFQsOK\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\r\n\td=1e100.net; s=20210112;\r\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\r\n\t:references:mime-version:content-transfer-encoding;\r\n\tbh=HaX2Mqb30RxFycSjHLK1+3M+WLZBfYfkjiqsCZa0byk=;\r\n\tb=nDh9aczsA6JplGtOfdCmkK0dZOL/8CyLcptYIXYlIIq7HHrF539WyRnA/AcS7Y5Hct\r\n\tc6OAqgFg1UYoJCYsKLBkMwarOhvRo7+1cvS2FFOzX493uVs5UWCduTk2JWb4G0mIOjzl\r\n\tydDrolRxOQ+lPF+8DhieNozikKYOva7NguDft2HEEEHqviKmCOr5YGHhJhBWXmo88tql\r\n\t/JRm0L87i0imQsPI8plwNv/kqO0F1BppZJrqjM3+wRVjLDh2QFTF+3RNw2cEKo9uGJ8G\r\n\tn1StWXpcAtdhUDtAw+CIkBJI6tB7w0gfd18MTRDgxk+wnTp+i8p9RFx9p9x8AfTGK0Rb\r\n\tPMag==", "X-Gm-Message-State": "AOAM531pmFzn4NXcDDcRsc8Njuj2vRIITRqKFBJ7nD1voQAAvfvJh8N8\r\n\tdHEd77ABDkIfeVZsBuL0oV8v0M0Xyi0=", "X-Google-Smtp-Source": "ABdhPJx+0Mnj9+5g+1A1hxeI933HxNLYtT4f27UelvDe0y4XOQA70ighOgir0XiYYPLCsQEZeWQLdg==", "X-Received": "by 2002:a5d:5846:0:b0:203:6b34:37af with SMTP id\r\n\ti6-20020a5d5846000000b002036b3437afmr1691332wrf.58.1647469385474; \r\n\tWed, 16 Mar 2022 15:23:05 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 16 Mar 2022 22:22:45 +0000", "Message-Id": "<20220316222245.132315-3-djrscally@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220316222245.132315-1-djrscally@gmail.com>", "References": "<20220316222245.132315-1-djrscally@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libipa: Add CameraSensorHelper for\r\n\tOV2740", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Scally via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Scally <djrscally@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The datasheet for the OV2740 gives 0x80 as 1x gain, so real gain\nis GainCode / 128.\n\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\r\nindex 5d052612..c953def0 100644\r\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\r\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\r\n@@ -305,6 +305,16 @@ public:\r\n };\r\n REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\r\n \r\n+class CameraSensorHelperOv2740 : public CameraSensorHelper\r\n+{\r\n+public:\r\n+\tCameraSensorHelperOv2740()\r\n+\t{\r\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\r\n+\t}\r\n+};\r\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\r\n+\r\n class CameraSensorHelperOv5670 : public CameraSensorHelper\r\n {\r\n public:", "prefixes": [ "libcamera-devel", "2/2" ] }