Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 15446,
    "url": "https://patchwork.libcamera.org/api/patches/15446/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/15446/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20220314154633.506026-3-tomi.valkeinen@ideasonboard.com>",
    "date": "2022-03-14T15:46:32",
    "name": "[libcamera-devel,v5,2/3] py: add unittests.py",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "3cdbb79cd4c1d28f663b6156a8d00fbcaecdd0e2",
    "submitter": {
        "id": 109,
        "url": "https://patchwork.libcamera.org/api/people/109/?format=api",
        "name": "Tomi Valkeinen",
        "email": "tomi.valkeinen@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/15446/mbox/",
    "series": [
        {
            "id": 2960,
            "url": "https://patchwork.libcamera.org/api/series/2960/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2960",
            "date": "2022-03-14T15:46:30",
            "name": "Python bindings",
            "version": 5,
            "mbox": "https://patchwork.libcamera.org/series/2960/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/15446/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/15446/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA9E1C3261\r\n\tfor <parsemail@patchwork.libcamera.org>;\r\n\tMon, 14 Mar 2022 15:47:00 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B31E632E3;\r\n\tMon, 14 Mar 2022 16:46:59 +0100 (CET)",
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF997610F8\r\n\tfor <libcamera-devel@lists.libcamera.org>;\r\n\tMon, 14 Mar 2022 16:46:57 +0100 (CET)",
            "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\r\n\t[91.156.85.209])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48E158EB;\r\n\tMon, 14 Mar 2022 16:46:57 +0100 (CET)"
        ],
        "DKIM-Signature": [
            "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647272819;\r\n\tbh=2KkBAAZ8B+xL9XZnxiuvErQ5BrHR8HVAsb+0kloDw1s=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=XPsUXp9BSDwpNP72ouU/c02ea7hvGKx1YF9/1XpAY/s5Jun2z8/MSnMAM8kY0prCc\r\n\ttXWspynJFYYj1ZwJvxwQP4dGgiKYJVhhTzt9UMRboKLTDYLn7e563PrULVcSFBdBs8\r\n\ttOQqno3glkLCzgd0QJCzQE3w3If6wmHJQw5V0mM6KGe++cIyuNjB4w6jTto1Iq12q7\r\n\tqeHCmHSInNfIlQKR+DcRkznjpvP38MXz+6k0NEpe+Al1SU9FOqo1Fedvg/1yH7reSs\r\n\ttDaWoPr5maKF9G9sH+D1Ca+FIsCqvvvLkxZBHTJ7jCAAA8envAE37B76MNcVRBL28+\r\n\tPGJC9oa53s/uA==",
            "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1647272817;\r\n\tbh=2KkBAAZ8B+xL9XZnxiuvErQ5BrHR8HVAsb+0kloDw1s=;\r\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\r\n\tb=R19z65URldHqUFWSjkfIh3P77oDjNNJ98FRFhy/AXb2OKZEoJOOLkS6vops5apT8C\r\n\tySUe9x/nnAgGPnHuPJslLEApCSWzQLEoht9Hi6zb+Qimi6beqcXgZ9RqugBcJ1ymHY\r\n\tjJEzIQ+BxGjytJkbwfp6L1fQTDIUBQBhqwQtb0Ik="
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"R19z65UR\"; dkim-atps=neutral",
        "To": "libcamera-devel@lists.libcamera.org,\r\n\tDavid Plowman <david.plowman@raspberrypi.com>,\r\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\r\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>",
        "Date": "Mon, 14 Mar 2022 17:46:32 +0200",
        "Message-Id": "<20220314154633.506026-3-tomi.valkeinen@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220314154633.506026-1-tomi.valkeinen@ideasonboard.com>",
        "References": "<20220314154633.506026-1-tomi.valkeinen@ideasonboard.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v5 2/3] py: add unittests.py",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "From": "Tomi Valkeinen via libcamera-devel\r\n\t<libcamera-devel@lists.libcamera.org>",
        "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "Add a simple unittests.py as a base for python unittests.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/test/unittests.py | 364 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 364 insertions(+)\n create mode 100755 src/py/test/unittests.py",
    "diff": "diff --git a/src/py/test/unittests.py b/src/py/test/unittests.py\r\nnew file mode 100755\r\nindex 00000000..ca3c37bf\r\n--- /dev/null\r\n+++ b/src/py/test/unittests.py\r\n@@ -0,0 +1,364 @@\r\n+#!/usr/bin/env python3\r\n+\r\n+# SPDX-License-Identifier: GPL-2.0-or-later\r\n+# Copyright (C) 2021, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\r\n+\r\n+from collections import defaultdict\r\n+import errno\r\n+import gc\r\n+import libcamera as libcam\r\n+import os\r\n+import selectors\r\n+import time\r\n+import unittest\r\n+import weakref\r\n+\r\n+class MyTestCase(unittest.TestCase):\r\n+\tdef assertZero(self, a, msg=None):\r\n+\t\tself.assertEqual(a, 0, msg)\r\n+\r\n+class SimpleTestMethods(MyTestCase):\r\n+\tdef test_find_ref(self):\r\n+\t\tcm = libcam.CameraManager.singleton()\r\n+\t\twr_cm = weakref.ref(cm)\r\n+\r\n+\t\tcam = cm.find(\"platform/vimc\")\r\n+\t\tself.assertIsNotNone(cam)\r\n+\t\twr_cam = weakref.ref(cam)\r\n+\r\n+\t\tcm = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNotNone(wr_cm())\r\n+\r\n+\t\tcam = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNone(wr_cm())\r\n+\t\tself.assertIsNone(wr_cam())\r\n+\r\n+\tdef test_get_ref(self):\r\n+\t\tcm = libcam.CameraManager.singleton()\r\n+\t\twr_cm = weakref.ref(cm)\r\n+\r\n+\t\tcam = cm.get(\"platform/vimc.0 Sensor B\")\r\n+\t\tself.assertTrue(cam != None)\r\n+\t\twr_cam = weakref.ref(cam)\r\n+\r\n+\t\tcm = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNotNone(wr_cm())\r\n+\r\n+\t\tcam = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNone(wr_cm())\r\n+\t\tself.assertIsNone(wr_cam())\r\n+\r\n+\tdef test_acquire_release(self):\r\n+\t\tcm = libcam.CameraManager.singleton()\r\n+\t\tcam = cm.get(\"platform/vimc.0 Sensor B\")\r\n+\t\tself.assertTrue(cam != None)\r\n+\r\n+\t\tret = cam.acquire()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tret = cam.release()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\tdef test_double_acquire(self):\r\n+\t\tcm = libcam.CameraManager.singleton()\r\n+\t\tcam = cm.get(\"platform/vimc.0 Sensor B\")\r\n+\t\tself.assertTrue(cam != None)\r\n+\r\n+\t\tret = cam.acquire()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tlibcam.logSetLevel(\"Camera\", \"FATAL\")\r\n+\t\tret = cam.acquire()\r\n+\t\tself.assertEqual(ret, -errno.EBUSY)\r\n+\t\tlibcam.logSetLevel(\"Camera\", \"ERROR\")\r\n+\r\n+\t\tret = cam.release()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tret = cam.release()\r\n+\t\t# I expected EBUSY, but looks like double release works fine\r\n+\t\tself.assertZero(ret)\r\n+\r\n+class CameraTesterBase(MyTestCase):\r\n+\tdef setUp(self):\r\n+\t\tself.cm = libcam.CameraManager.singleton()\r\n+\t\tself.cam = self.cm.find(\"platform/vimc\")\r\n+\t\tif self.cam == None:\r\n+\t\t\tself.cm = None\r\n+\t\t\traise Exception(\"No vimc found\")\r\n+\r\n+\t\tret = self.cam.acquire()\r\n+\t\tif ret != 0:\r\n+\t\t\tself.cam = None\r\n+\t\t\tself.cm = None\r\n+\t\t\traise Exception(\"Failed to acquire camera\")\r\n+\r\n+\tdef tearDown(self):\r\n+\t\t# If a test fails, the camera may be in running state. So always stop.\r\n+\t\tself.cam.stop()\r\n+\r\n+\t\tret = self.cam.release()\r\n+\t\tif ret != 0:\r\n+\t\t\traise Exception(\"Failed to release camera\")\r\n+\r\n+\t\tself.cam = None\r\n+\t\tself.cm = None\r\n+\r\n+\r\n+class AllocatorTestMethods(CameraTesterBase):\r\n+\tdef test_allocator(self):\r\n+\t\tcam = self.cam\r\n+\r\n+\t\tcamconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\r\n+\t\tself.assertTrue(camconfig.size == 1)\r\n+\t\twr_camconfig = weakref.ref(camconfig)\r\n+\r\n+\t\tstreamconfig = camconfig.at(0)\r\n+\t\twr_streamconfig = weakref.ref(streamconfig)\r\n+\r\n+\t\tret = cam.configure(camconfig);\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tstream = streamconfig.stream\r\n+\t\twr_stream = weakref.ref(stream)\r\n+\r\n+\t\t# stream should keep streamconfig and camconfig alive\r\n+\t\tstreamconfig = None\r\n+\t\tcamconfig = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNotNone(wr_camconfig())\r\n+\t\tself.assertIsNotNone(wr_streamconfig())\r\n+\r\n+\t\tallocator = libcam.FrameBufferAllocator(cam);\r\n+\t\tret = allocator.allocate(stream)\r\n+\t\tself.assertTrue(ret > 0)\r\n+\t\twr_allocator = weakref.ref(allocator)\r\n+\r\n+\t\tbuffers = allocator.buffers(stream)\r\n+\t\tbuffers = None\r\n+\r\n+\r\n+\t\tbuffer = allocator.buffers(stream)[0]\r\n+\t\tself.assertIsNotNone(buffer)\r\n+\t\twr_buffer = weakref.ref(buffer)\r\n+\r\n+\t\tallocator = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNotNone(wr_buffer())\r\n+\t\tself.assertIsNotNone(wr_allocator())\r\n+\t\tself.assertIsNotNone(wr_stream())\r\n+\r\n+\t\tbuffer = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNone(wr_buffer())\r\n+\t\tself.assertIsNone(wr_allocator())\r\n+\t\tself.assertIsNotNone(wr_stream())\r\n+\r\n+\t\tstream = None\r\n+\t\tgc.collect()\r\n+\t\tself.assertIsNone(wr_stream())\r\n+\t\tself.assertIsNone(wr_camconfig())\r\n+\t\tself.assertIsNone(wr_streamconfig())\r\n+\r\n+\r\n+class SimpleCaptureMethods(CameraTesterBase):\r\n+\tdef test_sleep(self):\r\n+\t\tcm = self.cm\r\n+\t\tcam = self.cam\r\n+\r\n+\t\tcamconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\r\n+\t\tself.assertTrue(camconfig.size == 1)\r\n+\r\n+\t\tstreamconfig = camconfig.at(0)\r\n+\t\tfmts = streamconfig.formats\r\n+\r\n+\t\tret = cam.configure(camconfig);\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tstream = streamconfig.stream\r\n+\r\n+\t\tallocator = libcam.FrameBufferAllocator(cam);\r\n+\t\tret = allocator.allocate(stream)\r\n+\t\tself.assertTrue(ret > 0)\r\n+\r\n+\t\tnum_bufs = len(allocator.buffers(stream))\r\n+\r\n+\t\treqs = []\r\n+\t\tfor i in range(num_bufs):\r\n+\t\t\treq = cam.createRequest(i)\r\n+\t\t\tself.assertIsNotNone(req)\r\n+\r\n+\t\t\tbuffer = allocator.buffers(stream)[i]\r\n+\t\t\tret = req.addBuffer(stream, buffer)\r\n+\t\t\tself.assertZero(ret)\r\n+\r\n+\t\t\treqs.append(req)\r\n+\r\n+\t\tbuffer = None\r\n+\r\n+\t\tret = cam.start()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tfor req in reqs:\r\n+\t\t\tret = cam.queueRequest(req)\r\n+\t\t\tself.assertZero(ret)\r\n+\r\n+\t\treqs = None\r\n+\t\tgc.collect()\r\n+\r\n+\t\ttime.sleep(0.5)\r\n+\r\n+\t\treqs = cm.getReadyRequests()\r\n+\r\n+\t\tself.assertTrue(len(reqs) == num_bufs)\r\n+\r\n+\t\tfor i, req in enumerate(reqs):\r\n+\t\t\tself.assertTrue(i == req.cookie)\r\n+\r\n+\t\treqs = None\r\n+\t\tgc.collect()\r\n+\r\n+\t\tret = cam.stop()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\r\n+\tdef test_select(self):\r\n+\t\tcm = self.cm\r\n+\t\tcam = self.cam\r\n+\r\n+\t\tcamconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\r\n+\t\tself.assertTrue(camconfig.size == 1)\r\n+\r\n+\t\tstreamconfig = camconfig.at(0)\r\n+\t\tfmts = streamconfig.formats\r\n+\r\n+\t\tret = cam.configure(camconfig);\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tstream = streamconfig.stream\r\n+\r\n+\t\tallocator = libcam.FrameBufferAllocator(cam);\r\n+\t\tret = allocator.allocate(stream)\r\n+\t\tself.assertTrue(ret > 0)\r\n+\r\n+\t\tnum_bufs = len(allocator.buffers(stream))\r\n+\r\n+\t\treqs = []\r\n+\t\tfor i in range(num_bufs):\r\n+\t\t\treq = cam.createRequest(i)\r\n+\t\t\tself.assertIsNotNone(req)\r\n+\r\n+\t\t\tbuffer = allocator.buffers(stream)[i]\r\n+\t\t\tret = req.addBuffer(stream, buffer)\r\n+\t\t\tself.assertZero(ret)\r\n+\r\n+\t\t\treqs.append(req)\r\n+\r\n+\t\tbuffer = None\r\n+\r\n+\t\tret = cam.start()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\t\tfor req in reqs:\r\n+\t\t\tret = cam.queueRequest(req)\r\n+\t\t\tself.assertZero(ret)\r\n+\r\n+\t\treqs = None\r\n+\t\tgc.collect()\r\n+\r\n+\t\tsel = selectors.DefaultSelector()\r\n+\t\tsel.register(cm.efd, selectors.EVENT_READ, 123)\r\n+\r\n+\t\treqs = []\r\n+\r\n+\t\trunning = True\r\n+\t\twhile running:\r\n+\t\t\tevents = sel.select()\r\n+\t\t\tfor key, mask in events:\r\n+\t\t\t\tos.read(key.fileobj, 8)\r\n+\r\n+\t\t\t\tl = cm.getReadyRequests()\r\n+\r\n+\t\t\t\tself.assertTrue(len(l) > 0)\r\n+\r\n+\t\t\t\treqs += l\r\n+\r\n+\t\t\t\tif len(reqs) == num_bufs:\r\n+\t\t\t\t\trunning = False\r\n+\r\n+\t\tself.assertTrue(len(reqs) == num_bufs)\r\n+\r\n+\t\tfor i, req in enumerate(reqs):\r\n+\t\t\tself.assertTrue(i == req.cookie)\r\n+\r\n+\t\treqs = None\r\n+\t\tgc.collect()\r\n+\r\n+\t\tret = cam.stop()\r\n+\t\tself.assertZero(ret)\r\n+\r\n+\r\n+\r\n+# Recursively expand slist's objects into olist, using seen to track already\r\n+# processed objects.\r\n+def _getr(slist, olist, seen):\r\n+\tfor e in slist:\r\n+\t\tif id(e) in seen:\r\n+\t\t\tcontinue\r\n+\t\tseen.add(id(e))\r\n+\t\tolist.append(e)\r\n+\t\ttl = gc.get_referents(e)\r\n+\t\tif tl:\r\n+\t\t\t_getr(tl, olist, seen)\r\n+\r\n+def get_all_objects(ignored = []):\r\n+\tgcl = gc.get_objects()\r\n+\tolist = []\r\n+\tseen = set()\r\n+\r\n+\tseen.add(id(gcl))\r\n+\tseen.add(id(olist))\r\n+\tseen.add(id(seen))\r\n+\tseen.update(set([id(o) for o in ignored]))\r\n+\r\n+\t_getr(gcl, olist, seen)\r\n+\r\n+\treturn olist\r\n+\r\n+def create_type_count_map(olist):\r\n+\tmap = defaultdict(int)\r\n+\tfor o in olist:\r\n+\t\tmap[type(o)] += 1\r\n+\treturn map\r\n+\r\n+def diff_type_count_maps(before, after):\r\n+\treturn [(k, after[k] - before[k]) for k in after if after[k] != before[k]]\r\n+\r\n+if __name__ == '__main__':\r\n+\t# doesn't work very well, as things always leak a bit\r\n+\ttest_leaks = False\r\n+\r\n+\tif test_leaks:\r\n+\t\tgc.unfreeze()\r\n+\t\tgc.collect()\r\n+\r\n+\t\tobs_before = get_all_objects()\r\n+\r\n+\tunittest.main(exit=False)\r\n+\r\n+\tif test_leaks:\r\n+\t\tgc.unfreeze()\r\n+\t\tgc.collect()\r\n+\r\n+\t\tobs_after = get_all_objects([obs_before])\r\n+\r\n+\t\tbefore = create_type_count_map(obs_before)\r\n+\t\tafter = create_type_count_map(obs_after)\r\n+\r\n+\t\tleaks = diff_type_count_maps(before, after)\r\n+\t\tif len(leaks) > 0:\r\n+\t\t\tprint(leaks)",
    "prefixes": [
        "libcamera-devel",
        "v5",
        "2/3"
    ]
}