Patch Detail
Show a patch.
GET /api/patches/15403/?format=api
{ "id": 15403, "url": "https://patchwork.libcamera.org/api/patches/15403/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15403/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220303110639.3469390-1-kieran.bingham@ideasonboard.com>", "date": "2022-03-03T11:06:39", "name": "[libcamera-devel] v4l2: camera_proxy: Fix header include order", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "05a8c2d76fd45afecab5e0cb52012dd3f123c289", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15403/mbox/", "series": [ { "id": 2947, "url": "https://patchwork.libcamera.org/api/series/2947/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2947", "date": "2022-03-03T11:06:39", "name": "[libcamera-devel] v4l2: camera_proxy: Fix header include order", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2947/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15403/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15403/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D415FBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Mar 2022 11:06:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17F286115E;\n\tThu, 3 Mar 2022 12:06:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD19601FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Mar 2022 12:06:44 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46ECF885;\n\tThu, 3 Mar 2022 12:06:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FC9IW8+Z\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646305604;\n\tbh=wliCWh+os367vtKtBb7/BzrBzTDBZyDzIOlWEUZy2kg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FC9IW8+ZYvpST5ywNLc9Oeb8wbHQK+S1C+qMy/BOVNvkQMrJi/cnIAyC5QLjvMLeh\n\t30NbgWEGJW4x0XcmHX+bZRbXARwNFSvyoH5emYhd4nNBdlW7ve/cmkpnLdZo2aIC0L\n\t3xz+mkns3VIz2yTcQGCJnYOaJ6ktO1nmwjzW7uqg=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 3 Mar 2022 11:06:39 +0000", "Message-Id": "<20220303110639.3469390-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] v4l2: camera_proxy: Fix header include\n\torder", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The includes in the v4l2_camera_proxy do not match the code styel\nand trigger clang-format changes when running checkstyle.\n\nUpdate and fix the include order accordingly\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)\n\nNote, this might likely only apply on top of the pending V4L2 frame rate\npatch.", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 493c41c0ad0f..4427ae3302d8 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -10,22 +10,23 @@\n #include <algorithm>\n #include <array>\n #include <errno.h>\n-#include <linux/videodev2.h>\n #include <numeric>\n #include <set>\n #include <string.h>\n #include <sys/mman.h>\n #include <unistd.h>\n \n-#include <libcamera/camera.h>\n-#include <libcamera/controls.h>\n-#include <libcamera/control_ids.h>\n-#include <libcamera/formats.h>\n+#include <linux/videodev2.h>\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/object.h>\n #include <libcamera/base/utils.h>\n \n+#include <libcamera/camera.h>\n+#include <libcamera/control_ids.h>\n+#include <libcamera/controls.h>\n+#include <libcamera/formats.h>\n+\n #include \"libcamera/internal/formats.h\"\n \n #include \"v4l2_camera.h\"\n", "prefixes": [ "libcamera-devel" ] }