Patch Detail
Show a patch.
GET /api/patches/15360/?format=api
{ "id": 15360, "url": "https://patchwork.libcamera.org/api/patches/15360/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15360/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220210114316.1151170-3-jeanmichel.hautbois@ideasonboard.com>", "date": "2022-02-10T11:43:15", "name": "[libcamera-devel,v3,2/3] ipa: ipu3: Shorten exposure and gain lines", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "51a285f01f21743de051a8c7c210c0bede25162d", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15360/mbox/", "series": [ { "id": 2928, "url": "https://patchwork.libcamera.org/api/series/2928/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2928", "date": "2022-02-10T11:43:13", "name": "ipa: ipu3: Misc clean up", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2928/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15360/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15360/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59015BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Feb 2022 11:43:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB68B610F4;\n\tThu, 10 Feb 2022 12:43:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5C4A610AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Feb 2022 12:43:20 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c44d:925d:d63:5b07])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DACD491;\n\tThu, 10 Feb 2022 12:43:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pOO0hsm+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1644493400;\n\tbh=ZDm9VKGFF43duA1wbbFF797P0YbVhnM4JL6qJmSB5V4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pOO0hsm+fCwMPdoSJoyCyxLpghi/sVuX+nhfyKo1lbTlw1ac2BLfe+GAzdB4PYmkY\n\txYCmuaQye8gI88cB8m1rDCLmaJv7jE255G3Nu+Y5Mwhn3W8wfwUvBXpNBWsKvQk+6X\n\tVYeAbCmB+8Xixl1Bphg7Et7x9B652KB1mwDsmyTc=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 10 Feb 2022 12:43:15 +0100", "Message-Id": "<20220210114316.1151170-3-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220210114316.1151170-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20220210114316.1151170-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/3] ipa: ipu3: Shorten exposure and\n\tgain lines", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the effective sensor values are stored during the EventStatReady\nevent, the lines are long. Fix it.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 3d307708..c0c29416 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -547,8 +547,11 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tconst ipu3_uapi_stats_3a *stats =\n \t\t\treinterpret_cast<ipu3_uapi_stats_3a *>(mem.data());\n \n-\t\tcontext_.frameContext.sensor.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n-\t\tcontext_.frameContext.sensor.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>());\n+\t\tint32_t exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n+\t\tint32_t gain = event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>();\n+\n+\t\tcontext_.frameContext.sensor.exposure = exposure;\n+\t\tcontext_.frameContext.sensor.gain = camHelper_->gain(gain);\n \n \t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n \t\tbreak;\n", "prefixes": [ "libcamera-devel", "v3", "2/3" ] }