Patch Detail
Show a patch.
GET /api/patches/15350/?format=api
{ "id": 15350, "url": "https://patchwork.libcamera.org/api/patches/15350/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15350/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220209071917.559993-7-hanlinchen@chromium.org>", "date": "2022-02-09T07:19:14", "name": "[libcamera-devel,6/9] android: Set PipelineConfigFile option if it's supported by the camera", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f12ae68cbd14c29efb3f3b656bb288e6511b4dfe", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15350/mbox/", "series": [ { "id": 2923, "url": "https://patchwork.libcamera.org/api/series/2923/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2923", "date": "2022-02-09T07:19:08", "name": "Introduce Pipeline configuration preference for IPU3", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2923/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15350/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15350/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AB1AC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 9 Feb 2022 07:19:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3ED83610AD;\n\tWed, 9 Feb 2022 08:19:42 +0100 (CET)", "from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C52DA610AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 9 Feb 2022 08:19:38 +0100 (CET)", "by mail-pj1-x102e.google.com with SMTP id\n\tt4-20020a17090a510400b001b8c4a6cd5dso1388767pjh.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 08 Feb 2022 23:19:38 -0800 (PST)", "from localhost ([2401:fa00:1:10:a5cf:9a43:1c6d:824])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\th18sm18038960pfh.51.2022.02.08.23.19.35\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 08 Feb 2022 23:19:36 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"JH8e250O\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=fa3mkD3ACoS+DPsjqPN52SMehX2h2X5YPUKVCZ/aGyc=;\n\tb=JH8e250OnhXTvoWjgNbqSCcFIJ81FBcZTEuC7FuVixpB6HjUX/GK3HqhCrYFdN7+/F\n\tDYdSFivv5hC4Xb0s+2MhFiGMbaySXc+o4bU/QssiVm/oNhdFuLQLgyf+HHXOzllcNAV4\n\t2/ksbk0HC01Dj9dZTZZj2eN4LI61bvlXcHtEY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=fa3mkD3ACoS+DPsjqPN52SMehX2h2X5YPUKVCZ/aGyc=;\n\tb=AvQ8BzAd9q/HPoV/04ghyMCRBtaxc6UXCl28s/S//BjLgZVKECcmDtMRx90RNxHCby\n\tDYImdFALmYQiQH04hbX7jA0QazNNJ5+PC7GoEOH///6g7iKpdRZiUaU2xC9cXUZ05G4C\n\tl5Wd0zf9mlA37V/ybreDW2Aa6wszTfw5Y4ufbcQRFwitnNIEcyr8cAP2XqKV0qOpKZCW\n\tnq8QCGuhSy9mQbdw6tCkRIy86/V4SPht5XxzioDCvN8vDq45m/qCoBmu5HGq+3glsGr3\n\tG+h4p/zWyMsqAkfPTYGRfPk2Kv0ERJOr7OXJxNUV+P9PFHkg4XBgZd9fVgegZZbH4Ght\n\tHE7Q==", "X-Gm-Message-State": "AOAM531ZArc5Gcjdya1Pmt92GuVYpifKRWmcxzjS5WLfyI8q/ePS1Vpp\n\ttdNkVuhWSzQA/S3bUUEJ28cHCXi8wcdo0g==", "X-Google-Smtp-Source": "ABdhPJwwmcDov8KaFQyWQKI2s6BBDXEbwrgpf25RfRin8CF+3LWkvMQmYfGZWB7UezH/aKIUUVdaHQ==", "X-Received": "by 2002:a17:902:760e:: with SMTP id\n\tk14mr923625pll.11.1644391176663; \n\tTue, 08 Feb 2022 23:19:36 -0800 (PST)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 9 Feb 2022 15:19:14 +0800", "Message-Id": "<20220209071917.559993-7-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.35.0.263.gb82422642f-goog", "In-Reply-To": "<20220209071917.559993-1-hanlinchen@chromium.org>", "References": "<20220209071917.559993-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 6/9] android: Set PipelineConfigFile\n\toption if it's supported by the camera", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the libcamera::Camera supports the PipelineConfigFile option and\nthe HAL configuration file provides the path, set the option before\nopening the camera.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n src/android/camera_device.cpp | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 83825736..61883a54 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -20,6 +20,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n #include <libcamera/fence.h>\n+#include <libcamera/option_ids.h>\n #include <libcamera/formats.h>\n #include <libcamera/property_ids.h>\n \n@@ -293,6 +294,24 @@ std::unique_ptr<CameraDevice> CameraDevice::create(unsigned int id,\n */\n int CameraDevice::initialize(const CameraConfigData *cameraConfigData)\n {\n+\t/*\n+\t * Initialize pipeline configuration file for the camera.\n+\t *\n+\t * If the libcamera::Camera supports the PipelineConfigFile option and\n+\t * the HAL configuration file provides the path, set the option before\n+\t * opening the camera.\n+\t */\n+\tconst ControlInfoMap optionInfo = camera_->options();\n+\n+\tif (cameraConfigData &&\n+\t cameraConfigData->pipelineConfigFile != \"\" &&\n+\t optionInfo.count(&options::PipelineConfigFile)) {\n+\t\tControlList options(optionInfo);\n+\t\toptions.set(options::PipelineConfigFile,\n+\t\t\t cameraConfigData->pipelineConfigFile);\n+\t\tcamera_->setOptions(&options);\n+\t}\n+\n \t/*\n \t * Initialize orientation and facing side of the camera.\n \t *\n", "prefixes": [ "libcamera-devel", "6/9" ] }