Patch Detail
Show a patch.
GET /api/patches/15310/?format=api
{ "id": 15310, "url": "https://patchwork.libcamera.org/api/patches/15310/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15310/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220131223330.61563-6-djrscally@gmail.com>", "date": "2022-01-31T22:33:26", "name": "[libcamera-devel,v4,5/9] libcamera: camera_lens: Add function to fetch subdev controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4728489250600e81d519da328b2c736da48539f0", "submitter": { "id": 90, "url": "https://patchwork.libcamera.org/api/people/90/?format=api", "name": "Daniel Scally", "email": "djrscally@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15310/mbox/", "series": [ { "id": 2906, "url": "https://patchwork.libcamera.org/api/series/2906/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2906", "date": "2022-01-31T22:33:21", "name": "Enumerate CameraLens by following sensor's ancillary links", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2906/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15310/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15310/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FF5DBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Jan 2022 22:33:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C8FB609E8;\n\tMon, 31 Jan 2022 23:33:49 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81A6B609D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Jan 2022 23:33:46 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id e8so28326509wrc.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Jan 2022 14:33:46 -0800 (PST)", "from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tq2sm6986740wrw.14.2022.01.31.14.33.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 31 Jan 2022 14:33:45 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qWSnFyBJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=yFC5s+Pzgarvt9s+APTlL0sMrtYNwNCuu7nzx0YKnEQ=;\n\tb=qWSnFyBJEVRAbITvVhOQr2q7FS0USxZ9/MSMHeZVYmsxe7G96FL+ZsgDV5KrcRISZ3\n\tYjvPOgLaY2j7Lv+kMbFaIttUfKdS+92b6uH09XP95p3TOwE3XJtfu3kc2BGtaPyW9WEt\n\tLMALMCIy4aS7tU8cPh/uxleHK3I7JeYMXXh0beH9oheN9KPIguikZesZFdPedGQcjQld\n\tdZ4N8DlEysvV5q1Oi0FPmTL027dbaO0s1vu5EwXKG/6BiLbdAV+2cjjBAOAlZKaPbP8U\n\tMkGxLZAcB+N/NmyIvNjNN0SEP5SieyYNc6spU7aVsucX2PTxCFkV3aiw7P9rEQlLxoB2\n\tsASQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=yFC5s+Pzgarvt9s+APTlL0sMrtYNwNCuu7nzx0YKnEQ=;\n\tb=tEehKVhGpuqzkSO7udg4d3ecx2X0PvMw337xtXAliPz8cTD6WhXsrbQ1w7eas/wRBp\n\tH4257Z5GjCudD8ZdynBmP2ojTmvph4cOy1xwqtsJzsO6zcb7IaU9UtEC58C4N/gv1Mf4\n\tRMiou18fqYkdc/6nQXSAKwpmmD9dLYrlYwjjf2aQ+EaaV5apKQeX9oraFQJVBuDwAxKG\n\tFFaJ1Cu/CI0pBy15SRYTEY0eKRVPmzaqjbZTsN/1m90fvQXHQ47bW56pH1Y15+WRbwqZ\n\tK/HWFfB1C2hPbHdEbC8gp5mxVdhr8tme14mYhT1xzBEVDf3DJKN8AFlQemtq9vfuSnEA\n\tymoQ==", "X-Gm-Message-State": "AOAM533TIP/hhZ33+uj7PhZ60hw5lRLREWHCg2kI42KV4jHes/446hZ+\n\t9C0SclosKV0pMfRjC5pkZ7VZF+L4Fcg=", "X-Google-Smtp-Source": "ABdhPJz0qFROFTUn+CWhFu0uQD7PSehdYFYqZZrA0Go2FSPjdI14BP2Na+neXTg5fm/kdJqy3J3jAg==", "X-Received": "by 2002:adf:f8c6:: with SMTP id\n\tf6mr19286877wrq.290.1643668426330; \n\tMon, 31 Jan 2022 14:33:46 -0800 (PST)", "From": "Daniel Scally <djrscally@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 31 Jan 2022 22:33:26 +0000", "Message-Id": "<20220131223330.61563-6-djrscally@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220131223330.61563-1-djrscally@gmail.com>", "References": "<20220131223330.61563-1-djrscally@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 5/9] libcamera: camera_lens: Add\n\tfunction to fetch subdev controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a function to the CameraLens class to fetch the V4L2 controls\nfor its V4L2 subdev\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\n\nChanges since v4:\n\n\t- None\n\nChanges in v3:\n\n\t- s/sensor/lens\n\n include/libcamera/internal/camera_lens.h | 4 ++++\n src/libcamera/camera_lens.cpp | 11 +++++++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\nindex 6f2ea1bc..64794294 100644\n--- a/include/libcamera/internal/camera_lens.h\n+++ b/include/libcamera/internal/camera_lens.h\n@@ -12,6 +12,8 @@\n #include <libcamera/base/class.h>\n #include <libcamera/base/log.h>\n \n+#include <libcamera/controls.h>\n+\n namespace libcamera {\n \n class MediaEntity;\n@@ -28,6 +30,8 @@ public:\n \n \tconst std::string &model() const { return model_; }\n \n+\tconst ControlInfoMap &controls() const;\n+\n protected:\n \tstd::string logPrefix() const override;\n \ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\nindex 189cb025..142390ed 100644\n--- a/src/libcamera/camera_lens.cpp\n+++ b/src/libcamera/camera_lens.cpp\n@@ -139,4 +139,15 @@ std::string CameraLens::logPrefix() const\n \treturn \"'\" + entity_->name() + \"'\";\n }\n \n+/**\n+ * \\fn CameraLens::controls()\n+ * \\brief Retrieve the V4L2 controls of the lens' subdev\n+ *\n+ * \\return A map of the V4L2 controls supported by the lens' driver\n+ */\n+const ControlInfoMap &CameraLens::controls() const\n+{\n+\treturn subdev_->controls();\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v4", "5/9" ] }