Patch Detail
Show a patch.
GET /api/patches/15298/?format=api
{ "id": 15298, "url": "https://patchwork.libcamera.org/api/patches/15298/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15298/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220130235821.48076-2-djrscally@gmail.com>", "date": "2022-01-30T23:58:16", "name": "[libcamera-devel,v2,1/6] media: entity: Skip non-data links in graph iteration", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "4def1a7502cd5a0275e8a64b5c7985ea99fcfd1a", "submitter": { "id": 90, "url": "https://patchwork.libcamera.org/api/people/90/?format=api", "name": "Daniel Scally", "email": "djrscally@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15298/mbox/", "series": [ { "id": 2904, "url": "https://patchwork.libcamera.org/api/series/2904/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2904", "date": "2022-01-30T23:58:15", "name": "Introduce ancillary links", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2904/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15298/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15298/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A465BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 30 Jan 2022 23:59:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 040FE609D6;\n\tMon, 31 Jan 2022 00:59:10 +0100 (CET)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EEB36017A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Jan 2022 00:59:07 +0100 (CET)", "by mail-wr1-x42a.google.com with SMTP id l25so21992977wrb.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 30 Jan 2022 15:59:07 -0800 (PST)", "from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t11sm11993663wrb.30.2022.01.30.15.59.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 30 Jan 2022 15:59:06 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nYgorl02\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KKgmf5edtGbJ9h0LX6rTJGe7gf+2myJfiAdHSNMIYE4=;\n\tb=nYgorl02OBSDDoz2QxOJC326/TYULEbc85Zv6g28GOEBMSx3GXxLBU58R7vfoLOH5g\n\trV8QrgkA0jVq+M9+xwDY+wpEroN2jdpiptPsihygQ3DF++4UqU47ewCcUwmoe+fJ64dZ\n\tEbhGt3Saxr6gnQYDdsDKVGjd1SzP6RXM/XYi8zmC0aJb24CdWGEo3/7r32Sq+zedfJi2\n\tkmldQkOU62qPVo5mglljgwhW3YMj5TuluAPn54d7nM5QBwYzqiTLRZRzrvjANSEkYNp4\n\tovhsLy4a4E3xVJM7OzD6W6aGyMekp4x/1vGY+ltj4TVh1Q3rJRckcZWobVow9OJXHuV3\n\tYxyQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=KKgmf5edtGbJ9h0LX6rTJGe7gf+2myJfiAdHSNMIYE4=;\n\tb=bL9+kzpddYskkHICS/xpukEHK5QoqULZ9I4H3LLg+WIDiRT/Pvq2S+jUJraG5BWrZx\n\tC2QdhksxRY/D8s1nSuyupj0uHXQBQ+ZkU8WE82cJFoxvSwO55m31tG9v89i5y0YQ8sD0\n\tjzC5MIjNReoLOX/uuEXgYVHHq1B20hftm6+jzmRorqo81p5raZQPfw5/txYu0KZoTkaX\n\tOjFcxBaDzhBOXZCfvuP+x0FmWb7U3Gi8C+pXblv11cJZILXfciCZnr3PTDsawi6Ivfyb\n\t9FrzVj1vrLRzM4fMN7+TvE311sDLu9lI9vwhCLtIpp7l0sMyoYGeqsMV5lTS+PriyWpF\n\t7Z8A==", "X-Gm-Message-State": "AOAM531noBX82tFb347xA86dpWT8dcIR5cmzeGFdD1EHebkaaes9jNrs\n\t7ByHIx7coOmz6zJPTUlGDK0Rb73cLfc=", "X-Google-Smtp-Source": "ABdhPJy6S71fEhugp7GLdCYTygZWbK5lcBNNm0V6Ac0Tba1URoZGFjJWELe82FhEZDh+HHnuWLxBCw==", "X-Received": "by 2002:adf:f312:: with SMTP id\n\ti18mr14806019wro.441.1643587147127; \n\tSun, 30 Jan 2022 15:59:07 -0800 (PST)", "From": "Daniel Scally <djrscally@gmail.com>", "To": "linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org", "Date": "Sun, 30 Jan 2022 23:58:16 +0000", "Message-Id": "<20220130235821.48076-2-djrscally@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220130235821.48076-1-djrscally@gmail.com>", "References": "<20220130235821.48076-1-djrscally@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/6] media: entity: Skip non-data links\n\tin graph iteration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "sakari.ailus@linux.intel.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When iterating over the media graph, don't follow links that are not\ndata links.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\n\nChanges since v1:\n\n\t- Moved to the head of the series\n\t- s/pad-to-pad/data (Sakari)\n\t- Dropped the debug message (Laurent)\n\nChanges since the rfc:\n\n\t- new patch\n\n drivers/media/mc/mc-entity.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\nindex f40f41977142..2a6e16fb0048 100644\n--- a/drivers/media/mc/mc-entity.c\n+++ b/drivers/media/mc/mc-entity.c\n@@ -313,6 +313,12 @@ static void media_graph_walk_iter(struct media_graph *graph)\n \n \tlink = list_entry(link_top(graph), typeof(*link), list);\n \n+\t/* If the link is not a data link, don't follow it */\n+\tif ((link->flags & MEDIA_LNK_FL_LINK_TYPE) != MEDIA_LNK_FL_DATA_LINK) {\n+\t\tlink_top(graph) = link_top(graph)->next;\n+\t\treturn;\n+\t}\n+\n \t/* The link is not enabled so we do not follow. */\n \tif (!(link->flags & MEDIA_LNK_FL_ENABLED)) {\n \t\tlink_top(graph) = link_top(graph)->next;\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }