Patch Detail
Show a patch.
GET /api/patches/15294/?format=api
{ "id": 15294, "url": "https://patchwork.libcamera.org/api/patches/15294/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15294/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220124103107.1799464-2-naush@raspberrypi.com>", "date": "2022-01-24T10:31:07", "name": "[libcamera-devel,v1,2/2] ipa: raspberrypi: config: Increase the max gain in the exposure profiles", "commit_ref": "348a273c2bab1fc9524e1f2032fb46109e252ee9", "pull_url": null, "state": "accepted", "archived": false, "hash": "e63072c5098ac85678ac6819ea5f7cb5823b3b4d", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15294/mbox/", "series": [ { "id": 2901, "url": "https://patchwork.libcamera.org/api/series/2901/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2901", "date": "2022-01-24T10:31:06", "name": "[libcamera-devel,v1,1/2] ipa: raspberrypi: Limit the maximum sensor gain used", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2901/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15294/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15294/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57848BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Jan 2022 10:31:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01F2160215;\n\tMon, 24 Jan 2022 11:31:13 +0100 (CET)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 982F460215\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Jan 2022 11:31:11 +0100 (CET)", "by mail-wm1-x330.google.com with SMTP id\n\tf202-20020a1c1fd3000000b0034dd403f4fbso23968146wmf.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Jan 2022 02:31:11 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:d877:8ca4:c9e0:6bb7])\n\tby smtp.gmail.com with ESMTPSA id\n\tx6sm16285480wrn.18.2022.01.24.02.31.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 24 Jan 2022 02:31:10 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"MgqEVPQ3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=VuvwQc+xnjO1R8Rc2f7WGY1FuJD6++xIIZDUxkQmoJU=;\n\tb=MgqEVPQ3NX3SSWuov2Mn+bCf2xpzXKET5YSVed1Dz12aSoTl7UR2GJioU0ETS2Xppv\n\tqIceWGo6lMie/hSMryYrTF72dCMYYorxXWjeGDVGcVs0w+7QG3jkurvis0xlVbx1TrkF\n\tCAGgLiOtwzG274JxKygpQzZS8uVScctdjjgi8bnKltjxUJltjjQGuQiwDHi+YhIVbV2C\n\tkKa6D0QsgIQCwqh5fEW7ZIRpU7otCWYPj1j7npgR0pbbi8P1uKh0QA29Q/DX140joAe7\n\tE43540Rbe0JHCIMzBqw7XGJrPu5CA4WDf0soWpcXFOcN+8hgeY+3pyR+COncjxBL4LHr\n\t/gkw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=VuvwQc+xnjO1R8Rc2f7WGY1FuJD6++xIIZDUxkQmoJU=;\n\tb=zfjfGOw7+IjRVItE/CYwY3+L6wt2dEgAPsybi3kP+BOnDz4enLSXsZmo9az5S+BWW3\n\tKVOONq472p+HfYOembjX0gQ6QMbPtioezOG1pXoxiWlNNFr01rrio99QBfnbFPiwQLEI\n\tB90UN8t6nZO1UYOhbXzCZEWyzx8p2HGHje3g9IToeeO5lMM9YIHP7Pgz+7EHFeVh3eDo\n\t7UmdvLEP2qe/sVpP9R5sTcmtye5xWyHR9xy+Wo8kuOtFfVDG9qae2fvjIA40otOLCqv0\n\t+YNE3kS4c9b+U5/WfvfTzVy2AljnH1Ui31thEaFYXseb8nFkud8rYPslhH1xH/EqRxiX\n\tREgg==", "X-Gm-Message-State": "AOAM531ZbfKZQlaVcl7ib7CwwEkEVaGdLbclaNxflx1nJ+Y+Ui66+LYT\n\t8rI217bGjsBPAPOrm1L933oVZ0TkRZ0HbQ==", "X-Google-Smtp-Source": "ABdhPJxL07fo9VzpbjQC6RPdQjqV4oRTqKMdMeydVno0GTs63NogLs3yDAWum1kjJgbrRFNc9kA8sA==", "X-Received": "by 2002:a05:600c:601f:: with SMTP id\n\taz31mr1225908wmb.35.1643020270873; \n\tMon, 24 Jan 2022 02:31:10 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Jan 2022 10:31:07 +0000", "Message-Id": "<20220124103107.1799464-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220124103107.1799464-1-naush@raspberrypi.com>", "References": "<20220124103107.1799464-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 2/2] ipa: raspberrypi: config: Increase\n\tthe max gain in the exposure profiles", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Increase the maximum allowable gain from 6.0 to 8.0 in the normal and short\nexposure profiles for all camera sensors. Increase this limit to 12.0 for the\nlong exposure profiles for sensors where this has been defined.\n\nThe 6.0x value was somewhat arbitrarily chosen, and does limit the total\nexposure in dark conditions.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 6 +++---\n src/ipa/raspberrypi/data/imx219_noir.json | 6 +++---\n src/ipa/raspberrypi/data/imx290.json | 2 +-\n src/ipa/raspberrypi/data/imx378.json | 4 ++--\n src/ipa/raspberrypi/data/imx477.json | 6 +++---\n src/ipa/raspberrypi/data/imx477_noir.json | 6 +++---\n src/ipa/raspberrypi/data/imx519.json | 4 ++--\n src/ipa/raspberrypi/data/ov5647.json | 6 +++---\n src/ipa/raspberrypi/data/ov5647_noir.json | 6 +++---\n src/ipa/raspberrypi/data/ov9281.json | 2 +-\n src/ipa/raspberrypi/data/se327m12.json | 4 ++--\n 11 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex 1ec338be2ccb..de59d9363be4 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -137,7 +137,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -148,7 +148,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"long\":\n@@ -159,7 +159,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 12.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/raspberrypi/data/imx219_noir.json\nindex 1d48ef53d33b..9a3f03ec86f4 100644\n--- a/src/ipa/raspberrypi/data/imx219_noir.json\n+++ b/src/ipa/raspberrypi/data/imx219_noir.json\n@@ -69,7 +69,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -80,7 +80,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"long\":\n@@ -91,7 +91,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 12.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/raspberrypi/data/imx290.json\nindex 6fb92cc41593..20b45c1684c2 100644\n--- a/src/ipa/raspberrypi/data/imx290.json\n+++ b/src/ipa/raspberrypi/data/imx290.json\n@@ -79,7 +79,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/imx378.json b/src/ipa/raspberrypi/data/imx378.json\nindex 3c2164e2ec63..6620034513f0 100644\n--- a/src/ipa/raspberrypi/data/imx378.json\n+++ b/src/ipa/raspberrypi/data/imx378.json\n@@ -134,7 +134,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -145,7 +145,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex 9bee3f16e108..d07febd283ed 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -137,7 +137,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -148,7 +148,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"long\":\n@@ -159,7 +159,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 12.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/raspberrypi/data/imx477_noir.json\nindex 290e8264bba9..7d4fc7dab9fd 100644\n--- a/src/ipa/raspberrypi/data/imx477_noir.json\n+++ b/src/ipa/raspberrypi/data/imx477_noir.json\n@@ -69,7 +69,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -80,7 +80,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"long\":\n@@ -91,7 +91,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 12.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/imx519.json b/src/ipa/raspberrypi/data/imx519.json\nindex 164d0d9d1b79..2ce6a08c029d 100644\n--- a/src/ipa/raspberrypi/data/imx519.json\n+++ b/src/ipa/raspberrypi/data/imx519.json\n@@ -134,7 +134,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -145,7 +145,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\nindex 1a354f7cb036..24bc06fb6114 100644\n--- a/src/ipa/raspberrypi/data/ov5647.json\n+++ b/src/ipa/raspberrypi/data/ov5647.json\n@@ -137,7 +137,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -148,7 +148,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"long\":\n@@ -159,7 +159,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 12.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/raspberrypi/data/ov5647_noir.json\nindex c4bb21a0f34e..1c628ed13f19 100644\n--- a/src/ipa/raspberrypi/data/ov5647_noir.json\n+++ b/src/ipa/raspberrypi/data/ov5647_noir.json\n@@ -69,7 +69,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -80,7 +80,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"long\":\n@@ -91,7 +91,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 12.0\n ]\n }\n },\ndiff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281.json\nindex ecd262be12ad..2319448b1593 100644\n--- a/src/ipa/raspberrypi/data/ov9281.json\n+++ b/src/ipa/raspberrypi/data/ov9281.json\n@@ -32,7 +32,7 @@\n \"normal\":\n {\n \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n- \"gain\": [ 1.0, 2.0, 3.0, 4.0, 6.0 ]\n+ \"gain\": [ 1.0, 2.0, 3.0, 4.0, 8.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/raspberrypi/data/se327m12.json\nindex 3245ed98c1b1..94af2239f700 100644\n--- a/src/ipa/raspberrypi/data/se327m12.json\n+++ b/src/ipa/raspberrypi/data/se327m12.json\n@@ -134,7 +134,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n },\n \"short\":\n@@ -145,7 +145,7 @@\n ],\n \"gain\":\n [\n- 1.0, 2.0, 4.0, 6.0, 6.0\n+ 1.0, 2.0, 4.0, 6.0, 8.0\n ]\n }\n },\n", "prefixes": [ "libcamera-devel", "v1", "2/2" ] }