Patch Detail
Show a patch.
GET /api/patches/15168/?format=api
{ "id": 15168, "url": "https://patchwork.libcamera.org/api/patches/15168/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15168/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>", "date": "2021-12-19T23:27:12", "name": "[libcamera-devel,2/4] ipa: raspberrypi: cam_helper: Make exposure conversion functions virtual", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0e8385b608b3dcf0dfa09364b636b035fabc86cd", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15168/mbox/", "series": [ { "id": 2847, "url": "https://patchwork.libcamera.org/api/series/2847/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2847", "date": "2021-12-19T23:27:10", "name": "libcamera: Add support for the IMX296 sensor in the Raspberry Pi IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2847/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15168/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15168/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF380BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 19 Dec 2021 23:27:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94478608ED;\n\tMon, 20 Dec 2021 00:27:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC871605A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Dec 2021 00:27:21 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2198E10DD; \n\tMon, 20 Dec 2021 00:27:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fccFNGah\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639956441;\n\tbh=A4QhqVh6gjw1VyoZDlLNJ0o9h1Axn08jKOl0FGIL2CU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fccFNGah23la0RfmTytJfhQS8ojfTyO088V1nhGPm2tSluNACBa7G/Lbb/HbCiYQU\n\t1vj2rJWA/BWvEEhqNT39F2EGajGd5mduATLJ2NNsKI+4laF7yZ97Ickxuus/i/O1zk\n\tTLMKBlDFQVNsPuXaxuaAtI+pfFSpmsaidhaL3OXo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Dec 2021 01:27:12 +0200", "Message-Id": "<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>", "References": "<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper: Make\n\texposure conversion functions virtual", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nSome sensors (namely the Sony IMX296, whose support will be added\nshortly) require different conversion formulas between exposure time and\nexposure lines. Make the Exposure() and ExposureLines() functions\nvirtual to allow this.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex a776153fcb84..300f8f8a2d3b 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -76,8 +76,8 @@ public:\n \tvirtual void Prepare(libcamera::Span<const uint8_t> buffer,\n \t\t\t Metadata &metadata);\n \tvirtual void Process(StatisticsPtr &stats, Metadata &metadata);\n-\tuint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n-\tlibcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n+\tvirtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n+\tvirtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n \tvirtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n \t\t\t\t libcamera::utils::Duration minFrameDuration,\n \t\t\t\t libcamera::utils::Duration maxFrameDuration) const;\n", "prefixes": [ "libcamera-devel", "2/4" ] }