Patch Detail
Show a patch.
GET /api/patches/15119/?format=api
{ "id": 15119, "url": "https://patchwork.libcamera.org/api/patches/15119/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15119/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211210144424.14747-7-david.plowman@raspberrypi.com>", "date": "2021-12-10T14:44:22", "name": "[libcamera-devel,v12,6/8] libcamera: v4l2_subdevice: Support passing ColorSpaces to V4L2 subdevices", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "aff11e23f1020939a99b6c56748cb6a50e6203a0", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15119/mbox/", "series": [ { "id": 2835, "url": "https://patchwork.libcamera.org/api/series/2835/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2835", "date": "2021-12-10T14:44:16", "name": "Colour spaces", "version": 12, "mbox": "https://patchwork.libcamera.org/series/2835/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15119/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15119/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81CA4BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Dec 2021 14:44:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEAF0608A8;\n\tFri, 10 Dec 2021 15:44:47 +0100 (CET)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2873060898\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Dec 2021 15:44:41 +0100 (CET)", "by mail-wr1-x42b.google.com with SMTP id a18so15315688wrn.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Dec 2021 06:44:41 -0800 (PST)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tw22sm3000515wmi.27.2021.12.10.06.44.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 10 Dec 2021 06:44:40 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Osgcxd1h\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=HmfJ8ac2EKHf4bnrsfrn/IYvdkuy5nb+6QQ8a96WsCY=;\n\tb=Osgcxd1h16dTeVKrr8zRN/DxScdKaphCLdzwEtAqE+0KTboj7bcRsFIQWLw0UeB+/B\n\txusGN9AvTzVcGRbsESTMNIB9Pnb0zz+6YrXDoUb73qOAcUSixoTXVOnajp2imoq4WIfk\n\tOL6OBsd+wcnMihOZdBWBb+uCQEmIGeRV4BklwH4pmc+QsgTUb4+Aq/7vRvsynAJBfcpp\n\tLhR5jl1GDKwgvz72RgVx5PuyCSrrSRADZA4CSWewsDmC7BYb+8+9pwL45+sr6nnZBPim\n\tJAdgHpExIdL0Br+M+nEAGQBMjBSDLsAQfLsOLgAvA3uo4kVe7qkD8YRcKMMAz/zaDLHR\n\tjT7Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=HmfJ8ac2EKHf4bnrsfrn/IYvdkuy5nb+6QQ8a96WsCY=;\n\tb=bB+3047J9gr1rUyGRVKL1+9D3IXPFumGML+d/cUR6T4DYexCBjldgbO01v6iRGOUaU\n\tqlctREyqWgQlFcbZHJzF1Nr/QYYumLuWrFJPBP8Mlr1nONXyzfVh+IGS/ILlPWJ6QRO2\n\tP4g15yfav+4dSQTEBU/cw5iC6jTBWKL7RqcQQFCjAxPcPHiW16nizWaoBS/HI0wkCF/T\n\tRPRUE0MpxCjWmPGn9hrtQgxW2GYjys95zMct+PIMLJBEbAZ4D8ONXYXZYRfxq1R6bBpp\n\tU8LLZoMgPG1260rvtwgjeT0qDyQI1+ldnNlMqG0wwQuIdX2P55vC0xjNnaVXEqXh7DWw\n\tH37g==", "X-Gm-Message-State": "AOAM532bh75sj7TvsSLlCr/nuVD+NpXmwLnvqw2MqGoSfdHMvYIHfQGM\n\tCmaqQ64YJ1VF+0yHNBVQT5Wuxg==", "X-Google-Smtp-Source": "ABdhPJyYvQWZayRuF/r2Z8jK6SXmXncn+hOgKnVbSLBDX+p3lvSYoy8Dt0jvaz7px3VCyBqXgmJqvw==", "X-Received": "by 2002:adf:e747:: with SMTP id c7mr14604832wrn.38.1639147480894;\n\tFri, 10 Dec 2021 06:44:40 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>, Tomasz Figa <tfiga@google.com>, \n\tJacopo Mondi <jacopo@jmondi.org>,\n\tNaushir Patuck <naush@raspberrypi.com>, \n\tlibcamera-devel@lists.libcamera.org", "Date": "Fri, 10 Dec 2021 14:44:22 +0000", "Message-Id": "<20211210144424.14747-7-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211210144424.14747-1-david.plowman@raspberrypi.com>", "References": "<20211210144424.14747-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v12 6/8] libcamera: v4l2_subdevice:\n\tSupport passing ColorSpaces to V4L2 subdevices", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ColorSpace from the StreamConfiguration is now handled\nappropriately in the V4L2Subdevice.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_subdevice.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex b782325a..fa216e85 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -415,6 +415,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tformat->size.width = subdevFmt.format.width;\n \tformat->size.height = subdevFmt.format.height;\n \tformat->mbus_code = subdevFmt.format.code;\n+\tformat->colorSpace = toColorSpace(subdevFmt.format);\n \n \treturn 0;\n }\n@@ -442,6 +443,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tsubdevFmt.format.height = format->size.height;\n \tsubdevFmt.format.code = format->mbus_code;\n \tsubdevFmt.format.field = V4L2_FIELD_NONE;\n+\tfromColorSpace(format->colorSpace, subdevFmt.format);\n \n \tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n \tif (ret) {\n@@ -454,6 +456,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tformat->size.width = subdevFmt.format.width;\n \tformat->size.height = subdevFmt.format.height;\n \tformat->mbus_code = subdevFmt.format.code;\n+\tformat->colorSpace = toColorSpace(subdevFmt.format);\n \n \treturn 0;\n }\n", "prefixes": [ "libcamera-devel", "v12", "6/8" ] }