Patch Detail
Show a patch.
GET /api/patches/15085/?format=api
{ "id": 15085, "url": "https://patchwork.libcamera.org/api/patches/15085/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15085/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211209092906.37303-2-tomi.valkeinen@ideasonboard.com>", "date": "2021-12-09T09:29:02", "name": "[libcamera-devel,RFC,v3,1/5] HACK: Camera public destructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5fbccee71d7e2215585b0b31f23ed099a418fec2", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15085/mbox/", "series": [ { "id": 2829, "url": "https://patchwork.libcamera.org/api/series/2829/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2829", "date": "2021-12-09T09:29:01", "name": "Python bindings", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2829/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15085/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15085/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2949BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Dec 2021 09:29:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 683556087A;\n\tThu, 9 Dec 2021 10:29:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 583EF60224\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Dec 2021 10:29:43 +0100 (CET)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC8BE5B0;\n\tThu, 9 Dec 2021 10:29:42 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JTZ434ti\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639042183;\n\tbh=1u51IMESkICKFHOsJqttPhu0FTY3Cp+//IgKE+oJuXw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JTZ434tigNz9b5C/fuxvbBF5fCyBD4HUYK3AxPKrSPFPUQ1vvWJ/5eUFN6P/bTUlu\n\tqbVG4Ag0SWAE+HxVi4bmajGfidSl6lLMl2Uh9GPXEtufrobtR2LywOLf+ZRMAWd1lg\n\tDvpDqhFe9Dt5w6oMop5xp+QB/V7ng5s82yvUkCH8=", "From": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Dec 2021 11:29:02 +0200", "Message-Id": "<20211209092906.37303-2-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211209092906.37303-1-tomi.valkeinen@ideasonboard.com>", "References": "<20211209092906.37303-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC v3 1/5] HACK: Camera public destructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "pybind11 needs a public destructor for Camera to be able to manage the\nshared_ptr. It's not clear why this is needed, and can it be fixed in\npybind11.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n include/libcamera/camera.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex a7759ccb..88a61ff5 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -104,12 +104,12 @@ public:\n \tint start(const ControlList *controls = nullptr);\n \tint stop();\n \n+\t~Camera();\n private:\n \tLIBCAMERA_DISABLE_COPY(Camera)\n \n \tCamera(std::unique_ptr<Private> d, const std::string &id,\n \t const std::set<Stream *> &streams);\n-\t~Camera();\n \n \tfriend class PipelineHandler;\n \tvoid disconnect();\n", "prefixes": [ "libcamera-devel", "RFC", "v3", "1/5" ] }