Patch Detail
Show a patch.
GET /api/patches/14938/?format=api
{ "id": 14938, "url": "https://patchwork.libcamera.org/api/patches/14938/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14938/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211201070728.3114247-13-hiroh@chromium.org>", "date": "2021-12-01T07:07:28", "name": "[libcamera-devel,v4,12/12] android: camera_request: Add thread safety annotation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0a2c2dc8d25d9d2f64b91642eabbb5bcef3d8b47", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14938/mbox/", "series": [ { "id": 2789, "url": "https://patchwork.libcamera.org/api/series/2789/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2789", "date": "2021-12-01T07:07:16", "name": "Introduce clang thread safety annotations", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2789/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14938/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14938/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23331C324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Dec 2021 07:07:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAAEA6072C;\n\tWed, 1 Dec 2021 08:07:58 +0100 (CET)", "from mail-pg1-x531.google.com (mail-pg1-x531.google.com\n\t[IPv6:2607:f8b0:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 718DA60723\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Dec 2021 08:07:57 +0100 (CET)", "by mail-pg1-x531.google.com with SMTP id 137so15552801pgg.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 23:07:57 -0800 (PST)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:3892:a049:59ba:c772])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10sm16598962pgv.75.2021.11.30.23.07.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 23:07:55 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"k4TjDi2a\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uJYG3Nusw/zJT2sBNaxIou0h0BcaN6bUP3w8FXeB2XE=;\n\tb=k4TjDi2awPogPpjObRy0CFdaH1tBwYmb8XkxyPrBC8AtVVPG+9OeZ8e/i1UfE26G3J\n\tXSgv6QxgXLANF1Xwv9qzOmsZpj1Kz4dMv6gAD/ZgqdZEKUjmkw2kx+Rfnhsb4rjsh1Kp\n\t8xL16RUqNeS9cHcuNqjFyqhmZqBUXj7oH0Br4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uJYG3Nusw/zJT2sBNaxIou0h0BcaN6bUP3w8FXeB2XE=;\n\tb=WTxOOP/8W12HBjBUzsp3VuG+cxFIbQXrZzLAAvndrBBomykpX1Rl0os1EL4gFRgkIp\n\tn7fQt7sdxheM5jmnmWGzcFW13vshCuJPQ4KO9/wVhH0gDnMWN+Fc9di3TvhJ5IIrK6Wm\n\tpiddy5JlH3Z3xayK8nua2Uwjh/ClSCnXubU0u0TfJLBUX5dKGi/GloErUTkjxnPGknU/\n\tHIRA2uYVZuO2Er0ppgp5z4ptXlxgDv5XpBEJdDyqNtssd2xSK3PLuQ/0eI2iSVgjUl06\n\t52kGXCATQhSauJzUPyxHkI0ZUj1YLEAtUw8kZhBf3Dh3DA51Rcy+Qi2N8ro1dGz/Rh9q\n\tLM5Q==", "X-Gm-Message-State": "AOAM532zxviJqIToqx3B1xIPJdSqqoMXdfQKXWntUYGi6zyg2Ko6Fh/2\n\trvfd8mqa2IfnsdG2dWck0mNP5fgj65Mg+A==", "X-Google-Smtp-Source": "ABdhPJznpu563TVUSykSU23itZEgDzhM0DizlEdsGg40NurPZMzsKyCLkazq7YOg7qF3pzoxjXnujA==", "X-Received": "by 2002:a63:34c5:: with SMTP id\n\tb188mr3410918pga.64.1638342475764; \n\tTue, 30 Nov 2021 23:07:55 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 1 Dec 2021 16:07:28 +0900", "Message-Id": "<20211201070728.3114247-13-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211201070728.3114247-1-hiroh@chromium.org>", "References": "<20211201070728.3114247-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 12/12] android: camera_request: Add\n\tthread safety annotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This applies clang thread safety annotation to\nCamera3RequestDescriptor.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_request.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_request.h b/src/android/camera_request.h\nindex 887dbe86..d9b04f16 100644\n--- a/src/android/camera_request.h\n+++ b/src/android/camera_request.h\n@@ -57,7 +57,8 @@ public:\n \t};\n \n \t/* Keeps track of streams requiring post-processing. */\n-\tstd::map<CameraStream *, StreamBuffer *> pendingStreamsToProcess_;\n+\tstd::map<CameraStream *, StreamBuffer *> pendingStreamsToProcess_\n+\t\tLIBCAMERA_TSA_GUARDED_BY(streamsProcessMutex_);\n \tlibcamera::Mutex streamsProcessMutex_;\n \n \tCamera3RequestDescriptor(libcamera::Camera *camera,\n", "prefixes": [ "libcamera-devel", "v4", "12/12" ] }