Patch Detail
Show a patch.
GET /api/patches/14769/?format=api
{ "id": 14769, "url": "https://patchwork.libcamera.org/api/patches/14769/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14769/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211125054259.24792-9-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-25T05:42:56", "name": "[libcamera-devel,v5,08/11] ipa: rkisp1: Report and use sensor controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "69b57ea59fdd565af65e04657aa132fa0172886e", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14769/mbox/", "series": [ { "id": 2752, "url": "https://patchwork.libcamera.org/api/series/2752/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2752", "date": "2021-11-25T05:42:48", "name": "Introduce AGC for RkISP1", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2752/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14769/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14769/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93AC2C3251\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 05:43:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A487604F9;\n\tThu, 25 Nov 2021 06:43:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E8DC60376\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 06:43:05 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:d9a5:5e40:3323:d95])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 269E3A24;\n\tThu, 25 Nov 2021 06:43:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VjzKFp5F\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637818985;\n\tbh=RXF5gd3nL/zL5elGMr1rrP0VB1zm1MMGKOQYwt6bjxI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VjzKFp5Fvnb/8ld8hCI+sweUOVY6QglfcQ0Hv0ZcGapwbcIreBMXRwBHmLdMxyOfO\n\tn2xWeetiK7dk0cfKN4PSczX7wDCdpBHgfw72xR3TH5FfQnOG2spDkx4lwNT8g6mUhQ\n\tLFP5y1FfGxnmv7Wco3inMCTBfIWz5RiXS0xyoxsY=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 25 Nov 2021 06:42:56 +0100", "Message-Id": "<20211125054259.24792-9-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 08/11] ipa: rkisp1: Report and use\n\tsensor controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pipeline handler populates a new sensorControls ControlList, to\nhave the effective exposure and gain values for the current frame. This\nis done when a statistics buffer is received.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/ipa/rkisp1.mojom | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n 3 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex a6991d4f..c3a6d8e1 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -21,11 +21,13 @@ struct RkISP1Event {\n \tuint32 frame;\n \tuint32 bufferId;\n \tlibcamera.ControlList controls;\n+\tlibcamera.ControlList sensorControls;\n };\n \n struct RkISP1Action {\n \tRkISP1Operations op;\n \tlibcamera.ControlList controls;\n+\tlibcamera.ControlList sensorControls;\n };\n \n interface IPARkISP1Interface {\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 225f1847..2b073258 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -314,7 +314,7 @@ void IPARkISP1::setControls(unsigned int frame)\n \tControlList ctrls(ctrls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure_));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain_));\n-\top.controls = ctrls;\n+\top.sensorControls = ctrls;\n \n \tqueueFrameAction.emit(frame, op);\n }\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 6cdc4c03..36ef6a02 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -333,7 +333,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame,\n {\n \tswitch (action.op) {\n \tcase ipa::rkisp1::ActionV4L2Set: {\n-\t\tconst ControlList &controls = action.controls;\n+\t\tconst ControlList &controls = action.sensorControls;\n \t\tdelayedCtrls_->push(controls);\n \t\tbreak;\n \t}\n@@ -1124,6 +1124,7 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n \tev.op = ipa::rkisp1::EventSignalStatBuffer;\n \tev.frame = info->frame;\n \tev.bufferId = info->statBuffer->cookie();\n+\tev.sensorControls = data->delayedCtrls_->get(buffer->metadata().sequence);\n \tdata->ipa_->processEvent(ev);\n }\n \n", "prefixes": [ "libcamera-devel", "v5", "08/11" ] }