Patch Detail
Show a patch.
GET /api/patches/14765/?format=api
{ "id": 14765, "url": "https://patchwork.libcamera.org/api/patches/14765/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14765/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211125054259.24792-5-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-25T05:42:52", "name": "[libcamera-devel,v5,04/11] ipa: rkisp1: Instantiate CameraSensorHelper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "929ed545c00999bcf1c93642bf01d9d081a217d3", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14765/mbox/", "series": [ { "id": 2752, "url": "https://patchwork.libcamera.org/api/series/2752/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2752", "date": "2021-11-25T05:42:48", "name": "Introduce AGC for RkISP1", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2752/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14765/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14765/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1338EC324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 05:43:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9601A60398;\n\tThu, 25 Nov 2021 06:43:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A039360371\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 06:43:04 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:d9a5:5e40:3323:d95])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DC32A24;\n\tThu, 25 Nov 2021 06:43:04 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ETeXdCKD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637818984;\n\tbh=7EKJLxN6FyygVP3ODjD71RglMl4Afhijn0ZyokJr6KI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ETeXdCKD0rh57e3xu282wPxF6mL/9KihGkNUhz9tWhHjWjAe3o47Tff5SZ80cdDzk\n\tCWh0Ws2n4Qg6e5oEyFi7cb71ISCS8SWfr2bhOK2PB9F2eu6uycW60L7dDRa8bfBl+T\n\t6BoSruH5QHr/EuRLWncmQ5YIRQakVFzVjm7gOIAw=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 25 Nov 2021 06:42:52 +0100", "Message-Id": "<20211125054259.24792-5-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 04/11] ipa: rkisp1: Instantiate\n\tCameraSensorHelper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the AGC will run, it will use analogue gains as double values. We\nwill need those values to be converted to apply the control. Introduce\nCameraSensorHelper and call it at init().\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 910ad952..73a7f582 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -25,6 +25,8 @@\n \n #include <libcamera/internal/mapped_framebuffer.h>\n \n+#include \"libipa/camera_sensor_helper.h\"\n+\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPARkISP1)\n@@ -73,10 +75,12 @@ private:\n \tunsigned int hwHistBinNMax_;\n \tunsigned int hwGammaOutMaxSamples_;\n \tunsigned int hwHistogramWeightGridsSize_;\n+\n+\t/* Interface to the Camera Helper */\n+\tstd::unique_ptr<CameraSensorHelper> camHelper_;\n };\n \n-int IPARkISP1::init([[maybe_unused]] const IPASettings &settings,\n-\t\t unsigned int hwRevision)\n+int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision)\n {\n \t/* \\todo Add support for other revisions */\n \tswitch (hwRevision) {\n@@ -100,6 +104,15 @@ int IPARkISP1::init([[maybe_unused]] const IPASettings &settings,\n \t}\n \n \tLOG(IPARkISP1, Debug) << \"Hardware revision is \" << hwRevision;\n+\n+\tcamHelper_ = CameraSensorHelperFactory::create(settings.sensorModel);\n+\tif (!camHelper_) {\n+\t\tLOG(IPARkISP1, Error)\n+\t\t\t<< \"Failed to create camera sensor helper for \"\n+\t\t\t<< settings.sensorModel;\n+\t\treturn -ENODEV;\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v5", "04/11" ] }