Patch Detail
Show a patch.
GET /api/patches/14741/?format=api
{ "id": 14741, "url": "https://patchwork.libcamera.org/api/patches/14741/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14741/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123224015.3619282-13-kieran.bingham@ideasonboard.com>", "date": "2021-11-23T22:40:12", "name": "[libcamera-devel,12/15] qcam: Convert to pragma once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c05201dddf0826aa89bb0d23de94d1d011942a65", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14741/mbox/", "series": [ { "id": 2749, "url": "https://patchwork.libcamera.org/api/series/2749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2749", "date": "2021-11-23T22:40:00", "name": "Use pragma once", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14741/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14741/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF87CBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 22:40:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56FB56038A;\n\tTue, 23 Nov 2021 23:40:38 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 764B16042A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 23:40:23 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 243BAF95;\n\tTue, 23 Nov 2021 23:40:23 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mGoxogvE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637707223;\n\tbh=15g54kN9lxh84FsgjeP2E37dVZITLhUofjNkYenL8L8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mGoxogvEp4HV6MC5eQAlwmSu2oiEcgmtsecFNcOxYlRuBTwKkbVunNadQO6Vs2FTq\n\tfRbYXFrdZ0VUMhe+zB6ABrPH0Qv+q8l6ipxKYNtP+ZohhghLegI+e8JZwwfagpXrW0\n\tpXlLe7mRa2ld3Ik7taoHQynv6txS4sv6UY86P8rQ=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 23 Nov 2021 22:40:12 +0000", "Message-Id": "<20211123224015.3619282-13-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "References": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 12/15] qcam: Convert to pragma once", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/dng_writer.h | 6 ++----\n src/qcam/format_converter.h | 6 ++----\n src/qcam/main_window.h | 6 ++----\n src/qcam/message_handler.h | 6 ++----\n src/qcam/viewfinder.h | 6 ++----\n src/qcam/viewfinder_gl.h | 6 ++----\n src/qcam/viewfinder_qt.h | 6 ++----\n 7 files changed, 14 insertions(+), 28 deletions(-)", "diff": "diff --git a/src/qcam/dng_writer.h b/src/qcam/dng_writer.h\nindex e4486288e629..c044bf8b8162 100644\n--- a/src/qcam/dng_writer.h\n+++ b/src/qcam/dng_writer.h\n@@ -4,8 +4,8 @@\n *\n * dng_writer.h - DNG writer\n */\n-#ifndef __QCAM_DNG_WRITER_H__\n-#define __QCAM_DNG_WRITER_H__\n+\n+#pragma once\n \n #ifdef HAVE_TIFF\n #define HAVE_DNG\n@@ -25,5 +25,3 @@ public:\n };\n \n #endif /* HAVE_TIFF */\n-\n-#endif /* __QCAM_DNG_WRITER_H__ */\ndiff --git a/src/qcam/format_converter.h b/src/qcam/format_converter.h\nindex 9da2df5d294b..37dbfae2d344 100644\n--- a/src/qcam/format_converter.h\n+++ b/src/qcam/format_converter.h\n@@ -4,8 +4,8 @@\n *\n * format_convert.h - qcam - Convert buffer to RGB\n */\n-#ifndef __QCAM_FORMAT_CONVERTER_H__\n-#define __QCAM_FORMAT_CONVERTER_H__\n+\n+#pragma once\n \n #include <stddef.h>\n \n@@ -60,5 +60,3 @@ private:\n \tunsigned int y_pos_;\n \tunsigned int cb_pos_;\n };\n-\n-#endif /* __QCAM_FORMAT_CONVERTER_H__ */\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 4d8e806b2bf4..3fbe872c0b5b 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -4,8 +4,8 @@\n *\n * main_window.h - qcam - Main application window\n */\n-#ifndef __QCAM_MAIN_WINDOW_H__\n-#define __QCAM_MAIN_WINDOW_H__\n+\n+#pragma once\n \n #include <memory>\n #include <vector>\n@@ -126,5 +126,3 @@ private:\n \n \tstd::vector<std::unique_ptr<libcamera::Request>> requests_;\n };\n-\n-#endif /* __QCAM_MAIN_WINDOW__ */\ndiff --git a/src/qcam/message_handler.h b/src/qcam/message_handler.h\nindex 4534db9d93f7..56294d37ce2f 100644\n--- a/src/qcam/message_handler.h\n+++ b/src/qcam/message_handler.h\n@@ -4,8 +4,8 @@\n *\n * message_handler.cpp - qcam - Log message handling\n */\n-#ifndef __QCAM_MESSAGE_HANDLER_H__\n-#define __QCAM_MESSAGE_HANDLER_H__\n+\n+#pragma once\n \n #include <QtGlobal>\n \n@@ -22,5 +22,3 @@ private:\n \tstatic QtMessageHandler handler_;\n \tstatic bool verbose_;\n };\n-\n-#endif /* __QCAM_MESSAGE_HANDLER_H__ */\ndiff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\nindex 4c2102a6ed04..260074aed440 100644\n--- a/src/qcam/viewfinder.h\n+++ b/src/qcam/viewfinder.h\n@@ -4,8 +4,8 @@\n *\n * viewfinder.h - qcam - Viewfinder base class\n */\n-#ifndef __QCAM_VIEWFINDER_H__\n-#define __QCAM_VIEWFINDER_H__\n+\n+#pragma once\n \n #include <QImage>\n #include <QList>\n@@ -30,5 +30,3 @@ public:\n \n \tvirtual QImage getCurrentImage() = 0;\n };\n-\n-#endif /* __QCAM_VIEWFINDER_H__ */\ndiff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\nindex 37b1ddd04b1d..0a9275baf9b9 100644\n--- a/src/qcam/viewfinder_gl.h\n+++ b/src/qcam/viewfinder_gl.h\n@@ -5,8 +5,8 @@\n * viewfinder_GL.h - OpenGL Viewfinder for rendering by OpenGL shader\n *\n */\n-#ifndef __VIEWFINDER_GL_H__\n-#define __VIEWFINDER_GL_H__\n+\n+#pragma once\n \n #include <array>\n #include <memory>\n@@ -103,5 +103,3 @@ private:\n \n \tQMutex mutex_; /* Prevent concurrent access to image_ */\n };\n-\n-#endif /* __VIEWFINDER_GL_H__ */\ndiff --git a/src/qcam/viewfinder_qt.h b/src/qcam/viewfinder_qt.h\nindex 756f3fa33055..8c62145211d1 100644\n--- a/src/qcam/viewfinder_qt.h\n+++ b/src/qcam/viewfinder_qt.h\n@@ -4,8 +4,8 @@\n *\n * viewfinder_qt.h - qcam - QPainter-based ViewFinder\n */\n-#ifndef __QCAM_VIEWFINDER_QT_H__\n-#define __QCAM_VIEWFINDER_QT_H__\n+\n+#pragma once\n \n #include <QIcon>\n #include <QImage>\n@@ -61,5 +61,3 @@ private:\n \tQImage image_;\n \tQMutex mutex_; /* Prevent concurrent access to image_ */\n };\n-\n-#endif /* __QCAM_VIEWFINDER_QT_H__ */\n", "prefixes": [ "libcamera-devel", "12/15" ] }