Patch Detail
Show a patch.
GET /api/patches/14739/?format=api
{ "id": 14739, "url": "https://patchwork.libcamera.org/api/patches/14739/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14739/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123224015.3619282-9-kieran.bingham@ideasonboard.com>", "date": "2021-11-23T22:40:08", "name": "[libcamera-devel,08/15] gstreamer: Convert to pragma once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0c52bbe545836d4685c94481d978115b41db01a6", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14739/mbox/", "series": [ { "id": 2749, "url": "https://patchwork.libcamera.org/api/series/2749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2749", "date": "2021-11-23T22:40:00", "name": "Use pragma once", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14739/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14739/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55C3EBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 22:40:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E53760490;\n\tTue, 23 Nov 2021 23:40:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70825603C4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 23:40:22 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24BD1F95;\n\tTue, 23 Nov 2021 23:40:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"soNRU1FH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637707222;\n\tbh=bKExQQelqOacY2dtx5kgKCHOjiTJN0hvCEns6b2dnPc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=soNRU1FHlsQ045gqkHAhnJsWXTB5bIMuDwWAKI6UhZg4wL2GzOZKVDVg64HribRHu\n\t72KpqPjbZ5ixfT12d/a9KHa1MgH5Z4TzGjgWnis1ibrBB/6LsDYzkWugUyCYQ2FaOD\n\tM6///4GwuABv/518coCfSCqcaov5EOmbsag0rnsw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 23 Nov 2021 22:40:08 +0000", "Message-Id": "<20211123224015.3619282-9-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "References": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 08/15] gstreamer: Convert to pragma once", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/gstreamer/gstlibcamera-utils.h | 5 +----\n src/gstreamer/gstlibcameraallocator.h | 5 +----\n src/gstreamer/gstlibcamerapad.h | 5 +----\n src/gstreamer/gstlibcamerapool.h | 6 +-----\n src/gstreamer/gstlibcameraprovider.h | 6 +-----\n src/gstreamer/gstlibcamerasrc.h | 5 +----\n 6 files changed, 6 insertions(+), 26 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 7087fef0a94d..d54f15885d0c 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -6,8 +6,7 @@\n * gstlibcamera-utils.h - GStreamer libcamera Utility Functions\n */\n \n-#ifndef __GST_LIBCAMERA_UTILS_H__\n-#define __GST_LIBCAMERA_UTILS_H__\n+#pragma once\n \n #include <libcamera/camera_manager.h>\n #include <libcamera/stream.h>\n@@ -71,5 +70,3 @@ public:\n private:\n \tGRecMutex *mutex_;\n };\n-\n-#endif /* __GST_LIBCAMERA_UTILS_H__ */\ndiff --git a/src/gstreamer/gstlibcameraallocator.h b/src/gstreamer/gstlibcameraallocator.h\nindex 0dbd00d00a20..0a08c3bb3bbe 100644\n--- a/src/gstreamer/gstlibcameraallocator.h\n+++ b/src/gstreamer/gstlibcameraallocator.h\n@@ -6,8 +6,7 @@\n * gstlibcameraallocator.h - GStreamer Custom Allocator\n */\n \n-#ifndef __GST_LIBCAMERA_ALLOCATOR_H__\n-#define __GST_LIBCAMERA_ALLOCATOR_H__\n+#pragma once\n \n #include <gst/gst.h>\n #include <gst/allocators/allocators.h>\n@@ -30,5 +29,3 @@ gsize gst_libcamera_allocator_get_pool_size(GstLibcameraAllocator *allocator,\n \t\t\t\t\t libcamera::Stream *stream);\n \n libcamera::FrameBuffer *gst_libcamera_memory_get_frame_buffer(GstMemory *mem);\n-\n-#endif /* __GST_LIBCAMERA_ALLOCATOR_H__ */\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 779f2d13887a..207695173313 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -6,8 +6,7 @@\n * gstlibcamerapad.h - GStreamer Capture Element\n */\n \n-#ifndef __GST_LIBCAMERA_PAD_H__\n-#define __GST_LIBCAMERA_PAD_H__\n+#pragma once\n \n #include \"gstlibcamerapool.h\"\n \n@@ -33,5 +32,3 @@ GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\n bool gst_libcamera_pad_has_pending(GstPad *pad);\n \n void gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency);\n-\n-#endif /* __GST_LIBCAMERA_PAD_H__ */\ndiff --git a/src/gstreamer/gstlibcamerapool.h b/src/gstreamer/gstlibcamerapool.h\nindex a3f1b685e22e..05795d21223e 100644\n--- a/src/gstreamer/gstlibcamerapool.h\n+++ b/src/gstreamer/gstlibcamerapool.h\n@@ -9,8 +9,7 @@\n * only. This pool cannot be configured or activated.\n */\n \n-#ifndef __GST_LIBCAMERA_POOL_H__\n-#define __GST_LIBCAMERA_POOL_H__\n+#pragma once\n \n #include \"gstlibcameraallocator.h\"\n \n@@ -29,6 +28,3 @@ libcamera::Stream *gst_libcamera_pool_get_stream(GstLibcameraPool *self);\n libcamera::Stream *gst_libcamera_buffer_get_stream(GstBuffer *buffer);\n \n libcamera::FrameBuffer *gst_libcamera_buffer_get_frame_buffer(GstBuffer *buffer);\n-\n-\n-#endif /* __GST_LIBCAMERA_POOL_H__ */\ndiff --git a/src/gstreamer/gstlibcameraprovider.h b/src/gstreamer/gstlibcameraprovider.h\nindex bdd19db80df1..aaceabf5eff2 100644\n--- a/src/gstreamer/gstlibcameraprovider.h\n+++ b/src/gstreamer/gstlibcameraprovider.h\n@@ -6,8 +6,7 @@\n * gstlibcameraprovider.h - GStreamer Device Provider\n */\n \n-#ifndef __GST_LIBCAMERA_PROVIDER_H__\n-#define __GST_LIBCAMERA_PROVIDER_H__\n+#pragma once\n \n #include <gst/gst.h>\n \n@@ -18,6 +17,3 @@ G_DECLARE_FINAL_TYPE(GstLibcameraProvider, gst_libcamera_provider,\n \t\t GST_LIBCAMERA, PROVIDER, GstDeviceProvider)\n \n G_END_DECLS\n-\n-#endif /* __GST_LIBCAMERA_PROVIDER_H__ */\n-\ndiff --git a/src/gstreamer/gstlibcamerasrc.h b/src/gstreamer/gstlibcamerasrc.h\nindex 0144cbc42fa6..fdea2f10d95d 100644\n--- a/src/gstreamer/gstlibcamerasrc.h\n+++ b/src/gstreamer/gstlibcamerasrc.h\n@@ -6,8 +6,7 @@\n * gstlibcamerasrc.h - GStreamer Capture Element\n */\n \n-#ifndef __GST_LIBCAMERA_SRC_H__\n-#define __GST_LIBCAMERA_SRC_H__\n+#pragma once\n \n #include <gst/gst.h>\n \n@@ -18,5 +17,3 @@ G_DECLARE_FINAL_TYPE(GstLibcameraSrc, gst_libcamera_src,\n \t\t GST_LIBCAMERA, SRC, GstElement)\n \n G_END_DECLS\n-\n-#endif /* __GST_LIBCAMERA_SRC_H__ */\n", "prefixes": [ "libcamera-devel", "08/15" ] }