Patch Detail
Show a patch.
GET /api/patches/14721/?format=api
{ "id": 14721, "url": "https://patchwork.libcamera.org/api/patches/14721/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14721/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123150423.125524-8-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-23T15:04:19", "name": "[libcamera-devel,v3,07/11] ipa: rkisp1: Use the Algorithm class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "66145c621368fd10d3b900782c90fef00d6e4263", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14721/mbox/", "series": [ { "id": 2746, "url": "https://patchwork.libcamera.org/api/series/2746/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2746", "date": "2021-11-23T15:04:12", "name": "Introduce AGC for RkISP1", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2746/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14721/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14721/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0648C3251\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 15:04:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 943FD6049F;\n\tTue, 23 Nov 2021 16:04:41 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CC086038C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 16:04:29 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF2E6993;\n\tTue, 23 Nov 2021 16:04:28 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XdBoafpJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637679868;\n\tbh=2X7RSKsz1xR1D3Tn2++8a9J/eRWrsR8gH+DyF2WRmn0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XdBoafpJRHrukoPrvecwTeLA/9dKQ9d8tCYSOqFRrJ8QomCOpXx5wYb50wJ3kLGf2\n\tPtUyZpW/ciTGi7/XiY8gLZQunW7JguUmUt4jlNt0VrI0FSPEmx/jcx8PbxRHuQa1oD\n\tHCJopFGPxvD7sUEuIbsNiiaxjnf5RRDz4MVEzU/Y=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Nov 2021 16:04:19 +0100", "Message-Id": "<20211123150423.125524-8-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 07/11] ipa: rkisp1: Use the Algorithm\n\tclass", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that libipa offers a templated class for Algorithm, use it in\nRkISP1.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/algorithm.h | 28 +++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/meson.build | 4 ++++\n src/ipa/rkisp1/meson.build | 4 ++++\n src/ipa/rkisp1/rkisp1.cpp | 5 ++++-\n 4 files changed, 40 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/rkisp1/algorithms/algorithm.h\n create mode 100644 src/ipa/rkisp1/algorithms/meson.build", "diff": "diff --git a/src/ipa/rkisp1/algorithms/algorithm.h b/src/ipa/rkisp1/algorithms/algorithm.h\nnew file mode 100644\nindex 00000000..dfa58727\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/algorithm.h\n@@ -0,0 +1,28 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * algorithm.h - RkISP1 control algorithm interface\n+ */\n+#ifndef __LIBCAMERA_IPA_RKISP1_ALGORITHM_H__\n+#define __LIBCAMERA_IPA_RKISP1_ALGORITHM_H__\n+\n+#include <linux/rkisp1-config.h>\n+\n+#include <libcamera/ipa/rkisp1_ipa_interface.h>\n+\n+#include <libipa/algorithm.h>\n+\n+#include \"ipa_context.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1 {\n+\n+using Algorithm = libcamera::ipa::Algorithm<IPAContext, IPACameraSensorInfo, rkisp1_params_cfg, rkisp1_stat_buffer>;\n+\n+} /* namespace ipa::rkisp1 */\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_IPA_RKISP1_ALGORITHM_H__ */\ndiff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\nnew file mode 100644\nindex 00000000..1c6c59cf\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+rkisp1_ipa_algorithms = files([\n+])\ndiff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\nindex 3683c922..8c822fbb 100644\n--- a/src/ipa/rkisp1/meson.build\n+++ b/src/ipa/rkisp1/meson.build\n@@ -1,5 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+subdir('algorithms')\n+\n ipa_name = 'ipa_rkisp1'\n \n rkisp1_ipa_sources = files([\n@@ -7,6 +9,8 @@ rkisp1_ipa_sources = files([\n 'rkisp1.cpp',\n ])\n \n+rkisp1_ipa_sources += rkisp1_ipa_algorithms\n+\n mod = shared_module(ipa_name,\n [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n name_prefix : '',\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 34c3f9a2..0c54d8ec 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -25,7 +25,7 @@\n \n #include <libcamera/internal/mapped_framebuffer.h>\n \n-#include \"ipa_context.h\"\n+#include \"algorithms/algorithm.h\"\n #include \"libipa/camera_sensor_helper.h\"\n \n namespace libcamera {\n@@ -82,6 +82,9 @@ private:\n \n \t/* Local parameter storage */\n \tstruct IPAContext context_;\n+\n+\t/* Maintain the algorithms used by the IPA */\n+\tstd::list<std::unique_ptr<ipa::rkisp1::Algorithm>> algorithms_;\n };\n \n int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision)\n", "prefixes": [ "libcamera-devel", "v3", "07/11" ] }