Patch Detail
Show a patch.
GET /api/patches/14648/?format=api
{ "id": 14648, "url": "https://patchwork.libcamera.org/api/patches/14648/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14648/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211119110955.3137585-3-naush@raspberrypi.com>", "date": "2021-11-19T11:09:55", "name": "[libcamera-devel,3/3] pipeline: raspberrypi: Remove unused member variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e96b7cc1d2a443570d0e01c4efd3aa138c57fb92", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14648/mbox/", "series": [ { "id": 2734, "url": "https://patchwork.libcamera.org/api/series/2734/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2734", "date": "2021-11-19T11:09:53", "name": "[libcamera-devel,1/3] pipeline: raspberrypi: Split out device enumeration and camera registration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2734/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14648/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14648/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21B44BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Nov 2021 11:10:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D333160376;\n\tFri, 19 Nov 2021 12:10:17 +0100 (CET)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ED87600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Nov 2021 12:10:14 +0100 (CET)", "by mail-wr1-x42f.google.com with SMTP id d24so17568006wra.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Nov 2021 03:10:14 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:bad1:6339:b276:e376])\n\tby smtp.gmail.com with ESMTPSA id\n\to5sm2596486wrx.83.2021.11.19.03.10.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 19 Nov 2021 03:10:12 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"X942DvJl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PN3DCfgGpvrincKp8qjYTXfagYjL3rVJtucQdzIRi1U=;\n\tb=X942DvJlmftO0+BCC7SJUjRahIFuK6jyUcWSjnRXaY3ucmk2xyWm7ysdJl+DpRjQff\n\tIlB1z99sWD2fNHJGitTvqt4eH7+GZFP8B6Dk8YP7NiV7qRHO/CilnbDXQdAWP4ebtDx9\n\tAzGak6ggBcuoEnJq5jEhK+qIxZ6cOKqXL5RCXqukyJ3pjBMnpbZo2lxnSz4EAEaIL+K7\n\t6JfW9XMs8X2Imnb31WDsc7sqCeh6Fw7y3U39/N7Yv0kps/hM13RM4PLTnDpV1y5m364V\n\tYxvChf6OMyDGoNIXJfnVVZGk5WUl3TFaKFvSY/MDvv29TGLcV+MS6PnGap1vHefeaNnf\n\tXVxw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PN3DCfgGpvrincKp8qjYTXfagYjL3rVJtucQdzIRi1U=;\n\tb=cJS8glmHzvn2K4pqeiuKxTBILQ4ugT0J27IwML/lld9uivEzkNW6vlFa7/N6+jq7wq\n\t1XUvJOV/RKu53B6qdm+hGfYWsAdJEiJuYSNqmQb/wvtoknUQ+irVSrvl7iOEzHCqNX8M\n\tBDSEyEF5OE1VLElx/Zt0YdBwbCmB6n1MZHmqkWAeJxcug1gUL6BtXW6Sz7YCCJst+3KZ\n\tIfC5eIky5gu24e7yS7DuCjIIBoFG79VAGFv06vLAT080s50lZu5aq3vgk9QXxRhbMsEY\n\tfg46ayNbttAfVdnoE48UPjgJ1iHf4xIE0c9L5nSCOfYsQ9yPCRxrHIdoRmJ4fZ5/7wOS\n\tN7Bw==", "X-Gm-Message-State": "AOAM531wxpzfCuj0jlJV+qJ3fw9iGLT2DZuLGBiBTAZ93uym1APiC+0d\n\tR34+1lguGV132Aq701qslcXzOCV09NYL0GhG", "X-Google-Smtp-Source": "ABdhPJz7374IU0qdLxX3eMjLX8ZNur4J/wmS/WLDtcEkubEc+mF4VBYY02CIWedeQetJRa4risjZoQ==", "X-Received": "by 2002:adf:fe8e:: with SMTP id\n\tl14mr6277665wrr.177.1637320213501; \n\tFri, 19 Nov 2021 03:10:13 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Nov 2021 11:09:55 +0000", "Message-Id": "<20211119110955.3137585-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211119110955.3137585-1-naush@raspberrypi.com>", "References": "<20211119110955.3137585-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Remove unused\n\tmember variables", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove unused member variables from class PipelineHandlerRPi.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 8ed2ebcaafe7..d47306bdfec9 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -317,9 +317,6 @@ private:\n \tint prepareBuffers(Camera *camera);\n \tvoid freeBuffers(Camera *camera);\n \tvoid mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask);\n-\n-\tMediaDevice *unicam_;\n-\tMediaDevice *isp_;\n };\n \n RPiCameraConfiguration::RPiCameraConfiguration(const RPiCameraData *data)\n@@ -510,7 +507,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n }\n \n PipelineHandlerRPi::PipelineHandlerRPi(CameraManager *manager)\n-\t: PipelineHandler(manager), unicam_(nullptr), isp_(nullptr)\n+\t: PipelineHandler(manager)\n {\n }\n \n", "prefixes": [ "libcamera-devel", "3/3" ] }