Patch Detail
Show a patch.
GET /api/patches/14646/?format=api
{ "id": 14646, "url": "https://patchwork.libcamera.org/api/patches/14646/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14646/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211119110955.3137585-1-naush@raspberrypi.com>", "date": "2021-11-19T11:09:53", "name": "[libcamera-devel,1/3] pipeline: raspberrypi: Split out device enumeration and camera registration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "837f98f878e6a3be36eafb6ba4a14f9cd17e2b38", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14646/mbox/", "series": [ { "id": 2734, "url": "https://patchwork.libcamera.org/api/series/2734/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2734", "date": "2021-11-19T11:09:53", "name": "[libcamera-devel,1/3] pipeline: raspberrypi: Split out device enumeration and camera registration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2734/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14646/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14646/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14326BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Nov 2021 11:10:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E4776037A;\n\tFri, 19 Nov 2021 12:10:14 +0100 (CET)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43409600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Nov 2021 12:10:11 +0100 (CET)", "by mail-wr1-x42e.google.com with SMTP id n29so17455732wra.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Nov 2021 03:10:11 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:bad1:6339:b276:e376])\n\tby smtp.gmail.com with ESMTPSA id\n\to5sm2596486wrx.83.2021.11.19.03.10.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 19 Nov 2021 03:10:07 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dNECUEKT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=JSnUEG9AqNj3Cw1dNOiZSq5GWEtcZ8uIXXmDrXNrGwI=;\n\tb=dNECUEKTVl1hRzO2XCey2NORUcvQJEobPK/Y2R5WisgfhyVTSmeti+J0Z9Asf+mi0p\n\tvNbWNd6Z3OTwTPTfgf/i+qxct/pQrUTPFEsnAMeeYxuP5bg0ryI0YSTVzeMyzUdqJSGb\n\tC1R2gQykmyu/HImeTbq//Dcg2ebejPyZiQgcqP7SKjitM1la2K08mJeW6WfIG4lFFBpr\n\tSeSJDg75R2QhjVAlzbmPH1DdXhKzoHHs3vKsRMb5dL0/8RDv/DWEC47oNMKED1T3RzUT\n\tL8sps+LqaV4bKQ06jTxKAWiEVuk00lETJmdrt+UDmLkhmLW4w2A+sPtKXPA+4AbxpCWf\n\t+Vxg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=JSnUEG9AqNj3Cw1dNOiZSq5GWEtcZ8uIXXmDrXNrGwI=;\n\tb=g4xESAa4Hq6LYyZVOpJtbEqkH+oEVVg8GdnbUPAk8ULHwI1/y/CcnZ0wXdJyu/03be\n\tnvhWQ0q9R1IFPvc2c0lvnhmlEUhQW7Uyk3EyAhuKz2Srd9NzY448lmt99s/ZoaPpyjJj\n\tmihrNDqGCglh5vDj4vNuqj2h22o9VmvNJk2q0IMKPl5cYovFASpYr9Erh5DTwG4Xh3WO\n\tBhXIXSVozOmKtQbKzdn/J88kRF2UxKxweR0kRYmnvfYAE/ilzWrknyktuO3TqTKjeTFP\n\tXK4dE16wPNzsfma67ad6CkHoGU0QGJBGujKZiuoCpadLDrjzWuMLPrN3eB6Ae2TSdd5f\n\tpQNA==", "X-Gm-Message-State": "AOAM532x8lczhJe0LFFI1Y2cWmxmI5ElkXjN6Vm9a1oIvGwFAgm+QBDZ\n\tLSap5EN5xrmY7443DEQzX0xxcBjVpluYIaWw", "X-Google-Smtp-Source": "ABdhPJyxZgIkDFLa8CO6oPm4/Q5JXCbwVdXF88nbkHSEOWJmADbbiUThyUKrXlgLymzTJSbMkZYsBA==", "X-Received": "by 2002:a05:6000:52:: with SMTP id\n\tk18mr6147120wrx.192.1637320210405; \n\tFri, 19 Nov 2021 03:10:10 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Nov 2021 11:09:53 +0000", "Message-Id": "<20211119110955.3137585-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Split out\n\tdevice enumeration and camera registration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Split out PipelineHandlerRPi::match() so that media device enumeration and\nacquisition is separated from camera registration. The former logic remains\nin PipelineHandlerRPi::match(), whereas the latter logic is moved into a new\nPipelineHandlerRPi::registerCameras() member function.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 4f6c699a4379..9aa7e9eef5e7 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -311,6 +311,7 @@ private:\n \t\treturn static_cast<RPiCameraData *>(camera->_d());\n \t}\n \n+\tbool registerCameras();\n \tint queueAllBuffers(Camera *camera);\n \tint prepareBuffers(Camera *camera);\n \tvoid freeBuffers(Camera *camera);\n@@ -1010,6 +1011,11 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \tif (!isp_)\n \t\treturn false;\n \n+\treturn registerCameras();\n+}\n+\n+bool PipelineHandlerRPi::registerCameras()\n+{\n \tstd::unique_ptr<RPiCameraData> data = std::make_unique<RPiCameraData>(this);\n \tif (!data->dmaHeap_.isValid())\n \t\treturn false;\n", "prefixes": [ "libcamera-devel", "1/3" ] }