Patch Detail
Show a patch.
GET /api/patches/14638/?format=api
{ "id": 14638, "url": "https://patchwork.libcamera.org/api/patches/14638/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14638/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211118180707.348256-1-umang.jain@ideasonboard.com>", "date": "2021-11-18T18:07:07", "name": "[libcamera-devel] libcamera: media_device: Documentation fix", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "8406412337ea2f368edca9cd478849e9995fa797", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14638/mbox/", "series": [ { "id": 2728, "url": "https://patchwork.libcamera.org/api/series/2728/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2728", "date": "2021-11-18T18:07:07", "name": "[libcamera-devel] libcamera: media_device: Documentation fix", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2728/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14638/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14638/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AEDDBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Nov 2021 18:07:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89C2460371;\n\tThu, 18 Nov 2021 19:07:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEB5C60231\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Nov 2021 19:07:15 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.87])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63BD6E7;\n\tThu, 18 Nov 2021 19:07:14 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bka0oQ2O\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637258835;\n\tbh=CjLrPkIqlEGwgyyDpbADYN3GtW86+LAZfYfoSOu6L5w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Bka0oQ2OMjni4UCF87KFHeSA52NeGgkrJodQH4rcjwadklME6q+ifzEI8HFvpWyXM\n\tC9DcWtD6l3lxjXzkJCdW+m5OdRX/zQdzukUS9NEr4eZLUCA3pv4pWwCNlq85OOoWc5\n\tzJAevViE2kznFMnnxQFpCip8umQl4xoECvX3ofFk=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Nov 2021 23:37:07 +0530", "Message-Id": "<20211118180707.348256-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: media_device: Documentation fix", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix a couple of sentence formations to clarify the intent.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/media_device.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex aa93da75..dd5def20 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -40,15 +40,15 @@ LOG_DEFINE_CATEGORY(MediaDevice)\n * instance.\n *\n * The instance is created with an empty media graph. Before performing any\n- * other operation, it must be populate by calling populate(). Instances of\n+ * other operation, it must be populated by calling populate(). Instances of\n * MediaEntity, MediaPad and MediaLink are created to model the media graph,\n * and stored in a map indexed by object id.\n *\n- * The graph is valid once successfully populated, as reported by the isValid()\n- * function. It can be queried to list all entities(), or entities can be\n- * looked up by name with getEntityByName(). The graph can be traversed from\n- * entity to entity through pads and links as exposed by the corresponding\n- * classes.\n+ * The graph is valid once it has been successfully populated, and is reported\n+ * as valid by the isValid() function. It can be queried to list all entities\n+ * with entities(), or entities can be looked up by name with getEntityByName()\n+ * function. The graph can be traversed from entity to entity through pads and\n+ * links as exposed by the corresponding classes.\n *\n * Media devices can be claimed for exclusive use with acquire(), released with\n * release() and tested with busy(). This mechanism is aimed at pipeline\n", "prefixes": [ "libcamera-devel" ] }