Patch Detail
Show a patch.
GET /api/patches/14623/?format=api
{ "id": 14623, "url": "https://patchwork.libcamera.org/api/patches/14623/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14623/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211118095240.358827-1-paul.elder@ideasonboard.com>", "date": "2021-11-18T09:52:40", "name": "[libcamera-devel] android: capabilities: Add exposure time keys only if available", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "82561cdb8f93b8b5604580c662c897477d0dae09", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14623/mbox/", "series": [ { "id": 2724, "url": "https://patchwork.libcamera.org/api/series/2724/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2724", "date": "2021-11-18T09:52:40", "name": "[libcamera-devel] android: capabilities: Add exposure time keys only if available", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2724/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14623/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14623/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 029B4BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Nov 2021 09:52:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 175846033C;\n\tThu, 18 Nov 2021 10:52:55 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54DEB60230\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Nov 2021 10:52:53 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5D953E5;\n\tThu, 18 Nov 2021 10:52:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EFWWq5oM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637229173;\n\tbh=CJc0GAlFgW/fps2dg901cwlW6F50DebVski+zDK5uyc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=EFWWq5oMJhfW7gT6VYbdQLkKJbfWWZwKMMHkAyEFyfVlrC8FcyJXIEaPFtGI7Lxsb\n\tPa5sBHhaZ/hsoCG22qpZdUGYQ/wdlCViNgRXfd/RXHKfeINa+CsuvcqYbokdq2OYtI\n\t98AJVMJ/w4Zuap6X3YwEw3lQjTm/9cofmIxmEjgo=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Nov 2021 18:52:40 +0900", "Message-Id": "<20211118095240.358827-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: capabilities: Add exposure time\n\tkeys only if available", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The exposure time range static metadata key and the exposure time\nrequest and result keys are not required for non-FULL hardware levels.\nSince we already have checks for them in the capability detector, only\nadd them if the libcamera camera supports it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 6e46f163..105d5b4f 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -812,7 +812,6 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n \t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n \t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n-\t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n \t\tANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n \t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n \t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n@@ -890,7 +889,6 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\tANDROID_NOISE_REDUCTION_MODE,\n \t\tANDROID_REQUEST_PIPELINE_DEPTH,\n \t\tANDROID_SCALER_CROP_REGION,\n-\t\tANDROID_SENSOR_EXPOSURE_TIME,\n \t\tANDROID_SENSOR_FRAME_DURATION,\n \t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n \t\tANDROID_SENSOR_TEST_PATTERN_MODE,\n@@ -1106,6 +1104,10 @@ int CameraCapabilities::initializeStaticMetadata()\n \n \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n \t\t\t\t\t exposureTimeRange, 2);\n+\n+\t\tavailableCharacteristicsKeys_.insert(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE);\n+\t\tavailableRequestKeys_.insert(ANDROID_SENSOR_EXPOSURE_TIME);\n+\t\tavailableResultKeys_.insert(ANDROID_SENSOR_EXPOSURE_TIME);\n \t}\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, orientation_);\n", "prefixes": [ "libcamera-devel" ] }