Patch Detail
Show a patch.
GET /api/patches/14617/?format=api
{ "id": 14617, "url": "https://patchwork.libcamera.org/api/patches/14617/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14617/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211116162615.27777-2-laurent.pinchart@ideasonboard.com>", "date": "2021-11-16T16:26:11", "name": "[libcamera-devel,1/5] ipa: ipu3: agc: Drop kMaxLuminance constant", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3d9c74afe56d72e1723bb5c373bede054e5cdaf1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14617/mbox/", "series": [ { "id": 2722, "url": "https://patchwork.libcamera.org/api/series/2722/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2722", "date": "2021-11-16T16:26:10", "name": "ipa: ipu3: agc: Misc improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2722/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14617/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14617/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BB51BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Nov 2021 16:26:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6676E6037A;\n\tTue, 16 Nov 2021 17:26:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1F796032C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Nov 2021 17:26:42 +0100 (CET)", "from localhost.localdomain (117.145-247-81.adsl-dyn.isp.belgacom.be\n\t[81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B7A69CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Nov 2021 17:26:42 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DnNFoUc1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637080002;\n\tbh=JshyZB4bxYhmsY5/BvtNc33N4gSN80H5eB26x845pxc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=DnNFoUc1dv+9TU5hpjlgY3bAXom3k2CpA5bpEOEJYBHY0YOqvNgkxbuEWFgZQjuqP\n\tfaHrNkYIBFkw5TLvLtxIXt4QghJO8YqVSzniO4fdwfouepvXqTBnCPxMjgxJbU2JET\n\tKl2My8zrAl+w3F3epS4BlWWjbFWdm0ABSuKGrH5g=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Nov 2021 18:26:11 +0200", "Message-Id": "<20211116162615.27777-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211116162615.27777-1-laurent.pinchart@ideasonboard.com>", "References": "<20211116162615.27777-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/5] ipa: ipu3: agc: Drop kMaxLuminance\n\tconstant", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The kMaxLuminance constant is badly named, it's not a maximum luminance,\nbut the maximum integer value output by the AWB statistics engine for\nper-channel averages. The constant is used in a single place, hardcoding\nthe value is actually more readable.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex bd02c474611c..43a39ffd57d6 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -61,9 +61,6 @@ static constexpr double kEvGainTarget = 0.5;\n /* Number of frames to wait before calculating stats on minimum exposure */\n static constexpr uint32_t kNumStartupFrames = 10;\n \n-/* Maximum luminance used for brightness normalization */\n-static constexpr uint32_t kMaxLuminance = 255;\n-\n /*\n * Normalized luma value target.\n *\n@@ -298,8 +295,7 @@ double Agc::computeInitialY(IPAFrameContext &frameContext,\n \t\t greenSum * frameContext.awb.gains.green * .587 +\n \t\t blueSum * frameContext.awb.gains.blue * .114;\n \n-\t/* Return the normalized relative luminance. */\n-\treturn Y_sum / (grid.height * grid.width) / kMaxLuminance;\n+\treturn Y_sum / (grid.height * grid.width) / 255;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "1/5" ] }