Patch Detail
Show a patch.
GET /api/patches/14587/?format=api
{ "id": 14587, "url": "https://patchwork.libcamera.org/api/patches/14587/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14587/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211112100305.2217099-2-naush@raspberrypi.com>", "date": "2021-11-12T10:03:03", "name": "[libcamera-devel,v2,1/3] pipeline: raspberrypi: Add const qualifer in isRaw()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bea63309db0714abca4b5bcbdb271f58de5f418c", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14587/mbox/", "series": [ { "id": 2716, "url": "https://patchwork.libcamera.org/api/series/2716/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2716", "date": "2021-11-12T10:03:02", "name": "raspberrypi: Rework the internal buffer allocation scheme", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2716/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14587/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14587/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90657BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Nov 2021 10:03:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46C3D6035D;\n\tFri, 12 Nov 2021 11:03:48 +0100 (CET)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E0E960234\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Nov 2021 11:03:47 +0100 (CET)", "by mail-wm1-x331.google.com with SMTP id y196so7213624wmc.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Nov 2021 02:03:47 -0800 (PST)", "from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\to9sm5283155wrs.4.2021.11.12.02.03.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Nov 2021 02:03:46 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"LStabVOo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=cXVNeGLXDz6JtvQxKGu1TUTRWymUo0eSitm6CGOcfkI=;\n\tb=LStabVOozJlLjZrzCf04cYr9hNSg975Ni4o/2Oe5TgSOiTnsWlHjpyx0hY0oe1k1u9\n\tReMYRDxYp6Qa2cFgfhzFjYn/B443CIaronX6j+EXSa8l0oIYk5kLgEG+qTlS+lc16hUs\n\tADTg+WY22vy21DXwSLLYevL8sGv3JtHL+Dw29w2O4+yoxd57A3R4dPr6/dckJ4C/hyW7\n\tY/OmbZgihmTtzPVeuqPqPdr6I2zT+PvUVLxYO6Am7Q6GpE3z5rz7O0V0IhrxcwEkcDWY\n\tfc7ttOBf4qJvRpXLIVfN1OG44D9GxIBT4Mw39G3/hB9eQU+gOnm6SFsHXv9ll0EvyJmi\n\tGmzg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=cXVNeGLXDz6JtvQxKGu1TUTRWymUo0eSitm6CGOcfkI=;\n\tb=SDO6XCjDcdW4w4Vr/Sk+OL4xm/lysva5dOM+ErHWepiSybxq8RcNXk7nXe5qslBf1B\n\t+CYAIokzvB/Hv1XaieROyEdfhgKFI8GwGDGOItgSiF+OmljAKwPuJktfdyZaSdywNr5a\n\t7laJoTQx1oF3b4LDe97pbVjU3LBvpTHKTUk7Lac2bolEm2nYmxEfRSVNC2m7MjIpKpG9\n\tqyRAog2aIHhW61IeO8lKlx34ijwW4aWse7ui0iPY4fFPLk8Adk5Ubbr7eVLP0fvLpxOH\n\tITp5O5QoxJt2i22rUKXI7g/BxnyxlKws6abkSBwIpEvamOGWRrDP1tdRjVQcuvPZ8fDE\n\tEYKQ==", "X-Gm-Message-State": "AOAM532YncQ1uLD7Ndkif1aOUa+QQXtqCZbKDfJHZsmPGAJ/Wcv1dF41\n\t2yD5LxGF+z5zQVPQHdqCHxNgxGxWeiAjBBkr", "X-Google-Smtp-Source": "ABdhPJzAcZEaLvGjN+3bXe7ONYWJhW0lJ9/eEHE7PqpWgmQHPqtTpOgsgQcFoRt89y4DqJqN/Dm93A==", "X-Received": "by 2002:a05:600c:2297:: with SMTP id\n\t23mr32152915wmf.73.1636711426629; \n\tFri, 12 Nov 2021 02:03:46 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Nov 2021 10:03:03 +0000", "Message-Id": "<20211112100305.2217099-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211112100305.2217099-1-naush@raspberrypi.com>", "References": "<20211112100305.2217099-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Roman Stratiienko <r.stratiienko@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This function does not modify the pixFmt parameter, so use a const qualifier.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 5e1f227398a9..11d3c2b120dd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n \treturn deviceFormat;\n }\n \n-bool isRaw(PixelFormat &pixFmt)\n+bool isRaw(const PixelFormat &pixFmt)\n {\n \t/*\n \t * The isRaw test might be redundant right now the pipeline handler only\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }