Patch Detail
Show a patch.
GET /api/patches/14561/?format=api
{ "id": 14561, "url": "https://patchwork.libcamera.org/api/patches/14561/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14561/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211111110605.105202-7-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-11T11:05:57", "name": "[libcamera-devel,v3,06/14] ipa: ipu3: agc: Refactor ev gain calculation and testing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cda4e9f2d4318e56dec810d367717ca3e351473c", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14561/mbox/", "series": [ { "id": 2713, "url": "https://patchwork.libcamera.org/api/series/2713/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2713", "date": "2021-11-11T11:05:51", "name": "IPA: IPU3: Introduce per-frame controls", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2713/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14561/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14561/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35900C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Nov 2021 11:06:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 580206036F;\n\tThu, 11 Nov 2021 12:06:19 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD7D060369\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 12:06:10 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e627:8337:a781:d98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6604C4A6;\n\tThu, 11 Nov 2021 12:06:10 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jDvNJMnc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636628770;\n\tbh=EG1KRtC2FK51EjXX/dSiaGYIrwZ9w0KhblE0WnJdxpc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jDvNJMnchk3eO+k5Ps0EeugqmDrPrb3kz45XX/Sk/OAsmwpbjnN5XMHOMbcBmX2ER\n\tTp2+HiJlfA5CTUUSaA84jHNZt11AY5EKDmfDghVLuYqYCG85U9rq31Edz2iWdt0Iza\n\tl0FnmCGouztdbvzyQhxqx336WE2sWKDkYyFt6CbU=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Nov 2021 12:05:57 +0100", "Message-Id": "<20211111110605.105202-7-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211111110605.105202-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211111110605.105202-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 06/14] ipa: ipu3: agc: Refactor ev gain\n\tcalculation and testing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When we compute the new gain, we use the iqMean_ and estimate an\nexposure value gain to apply. Return early when the gain is less than\n1%.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 862366ac..71a7f39a 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -188,14 +188,6 @@ void Agc::filterExposure()\n */\n void Agc::computeExposure(IPAFrameContext &frameContext)\n {\n-\n-\t/* Are we correctly exposed ? */\n-\tif (std::abs(iqMean_ - kEvGainTarget * knumHistogramBins) <= 1) {\n-\t\tLOG(IPU3Agc, Debug) << \"We are well exposed (iqMean = \"\n-\t\t\t\t << iqMean_ << \")\";\n-\t\treturn;\n-\t}\n-\n \t/* Get the effective exposure and gain applied on the sensor. */\n \tuint32_t &exposure = frameContext.sensor.exposure;\n \tdouble &analogueGain = frameContext.sensor.gain;\n@@ -203,6 +195,12 @@ void Agc::computeExposure(IPAFrameContext &frameContext)\n \t/* Estimate the gain needed to have the proportion wanted */\n \tdouble evGain = kEvGainTarget * knumHistogramBins / iqMean_;\n \n+\tif (std::abs(evGain - 1.0) < 0.01) {\n+\t\tLOG(IPU3Agc, Debug) << \"We are well exposed (iqMean = \"\n+\t\t\t\t << iqMean_ << \")\";\n+\t\treturn;\n+\t}\n+\n \t/* extracted from Rpi::Agc::computeTargetExposure */\n \t/* Calculate the shutter time in seconds */\n \tutils::Duration currentShutter = exposure * lineDuration_;\n", "prefixes": [ "libcamera-devel", "v3", "06/14" ] }