Patch Detail
Show a patch.
GET /api/patches/14543/?format=api
{ "id": 14543, "url": "https://patchwork.libcamera.org/api/patches/14543/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14543/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>", "date": "2021-11-10T23:33:41", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Fix minCrop indentation", "commit_ref": "6b288f8f4f53edf90cc7ab22fc41c7edaa69e123", "pull_url": null, "state": "accepted", "archived": false, "hash": "8ad15cddc8b441085e1ed1685b7ec89d04a04ac6", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14543/mbox/", "series": [ { "id": 2709, "url": "https://patchwork.libcamera.org/api/series/2709/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2709", "date": "2021-11-10T23:33:41", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Fix minCrop indentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2709/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14543/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14543/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51F99BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 23:33:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2B086034E;\n\tThu, 11 Nov 2021 00:33:47 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 733B5600BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 00:33:46 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 025BB3E7;\n\tThu, 11 Nov 2021 00:33:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nAIFW9xY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636587226;\n\tbh=Hpm6YN6TFI1yrNwFApXbU6aBBoHjGhwmVzgWTc536QA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=nAIFW9xY3WG47PBlZfDHR9UeP7S1sREmmEF2+PhOBIpKhTH2odkZjaF9GT4F+r9Gi\n\tVPHb7vJP+f2mYk5jUvtPYHYwMlzpw9WZFskItQz5mR8+mNMYDijJ7/OnNoML6zvS7d\n\tvRWpdF6QwZg4JwH62P3swrejWYU6pQiELjja9VkI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 10 Nov 2021 23:33:41 +0000", "Message-Id": "<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix minCrop\n\tindentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When updating the controls the calculation for minCrop incorrectly\nindents the parameters to scaledBy().\n\nFix it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex eb714aa61099..3cd7383f0e40 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1039,7 +1039,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)\n \t * top-left corner as we allow application to freely pan the crop area.\n \t */\n \tRectangle minCrop = Rectangle(minSize).scaledBy(analogueCrop.size(),\n-\t\t\t\t\t sensorInfo.outputSize);\n+\t\t\t\t\t\t\tsensorInfo.outputSize);\n \n \tcontrols[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);\n \n", "prefixes": [ "libcamera-devel" ] }