Patch Detail
Show a patch.
GET /api/patches/14537/?format=api
{ "id": 14537, "url": "https://patchwork.libcamera.org/api/patches/14537/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14537/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211110195901.85597-11-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-10T19:58:57", "name": "[libcamera-devel,v2,10/14] ipa: ipu3: awb: Add support for color temperature", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3134f68a04c9112b9d04b81e4ff3a6a24a4a8ce6", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14537/mbox/", "series": [ { "id": 2708, "url": "https://patchwork.libcamera.org/api/series/2708/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2708", "date": "2021-11-10T19:58:47", "name": "IPA: IPU3: Introduce per-frame controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2708/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14537/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14537/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D81F7BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 19:59:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B3386034E;\n\tWed, 10 Nov 2021 20:59:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 102EE60378\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 20:59:08 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:7713:3465:89e6:c5cd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD05B8B6;\n\tWed, 10 Nov 2021 20:59:07 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e2GLxx2q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636574347;\n\tbh=Zfa8T5He8JzrMkOGNJeAvgz2SjuZrJ3s+Kv+0r0+1oM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e2GLxx2qbXUopjXeMu7ZYsviu45iwvhy9oGUotbSXiAMXWvc+WlKdfQatT2xnZxpr\n\tHeuALdY/T3TNk0UcTXIK1UnxbJJYF3/q349zcSpbQNxTQ0N5GQRU8yo/vymAxOoc4F\n\tQgo+ms49Yt6pSQ1qpaiDwAQHQTIdhNm+wlQuYCuE=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 10 Nov 2021 20:58:57 +0100", "Message-Id": "<20211110195901.85597-11-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 10/14] ipa: ipu3: awb: Add support for\n\tcolor temperature", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AWB estimates the color temperature, but it is not used at all. It\ncan be useful for debug purpose at least, but also for lux estimation\nlater, to be able to know the temperature estimated for a given frame.\n\nAdd a new member to the IPAFrameContext::awb for this purpose, and\nupdate the value in AWB.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 1 +\n src/ipa/ipu3/ipa_context.cpp | 3 +++\n src/ipa/ipu3/ipa_context.h | 2 ++\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex a4114659..c7bcb20e 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -385,6 +385,7 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n \tcontext.frameContext.awb.gains.blue = asyncResults_.blueGain;\n \tcontext.frameContext.awb.gains.green = asyncResults_.greenGain;\n \tcontext.frameContext.awb.gains.red = asyncResults_.redGain;\n+\tcontext.frameContext.awb.temperatureK = asyncResults_.temperatureK;\n }\n \n constexpr uint16_t Awb::threshold(float value)\ndiff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 2355a9c7..0205640e 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -117,6 +117,9 @@ namespace libcamera::ipa::ipu3 {\n *\n * \\var IPAFrameContext::awb.gains.blue\n * \\brief White balance gain for B channel\n+ *\n+ * \\var IPAFrameContext::awb.temperatureK\n+ * \\brief Estimated color temperature\n */\n \n /**\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex 1e46c61a..e1087224 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -45,6 +45,8 @@ struct IPAFrameContext {\n \t\t\tdouble green;\n \t\t\tdouble blue;\n \t\t} gains;\n+\n+\t\tdouble temperatureK;\n \t} awb;\n \n \tstruct {\n", "prefixes": [ "libcamera-devel", "v2", "10/14" ] }