Patch Detail
Show a patch.
GET /api/patches/14517/?format=api
{ "id": 14517, "url": "https://patchwork.libcamera.org/api/patches/14517/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14517/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211110100802.349623-3-naush@raspberrypi.com>", "date": "2021-11-10T10:08:02", "name": "[libcamera-devel,3/3] pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6fecd03e6e0a4474f9254a6988e243ff7c82ce84", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14517/mbox/", "series": [ { "id": 2703, "url": "https://patchwork.libcamera.org/api/series/2703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2703", "date": "2021-11-10T10:08:00", "name": "[libcamera-devel,1/3] pipeline: raspberrypi: Add const qualifer in isRaw()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14517/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14517/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 845D5BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 10:08:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C75386034A;\n\tWed, 10 Nov 2021 11:08:11 +0100 (CET)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A07CE6034E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 11:08:08 +0100 (CET)", "by mail-wr1-x435.google.com with SMTP id r8so3000096wra.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 02:08:08 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:8747:6ef9:ee17:3d59])\n\tby smtp.gmail.com with ESMTPSA id\n\td11sm21969133wrs.38.2021.11.10.02.08.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Nov 2021 02:08:07 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lXkI4E6F\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=l65rxfveEruSiHLvSJ6ZxHP4Un5MGATlNW0H1XExuqw=;\n\tb=lXkI4E6FhgHVJV1IrOX5sKYotSWsb2791INayvCwR402GDDPih+Yx/xQvzsRNgCS4m\n\tqMmBeYtTWUba6iqSEuwlgwWJQZ73MgyTKbhiJTaVKV6OZUuK2xwJxklCbukI4qK5AYJe\n\t1uerXDG3J/1cRCNnDTlt8s9++/dYxWqBXr8zDnGc8D6yooigAmwgR2chkPhxjcj2U5ik\n\tQ8i+eeCld8kl68TryaYTZeocap7jqmTdfc0fxI+mutu1mVjOYY4FcMyJuPe5DueJXPxJ\n\tuo1Rd+wWMZaz5QrtNaN+H6Yy08r2b2QSHa02wjWjMY9cLRnT28bSL2cPAFQX7DgRvhxN\n\t4r6Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=l65rxfveEruSiHLvSJ6ZxHP4Un5MGATlNW0H1XExuqw=;\n\tb=lOWT8/96zdnn8h8g1MHTgjY3XvlMOV/4u4nroPOjHx6t4p0eO/vTn9mU8tqmvaeKeT\n\t1UtDqdHxTSMFfU/eG3gst8rMCy35YDG+k9Zfcmp4F7BImno7lm1UKdKLbyrReOP+0G9b\n\t+b9S+wysZbK5n9XVeJnOjsSKYVdRlg/zE2gLGJGkWphcuDKIvaZPzk8wo8L3ILgHRp52\n\tJ8z+A1Fkq+ej3v0WvsGb0d9RQN5dabq/icLH0U0Brpog5Se36PPbb1Vu2+zeNJxvoC/M\n\tkNNmDCQQtQCq+rEXA5ga6XLSVfEPTrE78NRf8HMwvSaCFBSWLvSkk47fXGZEXT1WFSd7\n\t54oQ==", "X-Gm-Message-State": "AOAM530p73iATXt+LkkgKlgAudZDKbACTDBFsSfsBOTTjRICk7b+36k7\n\tJOd2YcMl8rTolnVYFGnuWxHbtIEc2ptO5Wwc", "X-Google-Smtp-Source": "ABdhPJxDz4Fr4dIWmhI217CGdAd19BXUcHL+SL62t/QBGQylimx2s427U8EKopkMDHgoUBrYqd1V/w==", "X-Received": "by 2002:adf:c70b:: with SMTP id\n\tk11mr17493046wrg.154.1636538888134; \n\tWed, 10 Nov 2021 02:08:08 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 10 Nov 2021 10:08:02 +0000", "Message-Id": "<20211110100802.349623-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211110100802.349623-1-naush@raspberrypi.com>", "References": "<20211110100802.349623-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Increase the\n\tV4L2BufferCache slot allocations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Roman Stratiienko <r.stratiienko@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If a stream is marked as external, double the number of V4L2BufferCache slots\nthat are allocated. This is to account for additional buffers that may be\nallocated directly by the application.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\nindex b3265d0e8aab..67901936d6b6 100644\n--- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n@@ -107,6 +107,14 @@ int Stream::prepareBuffers(unsigned int count)\n \t\tcount = bufferMap_.size();\n \t}\n \n+\t/*\n+\t * If this is an external stream, we must allocate slots for buffers that\n+\t * might be externally allocated. We have no indication of how many buffers\n+\t * may be used, so this might overallocate slots in the buffer cache.\n+\t */\n+\tif (isExternal())\n+\t\tcount = count * 2;\n+\n \treturn dev_->importBuffers(count);\n }\n \n", "prefixes": [ "libcamera-devel", "3/3" ] }