Patch Detail
Show a patch.
GET /api/patches/14511/?format=api
{ "id": 14511, "url": "https://patchwork.libcamera.org/api/patches/14511/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14511/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211110072207.3273703-4-hiroh@chromium.org>", "date": "2021-11-10T07:22:07", "name": "[libcamera-devel,v6,4/4] libcamera: pipeline: ipu3: Apply the requested test pattern mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7f9d21c35bbbd6d18789b0a43c798004341b4266", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14511/mbox/", "series": [ { "id": 2701, "url": "https://patchwork.libcamera.org/api/series/2701/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2701", "date": "2021-11-10T07:22:04", "name": "[libcamera-devel,v6,1/4] lc-compliance: Build with gtest in subprojects", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2701/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14511/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14511/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 437B8BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 07:22:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EECBE60371;\n\tWed, 10 Nov 2021 08:22:21 +0100 (CET)", "from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com\n\t[IPv6:2607:f8b0:4864:20::102a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 747656036C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 08:22:20 +0100 (CET)", "by mail-pj1-x102a.google.com with SMTP id x7so774659pjn.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Nov 2021 23:22:20 -0800 (PST)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:4a73:e1bd:9b3f:4903])\n\tby smtp.gmail.com with ESMTPSA id\n\tr1sm5073669pjm.23.2021.11.09.23.22.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Nov 2021 23:22:18 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"MygaKImK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=r7f2fGj+mUTwvthsJCh3urmoJouWjESIr9jPyXgtAyw=;\n\tb=MygaKImKmaHcPWC/42xcrbv1lFt1dMF9cOefhkBQlUWuwRJQNY0Q4d1mWEjpMKr/Pq\n\tGEWgevON3lUwexlkNGwqNf7tdtQBl/z5HNLJYSurFB19oSLM28rC8hpXsXly4FfLJN4Z\n\tYfUjKO+E9Uo0mn/cSi1q7Z/+zDosTb5t+89LQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=r7f2fGj+mUTwvthsJCh3urmoJouWjESIr9jPyXgtAyw=;\n\tb=S6a2QkHEsMB0BqzdFUg2tT7hYNGSdjKB1Vj87mJ0+pbq8hVNgTlAWuLNH35H+PoVON\n\t/dsgrH0hFH7Dd82Rs1J0AC1ITQYEynKnlGYSEEe+OUocpHi2kIVxYBr8mayY+aF88qUu\n\toZaCl+ZYQSI8XejdR1PU2Pi40dSvfS8Cs7DtIGl/KLtn3zneG1Ro8QBTy3x+9fta6oCT\n\tLvxn9m7wlAdrj1yfLBZRq8QnfB0yPDWp2Es2kpZ406Z/mQf7Mng5uJAN8t1jd1FG5dZI\n\tNTD371d0B8oYEHXvl9rBmSCZoTTDld83qwSTZtSnljIix+ZOWA1z0dSQGk0DHvtLZFeo\n\tE4FQ==", "X-Gm-Message-State": "AOAM532FRPhDhQ/OnoBlBGZU/W/dZ9c67g9A/aRhPD+VQX+t89r7E+Hv\n\tz/xuPmTXYk1BkmipgsnvGgm+PNxOmTiVJg==", "X-Google-Smtp-Source": "ABdhPJzMMgP5jt3VyflccDSV12XFxvneFeNBB8abU8JEtYZd8Jg5iZHhanYjl1MmDQhhtv9SZQEPqg==", "X-Received": "by 2002:a17:90a:1913:: with SMTP id\n\t19mr14565776pjg.174.1636528938796; \n\tTue, 09 Nov 2021 23:22:18 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 10 Nov 2021 16:22:07 +0900", "Message-Id": "<20211110072207.3273703-4-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc0.344.g81b53c2807-goog", "In-Reply-To": "<20211110072207.3273703-1-hiroh@chromium.org>", "References": "<20211110072207.3273703-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 4/4] libcamera: pipeline: ipu3: Apply\n\tthe requested test pattern mode", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This enables ipu3 pipeline handler to apply the test pattern mode\nper frame.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 34 ++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 29 ++++++++++++++++--\n 3 files changed, 62 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 60ce0c45..ed782476 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -58,6 +58,7 @@ public:\n \tconst ControlInfoMap &controls() const;\n \tControlList getControls(const std::vector<uint32_t> &ids);\n \tint setControls(ControlList *ctrls);\n+\tint applyRequestControls(Request *request);\n \n \tV4L2Subdevice *device() { return subdev_.get(); }\n \ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex cfb9bc17..a20f3d95 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -755,6 +755,40 @@ int CameraSensor::setControls(ControlList *ctrls)\n \treturn subdev_->setControls(ctrls);\n }\n \n+/**\n+ * \\brief Apply controls associated with Request\n+ * \\param[in] request Request that may contain contorls to be applied\n+ *\n+ * Some controls have to be applied for a capture associated with Request.\n+ * This picks up such controls and set the driver them.\n+ *\n+ * \\return 0 on success or an error code otherwise\n+ */\n+int32_t CameraSensor::applyRequestControls(Request *request)\n+{\n+\t/* Assumes applying the test pattern mode affects immediately. */\n+\tif (request->controls().contains(controls::draft::TestPatternMode)) {\n+\t\tconst int32_t testPatternMode = request->controls().get(\n+\t\t\tcontrols::draft::TestPatternMode);\n+\n+\t\tLOG(CameraSensor, Debug) << \"Apply test pattern mode: \"\n+\t\t\t\t\t << testPatternMode;\n+\n+\t\tint ret = setTestPatternMode(\n+\t\t\tstatic_cast<controls::draft::TestPatternModeEnum>(testPatternMode));\n+\t\tif (ret) {\n+\t\t\tLOG(CameraSensor, Error)\n+\t\t\t\t<< \"Failed to set test pattern mode: \" << ret;\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\trequest->metadata().set(controls::draft::TestPatternMode,\n+\t\t\t\t\ttestPatternMode);\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * \\fn CameraSensor::device()\n * \\brief Retrieve the camera sensor device\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 63cb7f11..f4137f2d 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -59,6 +59,7 @@ public:\n \tvoid statBufferReady(FrameBuffer *buffer);\n \tvoid queuePendingRequests();\n \tvoid cancelPendingRequests();\n+\tvoid frameStart(uint32_t sequence);\n \n \tCIO2Device cio2_;\n \tImgUDevice *imgu_;\n@@ -77,7 +78,10 @@ public:\n \n \tstd::unique_ptr<ipa::ipu3::IPAProxyIPU3> ipa_;\n \n+\t/* Requests before queueing cio2 device. */\n \tstd::queue<Request *> pendingRequests_;\n+\t/* Requests queued in cio2 device and before passing imgu device. */\n+\tstd::queue<Request *> processingRequests_;\n \n \tControlInfoMap ipaControls_;\n \n@@ -802,6 +806,7 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n \n \tret |= data->imgu_->stop();\n \tret |= data->cio2_.stop();\n+\n \tif (ret)\n \t\tLOG(IPU3, Warning) << \"Failed to stop camera \" << camera->id();\n \n@@ -822,6 +827,8 @@ void IPU3CameraData::cancelPendingRequests()\n \t\tpipe()->completeRequest(request);\n \t\tpendingRequests_.pop();\n \t}\n+\n+\tprocessingRequests_ = {};\n }\n \n void IPU3CameraData::queuePendingRequests()\n@@ -852,6 +859,8 @@ void IPU3CameraData::queuePendingRequests()\n \n \t\tinfo->rawBuffer = rawBuffer;\n \n+\t\tprocessingRequests_.push(request);\n+\n \t\tipa::ipu3::IPU3Event ev;\n \t\tev.op = ipa::ipu3::EventProcessControls;\n \t\tev.frame = info->id;\n@@ -1131,8 +1140,8 @@ int PipelineHandlerIPU3::registerCameras()\n \t\tdata->delayedCtrls_ =\n \t\t\tstd::make_unique<DelayedControls>(cio2->sensor()->device(),\n \t\t\t\t\t\t\t params);\n-\t\tdata->cio2_.frameStart().connect(data->delayedCtrls_.get(),\n-\t\t\t\t\t\t &DelayedControls::applyControls);\n+\t\tdata->cio2_.frameStart().connect(data.get(),\n+\t\t\t\t\t\t &IPU3CameraData::frameStart);\n \n \t\t/* Convert the sensor rotation to a transformation */\n \t\tint32_t rotation = 0;\n@@ -1423,6 +1432,22 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tipa_->processEvent(ev);\n }\n \n+void IPU3CameraData::frameStart(uint32_t sequence)\n+{\n+\tif (!processingRequests_.empty()) {\n+\t\t/* Handle controls which are to be set ready for the next frame to start. */\n+\t\tRequest *request = processingRequests_.front();\n+\t\tprocessingRequests_.pop();\n+\n+\t\tint ret = cio2_.sensor()->applyRequestControls(request);\n+\t\tif (ret)\n+\t\t\tLOG(IPU3, Error) << \"Failed applying controls: \" << ret;\n+\t}\n+\n+\t/* Controls that don't affect immediately are applied in delayedCtrls. */\n+\tdelayedCtrls_->applyControls(sequence);\n+}\n+\n REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v6", "4/4" ] }