Patch Detail
Show a patch.
GET /api/patches/14485/?format=api
{ "id": 14485, "url": "https://patchwork.libcamera.org/api/patches/14485/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14485/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211108131350.130665-17-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-08T13:13:44", "name": "[libcamera-devel,16/22] ipa: ipu3: Introduce sensor controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f44e01471173d75b56fb63aaabc045ba49856b17", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14485/mbox/", "series": [ { "id": 2696, "url": "https://patchwork.libcamera.org/api/series/2696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2696", "date": "2021-11-08T13:13:28", "name": "IPA: IPU3: Introduce per-frame controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14485/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14485/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C508C3251\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Nov 2021 13:14:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 494BD603C4;\n\tMon, 8 Nov 2021 14:14:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 892176038C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Nov 2021 14:14:02 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44F76190C;\n\tMon, 8 Nov 2021 14:14:02 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AzVY9L4M\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377242;\n\tbh=EtwI61Kvv4r1oZ635E9dmb6qP9qEYqj11s+iLZiyn2w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AzVY9L4MBAHbBkFj7ibvBqIwMRyOC7N7ebVVKdcJUhZDRaDN6EHMOdVojUWiATBsF\n\t+OeRPVk0+aoT1jMmrnljwPne2FKMDkR7iu7JJJ/fEw6nyFkfbZEIcX+WD4o6G3XpFD\n\tLAzU0B8mxJlfu5OXMJHMBCQ/L4PAtRWXcwKDxlBU=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Nov 2021 14:13:44 +0100", "Message-Id": "<20211108131350.130665-17-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 16/22] ipa: ipu3: Introduce sensor controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Pass the sensor controls as well as the libcamera controls to\nprocessControl() on an EventProcessControls event received. This will be\nused to populate the frame context.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex dcf4da65..177c5c2f 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -151,7 +151,9 @@ private:\n \t\t\t ControlInfoMap *ipaControls);\n \tvoid updateSessionConfiguration(const IPACameraSensorInfo &sensorInfo,\n \t\t\t\t\tconst ControlInfoMap &sensorControls);\n-\tvoid processControls(unsigned int frame, const ControlList &controls);\n+\tvoid processControls(unsigned int frame,\n+\t\t\t const ControlList &controls,\n+\t\t\t const ControlList &sensorCtrls);\n \tvoid fillParams(unsigned int frame, ipu3_uapi_params *params);\n \tvoid parseStatistics(unsigned int frame,\n \t\t\t int64_t frameTimestamp,\n@@ -549,7 +551,7 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\t * a new frame.\n \t\t */\n \t\tframeStarted(event.frame);\n-\t\tprocessControls(event.frame, event.controls);\n+\t\tprocessControls(event.frame, event.controls, event.sensorControls);\n \t\tbreak;\n \t}\n \tcase EventFillParams: {\n@@ -601,12 +603,14 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n * \\brief Process a control list for a request from the application\n * \\param[in] frame The number of the frame which will be processed next\n * \\param[in] controls The controls for the \\a frame\n+ * \\param[in] controls The sensor controls for the \\a frame\n *\n * Parse the request to handle any IPA-managed controls that were set from the\n * application such as manual sensor settings.\n */\n void IPAIPU3::processControls([[maybe_unused]] unsigned int frame,\n-\t\t\t [[maybe_unused]] const ControlList &controls)\n+\t\t\t [[maybe_unused]] const ControlList &controls,\n+\t\t\t [[maybe_unused]] const ControlList &sensorCtrls)\n {\n \t/* \\todo Start processing for 'frame' based on 'controls'. */\n }\n", "prefixes": [ "libcamera-devel", "16/22" ] }