Patch Detail
Show a patch.
GET /api/patches/14390/?format=api
{ "id": 14390, "url": "https://patchwork.libcamera.org/api/patches/14390/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14390/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211028100349.1098545-1-hanlinchen@chromium.org>", "date": "2021-10-28T10:03:44", "name": "[libcamera-devel,1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "35283964bcb66bd71089c6b8d35a7c4da5597353", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14390/mbox/", "series": [ { "id": 2673, "url": "https://patchwork.libcamera.org/api/series/2673/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2673", "date": "2021-10-28T10:03:44", "name": "[libcamera-devel,1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2673/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14390/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14390/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 935F5BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 28 Oct 2021 10:03:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50E5C600BB;\n\tThu, 28 Oct 2021 12:03:54 +0200 (CEST)", "from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com\n\t[IPv6:2607:f8b0:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CBA0600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Oct 2021 12:03:53 +0200 (CEST)", "by mail-pg1-x52f.google.com with SMTP id t7so5876713pgl.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Oct 2021 03:03:53 -0700 (PDT)", "from localhost ([2401:fa00:1:10:1bc:52e7:6df5:c7cf])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tw21sm3122629pfu.68.2021.10.28.03.03.51\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 28 Oct 2021 03:03:51 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"EfnqQy5Y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=DgneWOyX29bUTgvuPCS53eREeOsak0Fruu65Vcrdp8M=;\n\tb=EfnqQy5YPCV0LJaZqy389jrq/UkhxSOsA1Bk2s6IapLphcVMbjryY2s0dWVzR+zY5m\n\tAJbhGxfqt2EuwTwT2Qryf42ebIuSY7jDH+TknGphWAGVIvKkkvMYPpwB/vn1DJFM67M+\n\t/O45KTB9yss25HVZRk9Wf53N+vYGXxR2k2FCs=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=DgneWOyX29bUTgvuPCS53eREeOsak0Fruu65Vcrdp8M=;\n\tb=qekInM5Pkrfk7zoccAhtNo6RWvrD9EWV1oQ1WfNmrd3xGE4ZMNcTf5M10w5v3X4Yca\n\tGixvSfQIT3zBfBOZfGIRsrHUFDfo2y+WKS9A1MlPzvVyjzv4SccID5//1oPE/KwIwG6m\n\trefRg1mrMy3pNNnGedgoj42o2fp3jKQmi64+LnXTSoMj3bFV59YNrL2KpFpqoEKW7/rP\n\tIjR4kx4G90bMdMgR7wEh4KwJ6NGR5uaAWdwqNIApKiCIvaP7II2SdlDyuPPULCZUPjwy\n\t1Ye0QMv2CZJtBbiktX+LUBcYn7U5TPdCTIVhRpu/kIDEfjPYeQZZ7CqqXMtJhW1wyBT8\n\t1M0A==", "X-Gm-Message-State": "AOAM532D7g9m4zrwnBmls0VbwFtqSazItVg7CzWboV/3MwCdrjgeFPee\n\tAc+9qwMevjvKJcgS6dywGtxMmK8oVV5LtNAt", "X-Google-Smtp-Source": "ABdhPJz3+Sdcjc2mr+uocmynwLxEZb/Nxnh+AT7KjCWyp89G6QSRFS5BASQa5zaR896xiK23sdE8MA==", "X-Received": "by 2002:a65:62c1:: with SMTP id m1mr2455093pgv.339.1635415431962;\n\tThu, 28 Oct 2021 03:03:51 -0700 (PDT)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 Oct 2021 18:03:44 +0800", "Message-Id": "<20211028100349.1098545-1-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.33.1.1089.g2158813163f-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/6] ipu3: Use ia_aiq_frame_use_preview as\n\tdefault mode for AIQ", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Han-Lin Chen <hanlinchen@chromium.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The frame use mode is set according to Android Capture Intent in Intel\nHAL's implememtation. The current default mode ia_aiq_frame_use_still is\nonly used with the single capture request. For preview use case, it has\nhard time converging AE and AF smoothly. Change the default mode to\nia_aiq_frame_use_preview for better user experience.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.com>\n---\n aiq/aiq_input_parameters.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\nindex 36e2b07..bc87b31 100644\n--- a/aiq/aiq_input_parameters.cpp\n+++ b/aiq/aiq_input_parameters.cpp\n@@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n {\n \t/*Ae Params */\n \taeInputParams.num_exposures = NUM_EXPOSURES;\n-\taeInputParams.frame_use = ia_aiq_frame_use_still;\n+\taeInputParams.frame_use = ia_aiq_frame_use_preview;\n \taeInputParams.flash_mode = ia_aiq_flash_mode_off;\n \taeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic;\n \taeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative;\n@@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \taeInputParams.manual_convergence_time = -1;\n \n \t/* AWB Params */\n-\tawbParams.frame_use = ia_aiq_frame_use_still;\n+\tawbParams.frame_use = ia_aiq_frame_use_preview;\n \tawbParams.scene_mode = ia_aiq_awb_operation_mode_auto;\n \tawbParams.manual_convergence_time = -1.0;\n \tawbParams.manual_cct_range = nullptr;\n@@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \n \t/* AF Params */\n \tafParams = {\n-\t\tia_aiq_frame_use_still, 0, 1500,\n+\t\tia_aiq_frame_use_preview, 0, 1500,\n \t\tia_aiq_af_operation_mode_auto,\n \t\tia_aiq_af_range_normal,\n \t\tia_aiq_af_metering_mode_auto,\n@@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \t/* GBCE Params */\n \tgbceParams.gbce_level = ia_aiq_gbce_level_bypass;\n \tgbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n-\tgbceParams.frame_use = ia_aiq_frame_use_still;\n+\tgbceParams.frame_use = ia_aiq_frame_use_preview;\n \tgbceParams.ev_shift = 0;\n \n \t/* SA Params */\n-\tsaParams.frame_use = ia_aiq_frame_use_still;\n+\tsaParams.frame_use = ia_aiq_frame_use_preview;\n }\n \n } /* namespace ipa::ipu3::aiq */\n", "prefixes": [ "libcamera-devel", "1/6" ] }