Patch Detail
Show a patch.
GET /api/patches/14388/?format=api
{ "id": 14388, "url": "https://patchwork.libcamera.org/api/patches/14388/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14388/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211028100319.1097720-2-hanlinchen@chromium.org>", "date": "2021-10-28T10:03:17", "name": "[libcamera-devel,2/4] ipu3: ipa: Report effective sensor controls with stastistics to IPA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b9896c449966dbad2362097d27a36e541e9364b8", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14388/mbox/", "series": [ { "id": 2672, "url": "https://patchwork.libcamera.org/api/series/2672/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2672", "date": "2021-10-28T10:03:16", "name": "[libcamera-devel,1/4] ipa: ipu3: Extend ipu3 ipa interface for sensor and lens controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2672/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14388/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14388/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A483BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 28 Oct 2021 10:03:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B08E600C4;\n\tThu, 28 Oct 2021 12:03:29 +0200 (CEST)", "from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AB7C600BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Oct 2021 12:03:26 +0200 (CEST)", "by mail-pj1-x102b.google.com with SMTP id\n\tnn3-20020a17090b38c300b001a03bb6c4ebso4282952pjb.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Oct 2021 03:03:26 -0700 (PDT)", "from localhost ([2401:fa00:1:10:1bc:52e7:6df5:c7cf])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\ty13sm2960550pfa.43.2021.10.28.03.03.23\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 28 Oct 2021 03:03:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fslmLtEX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KwoGT7NzquHqxePhlUMI5IGOo9vSGuIcTWArhUGmf98=;\n\tb=fslmLtEXoftsGPnXpqatmwWxnSqo5Q62ZnK4fTvhGa7c/I0Ew+eaJjMJRkQurKQtQv\n\toBhjN47++KCRDLUu9reWWjWZb0pHl+WYLaXXzQkcVMltflKRLT1gsxW3dT9GudVVGD1x\n\tFjfu2Fws7hjqwlJ7SOpYfpgaOjCKoS2QpYnLI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=KwoGT7NzquHqxePhlUMI5IGOo9vSGuIcTWArhUGmf98=;\n\tb=0LWvP6he48IpWbYBZO0ozoRAA5+NT6ngoJpClxzVIe1MCybybSHP2eRJWw4fsoL9Bb\n\tnQT5j9fTjrd2ZJQ+b8n1b+M5ocV43O4nrkF6vYfA1vLThQozJeg2upwsVExgDNPScVPD\n\t1JX+JfkNNOyTxhgkYFz8rarzTUsnEN0OP2dR2QsN+qc5D0gp0REAIvh4UPBT7kmUYXTY\n\tUW4hmthi+YY7Uh/qV+8UL94O38LX5CuRMWy5lJ8KHsR5Wqzv85oYIIuK410yYV7j+LsH\n\teg7399GqDMu1ufrrjLU+qYxFw9Zc7TxsIg4wGJ+FDcfi1ysggQdyNCEqgEpVFNeKbhDi\n\to8Mw==", "X-Gm-Message-State": "AOAM531PwEj5UYxFX7rNUbE+oKNSLsKAeDgTRZtLMFOzQZNqx0FR9YAL\n\tZbGd7W3wi9UFIyRH/9Rh0cAifyw+rKS+JTyT", "X-Google-Smtp-Source": "ABdhPJwsxFMF4mEl1k5V0gUUsS3SbuZEQ118xtDza7sllhAv2KfT9GSU+70nEczfRMb5RBwOFuA+hQ==", "X-Received": "by 2002:a17:90b:1bce:: with SMTP id\n\toa14mr11714387pjb.225.1635415404560; \n\tThu, 28 Oct 2021 03:03:24 -0700 (PDT)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 Oct 2021 18:03:17 +0800", "Message-Id": "<20211028100319.1097720-2-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.33.1.1089.g2158813163f-goog", "In-Reply-To": "<20211028100319.1097720-1-hanlinchen@chromium.org>", "References": "<20211028100319.1097720-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/4] ipu3: ipa: Report effective sensor\n\tcontrols with stastistics to IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Han-Lin Chen <hanlinchen@chromium.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Intel close sourced IPA requires the effective controls applied to\nthe sensor when the stastistics are generated. Report effective sensor controls\nwith the stastistics to IPA.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.com>\n---\n src/libcamera/pipeline/ipu3/frames.h | 3 +++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 3ef7e445..a897e307 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -12,6 +12,7 @@\n #include <queue>\n #include <vector>\n \n+#include <libcamera/controls.h>\n #include <libcamera/base/signal.h>\n \n namespace libcamera {\n@@ -34,6 +35,8 @@ public:\n \t\tFrameBuffer *paramBuffer;\n \t\tFrameBuffer *statBuffer;\n \n+\t\tControlList effectiveSensorControls;\n+\n \t\tbool paramDequeued;\n \t\tbool metadataProcessed;\n \t};\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 8816efc5..6a7f5b9a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -667,6 +667,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \t}\n \n+\tdata->delayedCtrls_->reset();\n+\n \treturn updateControls(data);\n }\n \n@@ -1363,6 +1365,8 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbuffer->metadata().timestamp);\n \n+\tinfo->effectiveSensorControls = delayedCtrls_->get(buffer->metadata().sequence);\n+\n \tif (request->findBuffer(&rawStream_))\n \t\tpipe()->completeBuffer(request, buffer);\n \n@@ -1419,6 +1423,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tev.frame = info->id;\n \tev.bufferId = info->statBuffer->cookie();\n \tev.frameTimestamp = request->metadata().get(controls::SensorTimestamp);\n+\tev.sensorControls = info->effectiveSensorControls;\n \tipa_->processEvent(ev);\n }\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }