Patch Detail
Show a patch.
GET /api/patches/14361/?format=api
{ "id": 14361, "url": "https://patchwork.libcamera.org/api/patches/14361/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14361/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211027092803.3671096-8-naush@raspberrypi.com>", "date": "2021-10-27T09:28:01", "name": "[libcamera-devel,v3,7/9] pipeline: raspberrypi: Remove \"unpacked\" format penalty in mode selection", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a79f89c59e8a918bcaceeeb618a458a07c67eeeb", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14361/mbox/", "series": [ { "id": 2660, "url": "https://patchwork.libcamera.org/api/series/2660/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2660", "date": "2021-10-27T09:27:54", "name": "Raspberry Pi: Conversion to media controller", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2660/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14361/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14361/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51B99C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Oct 2021 09:28:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E152E64882;\n\tWed, 27 Oct 2021 11:28:18 +0200 (CEST)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C9DA64880\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Oct 2021 11:28:13 +0200 (CEST)", "by mail-wr1-x433.google.com with SMTP id g7so1900464wrb.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Oct 2021 02:28:13 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:6561:eb24:3f00:ce98])\n\tby smtp.gmail.com with ESMTPSA id\n\tx2sm2861360wmj.3.2021.10.27.02.28.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 27 Oct 2021 02:28:11 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cCkljPBe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Os5Yadalc02jPm02yV1BUtlymUhsIMIWwsB8S6NAQnc=;\n\tb=cCkljPBetb1TqvRmUdWjWppR1dr7EVQ9SfNmiifURCYuzofB4FAUrfLj/2SCGKWFLn\n\tVXFHrhhLOiXxbJqpWHART8F39QfcwJ9yzWb/eprlInpcH7lbB2IQe6bBN1eYCYx34ZDJ\n\taMWMQdS79ZYrTpGm6un5pAy1yVqG+wcAV8zXi3DZCXlH1QeoUkC+oWikrjfmoQM3zi7v\n\t2Ji3zVoXvC2P7UkcF+rocjKbqgMwQZHpib2OMSgxAUxl9fb4zONsrRquD1dkB0GfPzQp\n\tjuokQDA7UKVoPCt2hTGFCZUGLA4TgzzqlcNedByxPPDPpacohuL2c8CimE1kGozHvkh3\n\twaJw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Os5Yadalc02jPm02yV1BUtlymUhsIMIWwsB8S6NAQnc=;\n\tb=NfVsfPSseY0/GbIwADDsIrny9ZCPLHOS2d15osIxYBQvV7VUadq6GKMoKulWl5Axm3\n\tMuur+YGRj1Pa6TaC6Tst9BckKxZItdq5sY3nhpKJIu970WqTj9acTHtyY0/+nmgzOjd2\n\tODRXtLVaHdDTONYQrISerfIwYCefIGGZ1S3VkRnplXn3ihtGfdhFh+OfFgXxCfUXg03m\n\tq8+CqtbVRBcr/AxHOJ0+ZLYBhIdesJqGo3s5CIZxq8/MSGdL4tSHsis1OvSJvVxCjTRW\n\tNebL4yhLe9GHiPKzGPVgVbgB+Idrfa7RO/r/xql8LPg2RpUPwj8Gf1KWNPYbkdyj2pgI\n\tNR3g==", "X-Gm-Message-State": "AOAM533g7M4avBwoiOVJEGev5bfx9/Ls/9/PwAZhJUo9HIR5pi/QNKe9\n\tC2vPBC4QlRWeVFdzWRvBSInSVTQHQl+d3u48", "X-Google-Smtp-Source": "ABdhPJzzSdXRmuIH485t6VOkExN0HzIgWO2Eces+JD3k48Ft0GRvYzjzxtbF6k/FT3plB6fNpOYmtA==", "X-Received": "by 2002:a05:6000:1b90:: with SMTP id\n\tr16mr38422778wru.153.1635326892762; \n\tWed, 27 Oct 2021 02:28:12 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 27 Oct 2021 10:28:01 +0100", "Message-Id": "<20211027092803.3671096-8-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211027092803.3671096-1-naush@raspberrypi.com>", "References": "<20211027092803.3671096-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 7/9] pipeline: raspberrypi: Remove\n\t\"unpacked\" format penalty in mode selection", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the recent change to switch to programming the sensor device directly,\nthe notion of packed vs unpacked modes are not relevent, since that is a\nUnicam format construct. Remove any scoring based on packed/unpacked modes.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 1b78b5e74a63..e01359b20fd9 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -144,7 +144,6 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n #define PENALTY_8BIT\t\t2000.0\n #define PENALTY_10BIT\t\t1000.0\n #define PENALTY_12BIT\t\t 0.0\n-#define PENALTY_UNPACKED\t 500.0\n \n \t/* Calculate the closest/best mode from the user requested size. */\n \tfor (const auto &iter : formatsMap) {\n@@ -162,9 +161,6 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n \t\t\tscore += PENALTY_AR * scoreFormat(reqAr, fmtAr);\n \n \t\t\t/* Add any penalties... this is not an exact science! */\n-\t\t\tif (!info.packed)\n-\t\t\t\tscore += PENALTY_UNPACKED;\n-\n \t\t\tif (info.bitsPerPixel == 12)\n \t\t\t\tscore += PENALTY_12BIT;\n \t\t\telse if (info.bitsPerPixel == 10)\n", "prefixes": [ "libcamera-devel", "v3", "7/9" ] }