Patch Detail
Show a patch.
GET /api/patches/14337/?format=api
{ "id": 14337, "url": "https://patchwork.libcamera.org/api/patches/14337/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14337/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211026112340.110169-5-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-26T11:23:25", "name": "[libcamera-devel,v5,04/19] ipa: ipu3: Explicitly use the statistics parameter", "commit_ref": "db5f8d3271c0c50b27968fa5a747a81848dbc6c9", "pull_url": null, "state": "accepted", "archived": false, "hash": "e8878f21f3d71f0398f6d20542728593317f44d9", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14337/mbox/", "series": [ { "id": 2658, "url": "https://patchwork.libcamera.org/api/series/2658/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2658", "date": "2021-10-26T11:23:21", "name": "Document IPU3 IPA", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2658/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14337/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14337/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8ADDBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Oct 2021 11:23:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA0B66489B;\n\tTue, 26 Oct 2021 13:23:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55A0C64877\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Oct 2021 13:23:45 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 048CFDBF;\n\tTue, 26 Oct 2021 13:23:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IKR+IYW9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635247425;\n\tbh=EnGGCYCxMtryh7kpm+1yH7bkYgiZ+JtzUkgl1uMuzF0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IKR+IYW9gjf5oioSBvZCcVUAPkBAXkWHmlVURXLGmWkXSZvDXye3nC4rplTMaT7b0\n\tNVV9NVPpgzotuxNwb2yMXrd6VbBamvU/j2+jvkmJFVjU58H01gcCOBkthjYMWAWiDj\n\t3JyCfzsJgF2ykeW25941jvKopH6JYNTVudywYm6g=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Oct 2021 13:23:25 +0200", "Message-Id": "<20211026112340.110169-5-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 04/19] ipa: ipu3: Explicitly use the\n\tstatistics parameter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The stats pointer is marked as [[maybe_unused]]. This is a leftover from\na previous commit which was here to keep the compatibility while\ntransitioning to the new iterative algorithms.\n\nRemove this attribute to make it explicit that stats are really used to\nfeed the algorithms.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 177b67b0..bcaa34da 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -721,7 +721,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n */\n void IPAIPU3::parseStatistics(unsigned int frame,\n \t\t\t [[maybe_unused]] int64_t frameTimestamp,\n-\t\t\t [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n+\t\t\t const ipu3_uapi_stats_3a *stats)\n {\n \tControlList ctrls(controls::controls);\n \n", "prefixes": [ "libcamera-devel", "v5", "04/19" ] }