Patch Detail
Show a patch.
GET /api/patches/14335/?format=api
{ "id": 14335, "url": "https://patchwork.libcamera.org/api/patches/14335/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14335/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211026112340.110169-3-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-26T11:23:23", "name": "[libcamera-devel,v5,02/19] ipa: ipu3: Document IPAIPU3::configure", "commit_ref": "da0d5caa7fa33793454933419b33699dfa556518", "pull_url": null, "state": "accepted", "archived": false, "hash": "aa9264a0f15b5000c514d66f758cadc703dd5211", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14335/mbox/", "series": [ { "id": 2658, "url": "https://patchwork.libcamera.org/api/series/2658/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2658", "date": "2021-10-26T11:23:21", "name": "Document IPU3 IPA", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2658/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14335/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14335/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C99F9BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Oct 2021 11:23:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73F3C64893;\n\tTue, 26 Oct 2021 13:23:50 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDC1760128\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Oct 2021 13:23:44 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86C26E79;\n\tTue, 26 Oct 2021 13:23:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D91eJ6b4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635247424;\n\tbh=9IlK6IfsT9mGDzONJKZdJo9o+UAvYTzEOBJO5Hamang=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D91eJ6b4iqvfmHul03tL+M//lEfOPE8frtV5iyPb0cyy9O32logJW6a7I1GNTHZ1I\n\taW6T6sRYHm3OSBam/9or8mM+UaDdyU8FMpX6Hfgah4mcwt6IitHwTpDbZ7ctHoE9NJ\n\tHFSB7ni6nqI96uiOp/2x51WviFj9wBT1EpUzX4xk=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Oct 2021 13:23:23 +0200", "Message-Id": "<20211026112340.110169-3-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Further extend the documentation for the IPAIPU3::configure operation.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 9396926c..1f501821 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -506,6 +506,21 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n \t\t\t << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n }\n \n+/**\n+ * \\brief Configure the IPU3 IPA\n+ * \\param[in] configInfo The IPA configuration data, received from the pipeline\n+ * handler\n+ * \\param[in] ipaControls The IPA controls to update\n+ *\n+ * Calculate the best grid for the statistics based on the Pipeline Handler BDS\n+ * output, and parse the minimum and maximum exposure and analogue gain control\n+ * values.\n+ *\n+ * \\todo Document what the BDS is, ideally in a block diagram of the ImgU.\n+ *\n+ * All algorithm modules are called to allow them to prepare the\n+ * \\a IPASessionConfiguration structure for the \\a IPAContext.\n+ */\n int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \t\t ControlInfoMap *ipaControls)\n {\n", "prefixes": [ "libcamera-devel", "v5", "02/19" ] }