Patch Detail
Show a patch.
GET /api/patches/14132/?format=api
{ "id": 14132, "url": "https://patchwork.libcamera.org/api/patches/14132/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14132/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211014070533.3720964-3-hanlinchen@chromium.org>", "date": "2021-10-14T07:05:33", "name": "[libcamera-devel,v3,3/3] ipu3: Apply shading adapter as part of AIQ::run2a()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1fc76f057479bbfbe744bbb04d60e2409baef59b", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14132/mbox/", "series": [ { "id": 2624, "url": "https://patchwork.libcamera.org/api/series/2624/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2624", "date": "2021-10-14T07:05:31", "name": "[libcamera-devel,v3,1/3] ipu3: Remove the usage of SharedItemPool", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2624/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14132/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14132/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 117F9BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Oct 2021 07:05:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3DF868F54;\n\tThu, 14 Oct 2021 09:05:49 +0200 (CEST)", "from mail-pg1-x541.google.com (mail-pg1-x541.google.com\n\t[IPv6:2607:f8b0:4864:20::541])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A63168F54\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Oct 2021 09:05:48 +0200 (CEST)", "by mail-pg1-x541.google.com with SMTP id r2so4635480pgl.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Oct 2021 00:05:47 -0700 (PDT)", "from localhost ([2401:fa00:1:10:4dac:fd0c:fba7:b5ae])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\ty3sm1399766pfo.188.2021.10.14.00.05.44\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 14 Oct 2021 00:05:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LU/IuFT8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=CpFwya8vFkhHzBzR4WOewPCe3sJl5KgyNve3eOrJDAo=;\n\tb=LU/IuFT8nfB93avDYmQNj5ZisVZ+87+IzC3SC+Bhqju9TlsXkPIgXSwAJTBIP8iHz/\n\tklwhC9x+gVKpQ7ERhf0wyu4AhyR0gPVKSmbV29UIXsYhslnYw/ntCR0KkDKm6EaEUiM7\n\tmbhHmvS0960L+YAxL5qKP3JP2FXmM8jJ/qGWE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=CpFwya8vFkhHzBzR4WOewPCe3sJl5KgyNve3eOrJDAo=;\n\tb=rrDuCDK+G/+hA5RIJtKY8VIeVF2WKVJya2e6+yejokx48PhfrMgtiahVSA7B5EgpAx\n\tK/0pjsZ9KBP0vTQufk9Rr7VjV5Qg1RMHp7vsNxWlCfNsZPcLIHArnHtabRyghR5SVPo/\n\tpb/dE3SHo67+f7fY0r21BuIwZWPuutFUuJxWjEXVbUGl9ofh7Qsphi7S71chkQ3f7GDY\n\tnBAurHbPx9EFMGCIAK1nUDNW1XwWn8rheGjEe8lLR2AUbfJ+C3adlAekb6s91nex7pJw\n\t0biPodjQOgnRvzfm/5VWBypgHOB8BCB4Z/yhErMu/qOS8k/eTYrFxxxM+OteId8cQm9L\n\tXpBg==", "X-Gm-Message-State": "AOAM530+eyQPLid9cRtZ8dgJASwdt8MstiS5aInoEAnn41gtSkvQnA83\n\tELxY/iPxSEkv/xGKQE0Up9sxEOKtPl4FghNh", "X-Google-Smtp-Source": "ABdhPJwUhPPyZZaPerXpDPCkYATWr1jN7Cuil68m4BFxf+f97rTYLVxiK0AX/yh6kCvT7eCpALFUow==", "X-Received": "by 2002:a63:cf41:: with SMTP id b1mr2976484pgj.407.1634195145184;\n\tThu, 14 Oct 2021 00:05:45 -0700 (PDT)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 14 Oct 2021 15:05:33 +0800", "Message-Id": "<20211014070533.3720964-3-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.33.0.882.g93a45727a2-goog", "In-Reply-To": "<20211014070533.3720964-1-hanlinchen@chromium.org>", "References": "<20211014070533.3720964-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 3/3] ipu3: Apply shading adapter as\n\tpart of AIQ::run2a()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Populate shading adapter input parameters and run it as a part of\nrun2a() to correct lens shading for the camera.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n aiq/aiq.cpp | 3 +++\n aiq/aiq_input_parameters.cpp | 12 ++++++++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/aiq/aiq.cpp b/aiq/aiq.cpp\nindex 708e9d6..24c61cb 100644\n--- a/aiq/aiq.cpp\n+++ b/aiq/aiq.cpp\n@@ -154,6 +154,9 @@ int AIQ::run2a(unsigned int frame, AiqInputParameters ¶ms,\n \tparams.paParams.exposure_params = results.ae()->exposures[0].exposure;\n \tparameterAdapterRun(params.paParams, results);\n \n+\tparams.saParams.awb_results = results.awb();\n+\tshadingAdapterRun(params.saParams, results);\n+\n \tafRun(params.afParams, results);\n \n \treturn 0;\ndiff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\nindex 8a53849..36e2b07 100644\n--- a/aiq/aiq_input_parameters.cpp\n+++ b/aiq/aiq_input_parameters.cpp\n@@ -89,6 +89,15 @@ int AiqInputParameters::configure(const IPAConfigInfo &configInfo)\n \t/* Guess from hal-configs-nautilus/files/camera3_profiles.xml#263 */\n \tsensorDescriptor.coarse_integration_time_max_margin = 10;\n \n+\tsensorFrameParams.horizontal_crop_offset = 0;\n+\tsensorFrameParams.vertical_crop_offset = 0;\n+\tsensorFrameParams.cropped_image_width = configInfo.sensorInfo.analogCrop.width;\n+\tsensorFrameParams.cropped_image_height = configInfo.sensorInfo.analogCrop.height;\n+\tsensorFrameParams.horizontal_scaling_numerator = 1;\n+\tsensorFrameParams.horizontal_scaling_denominator = 1;\n+\tsensorFrameParams.vertical_scaling_numerator = 1;\n+\tsensorFrameParams.vertical_scaling_denominator = 1;\n+\n \treturn 0;\n }\n \n@@ -165,6 +174,9 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \tgbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n \tgbceParams.frame_use = ia_aiq_frame_use_still;\n \tgbceParams.ev_shift = 0;\n+\n+\t/* SA Params */\n+\tsaParams.frame_use = ia_aiq_frame_use_still;\n }\n \n } /* namespace ipa::ipu3::aiq */\n", "prefixes": [ "libcamera-devel", "v3", "3/3" ] }