Patch Detail
Show a patch.
GET /api/patches/14070/?format=api
{ "id": 14070, "url": "https://patchwork.libcamera.org/api/patches/14070/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14070/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211007093937.121357-1-umang.jain@ideasonboard.com>", "date": "2021-10-07T09:39:36", "name": "[libcamera-devel,1/2] android: mm: Null check for CameraBufferManager", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "587bc5b32af5105f877c7c9e1514128f1cb8507a", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14070/mbox/", "series": [ { "id": 2607, "url": "https://patchwork.libcamera.org/api/series/2607/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2607", "date": "2021-10-07T09:39:36", "name": "[libcamera-devel,1/2] android: mm: Null check for CameraBufferManager", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2607/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14070/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14070/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CAEDBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Oct 2021 09:39:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FE68691B9;\n\tThu, 7 Oct 2021 11:39:47 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC52F69189\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Oct 2021 11:39:46 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8266DDE;\n\tThu, 7 Oct 2021 11:39:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cvk36Mv9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633599586;\n\tbh=7aw5OjdueBFi74xC4ec818woSNWqy6Wp7mOAIPYG3D4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Cvk36Mv99sZSVex/oHu1NEmf3eM0Kd2fLjJwWpNajpqnSE/QsvwedGoLnc5F8nclK\n\tdZtONW+XcgvL6B+8FnEmdsDJw6qGauKrJxQxc5hbGfjqnHlKX5yWW1Hz1bTPZfFaGG\n\tU4W33PtBMfidPYi15g8kKsYtFnmGsa2J2s6ZfIRE=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Oct 2021 15:09:36 +0530", "Message-Id": "<20211007093937.121357-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] android: mm: Null check for\n\tCameraBufferManager", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "cros::CameraBufferManager can be nullptr if there is an error in\nits creation. Place a null-check guard to check it.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/mm/cros_camera_buffer.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\nindex 86770135..97a04c68 100644\n--- a/src/android/mm/cros_camera_buffer.cpp\n+++ b/src/android/mm/cros_camera_buffer.cpp\n@@ -60,6 +60,11 @@ CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,\n \t registered_(false)\n {\n \tbufferManager_ = cros::CameraBufferManager::GetInstance();\n+\tif (!bufferManager_) {\n+\t\tLOG(HAL, Error)\n+\t\t\t<< \"Failed to get cros CameraBufferManager instance\";\n+\t\treturn;\n+\t}\n \n \tint ret = bufferManager_->Register(camera3Buffer);\n \tif (ret) {\n", "prefixes": [ "libcamera-devel", "1/2" ] }