Patch Detail
Show a patch.
GET /api/patches/14053/?format=api
{ "id": 14053, "url": "https://patchwork.libcamera.org/api/patches/14053/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14053/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211005092757.747697-1-hiroh@chromium.org>", "date": "2021-10-05T09:27:57", "name": "[libcamera-devel] android: camera_stream: Set right format for processor output buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "189354a2b1efb2ce265a787a99d4d0996717c28c", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14053/mbox/", "series": [ { "id": 2604, "url": "https://patchwork.libcamera.org/api/series/2604/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2604", "date": "2021-10-05T09:27:57", "name": "[libcamera-devel] android: camera_stream: Set right format for processor output buffer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2604/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14053/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14053/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A685ABDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Oct 2021 09:28:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20187691AD;\n\tTue, 5 Oct 2021 11:28:06 +0200 (CEST)", "from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com\n\t[IPv6:2607:f8b0:4864:20::102a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B437A684C6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Oct 2021 11:28:04 +0200 (CEST)", "by mail-pj1-x102a.google.com with SMTP id v19so13642578pjh.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 05 Oct 2021 02:28:04 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:debc:d0db:3bd8:f961])\n\tby smtp.gmail.com with ESMTPSA id\n\tm73sm4997371pfd.152.2021.10.05.02.28.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Oct 2021 02:28:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"XBx3ekWK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=lHmCOb9LDaBb1gevUX7WH5ZVRnHula99IDaQfH6pz30=;\n\tb=XBx3ekWKe3cVyOieumxiv+8v6Roo7B3hfMFJKiV8Vezo7JFLTiggk/1NbJhFqiVlY9\n\tDKh6amadj/nkg73O2nQjM147yKD98ZCgKo75FTdhBEQo55JKgOenJ7HfUwATcNBC6PbZ\n\twSuDq3xv+MqCcC0qe91mCMbkJ1br4ISnIVxhU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=lHmCOb9LDaBb1gevUX7WH5ZVRnHula99IDaQfH6pz30=;\n\tb=NpG1woo68egdFiIPr98H94rhP50f8CEf3GnTbZei4k1k+xEOBc1U1xkDeo1WQBqLyZ\n\tQCJwPCQGa1fvo//AaBj1zUL85jOSzhY1URkpmf8pj5F6bPD38tOCq+mQvaMsz8+tm96c\n\tPoSzLG+Ffa6YKvTGy1eLPRqmtmX+YOkRLQMqKSvug2ll6nzCtA8qfOtU86sOV8MUhbfe\n\t6UTR/pSNGvFiX53/6gBr8kp60bCNe1LlfjS6I069KBJ7fkyBOvhO/Kb2vvZGqoRPx+8q\n\tFkLraf0ebZv0l01SA2VJdmS/a1Ufo0E+LHeBbP2U5EiOleZrKhC/vJHa7NjvVzm1ugSS\n\thTVQ==", "X-Gm-Message-State": "AOAM533w1gnumN3oTTyJUhoa5R34ifQUibALkf9l4gUk3tHJYBBDufdg\n\t7pWf6p8z+nFB/Y/angNe+sBUIw/cgdGZjQ==", "X-Google-Smtp-Source": "ABdhPJzCTVLADNKncW3LBJm0qvpaowPT/IXo5sWhhFjrz7nCv1WITHnyQTAEdSGZ2jznnfkVdKk0IQ==", "X-Received": "by 2002:a17:90a:2ecb:: with SMTP id\n\th11mr2577797pjs.196.1633426082889; \n\tTue, 05 Oct 2021 02:28:02 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Oct 2021 18:27:57 +0900", "Message-Id": "<20211005092757.747697-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.800.g4c38ced690-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: camera_stream: Set right format\n\tfor processor output buffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "CameraStream always sets the format of processor output buffer to\nMJPEG. This fixes the issue.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_stream.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex e80f842d..db8d854b 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -168,7 +168,7 @@ int CameraStream::process(const FrameBuffer &source,\n \t * separate thread.\n \t */\n \tconst StreamConfiguration &output = configuration();\n-\tCameraBuffer dest(*camera3Dest.buffer, formats::MJPEG, output.size,\n+\tCameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,\n \t\t\t PROT_READ | PROT_WRITE);\n \tif (!dest.isValid()) {\n \t\tLOG(HAL, Error) << \"Failed to map android blob buffer\";\n", "prefixes": [ "libcamera-devel" ] }