Patch Detail
Show a patch.
GET /api/patches/14023/?format=api
{ "id": 14023, "url": "https://patchwork.libcamera.org/api/patches/14023/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14023/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211001161100.1405576-2-javierm@redhat.com>", "date": "2021-10-01T16:11:00", "name": "[libcamera-devel,2/2] android: Check if Stream configurations were generated correctly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d75d2459ed8dffe6858d8c440ff2aeaf933f8448", "submitter": { "id": 95, "url": "https://patchwork.libcamera.org/api/people/95/?format=api", "name": "Javier Martinez Canillas", "email": "javierm@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14023/mbox/", "series": [ { "id": 2590, "url": "https://patchwork.libcamera.org/api/series/2590/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2590", "date": "2021-10-01T16:11:00", "name": "[libcamera-devel,1/2] gstreamer: Check if Stream configurations were generated correctly", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2590/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14023/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14023/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DFC2BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Oct 2021 16:11:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E756A691AA;\n\tFri, 1 Oct 2021 18:11:54 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9BFB691A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Oct 2021 18:11:52 +0200 (CEST)", "from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-222-x8j_VlM1MSyUlzed_pZhqA-1; Fri, 01 Oct 2021 12:11:50 -0400", "by mail-wr1-f69.google.com with SMTP id\n\tn18-20020adff092000000b001609d9081d4so35322wro.18\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 01 Oct 2021 09:11:50 -0700 (PDT)", "from minerva.redhat.com ([92.176.231.106])\n\tby smtp.gmail.com with ESMTPSA id\n\td3sm7138164wrb.36.2021.10.01.09.11.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 01 Oct 2021 09:11:48 -0700 (PDT)" ], "Authentication-Results": [ "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"V6gCh1ZL\"; dkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1633104711;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tj5sUBYDfX3+O1p+bYWOYtIHbUEPbnnKj4O1RM+2HTw=;\n\tb=V6gCh1ZLjVNcrw1PTaCD89yi75yazrqEVQAVYE3in3Ww8/hMuFEwDzH5ssqWZkl/5AlbIA\n\tNP5twsqL7rkIbavBeabj8rGKxrWqUNPKVA8en1dnhjqVPGqkFqNtwxVDTI6BuN+LvLwYOQ\n\tkaiEfLGuCubjCro0lQEGPjurWO6fYHg=", "X-MC-Unique": "x8j_VlM1MSyUlzed_pZhqA-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=tj5sUBYDfX3+O1p+bYWOYtIHbUEPbnnKj4O1RM+2HTw=;\n\tb=4iBACdQG5Am+HY89XloSeJPIvyb+ZctFghCeE2zzPIKoAzjsMLeX/iD1UwHBrceOrC\n\twUlsNfUhYqOMV4yQqjAERZJq5toj6hXJKe/t6sdiLWCYwMgTsIo6PkF/Oa9KYM8ryeHF\n\t3Hwn2IDDfHFu59aNDqGwNk/9a4seW9SOmPRzyIhrQLl4x/MV44e8sHdxAR9KEdblun/6\n\taljIJaPi6ArljoOBRwfNEXZeRExpnRFpPde7OGRjgqUJ8TjDjEHLPp6FENAY/JfVNrqU\n\tfNDGomwBdYwwwFKTX6OXRDv/IXQ1ItC39reQgdDXFxMHXQd0xooXUdkpTsb+WhvboBKE\n\tWAjQ==", "X-Gm-Message-State": "AOAM530lcpDWYhM3KKYqfi0f186o8KzLAyUiWju7U4d+8QgiMRG4xQS/\n\tUK/YaaoWN5VbWZ+fX3ofIYgXjAVEA188R6U/cGA/jruknE3ux+9sohgYtcFwPYhQIADzN+CKMPu\n\tYKmNJvEXNudxN4UXOX5x0RJxxUbH/mwvtmfUJbfkk5WQRWs3cIivv2xuHO5UH/b5fZIBF1cWNIC\n\tcBGQ81DEtn", "X-Received": [ "by 2002:a1c:8088:: with SMTP id\n\tb130mr5473176wmd.36.1633104709052; \n\tFri, 01 Oct 2021 09:11:49 -0700 (PDT)", "by 2002:a1c:8088:: with SMTP id\n\tb130mr5473132wmd.36.1633104708669; \n\tFri, 01 Oct 2021 09:11:48 -0700 (PDT)" ], "X-Google-Smtp-Source": "ABdhPJxQQzL1Xs0JXW4Xx/NSk20DEAcyq2jds+Q/NJ43f1psx8VQOOZjRjfzyiTBcOIi90ylXbRNYg==", "From": "Javier Martinez Canillas <javierm@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Oct 2021 18:11:00 +0200", "Message-Id": "<20211001161100.1405576-2-javierm@redhat.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211001161100.1405576-1-javierm@redhat.com>", "References": "<20211001161100.1405576-1-javierm@redhat.com>", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[libcamera-devel] [PATCH 2/2] android: Check if Stream\n\tconfigurations were generated correctly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera Android Camera HAL generates camera configurations for the\nStillCapture, Raw and ViewFinder stream roles. But it's only checked for\nthe first one if the function succeeded.\n\nThis could lead to a NULL pointer deference if a pipeline handler failed\nto generate a default configuration for one the other two stream roles.\n\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>\n---\n\n src/android/camera_capabilities.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 87a6e1c6f26..baeedc11500 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -408,6 +408,11 @@ CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n \tstd::vector<Size> supportedResolutions;\n \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n \t\tcamera_->generateConfiguration({ StreamRole::Viewfinder });\n+\tif (!cameraConfig) {\n+\t\tLOG(HAL, Error) << \"Failed to get supported YUV resolutions\";\n+\t\treturn supportedResolutions;\n+\t}\n+\n \tStreamConfiguration &cfg = cameraConfig->at(0);\n \n \tfor (const Size &res : resolutions) {\n@@ -431,11 +436,17 @@ CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n std::vector<Size>\n CameraCapabilities::initializeRawResolutions(const PixelFormat &pixelFormat)\n {\n+\tstd::vector<Size> supportedResolutions;\n \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n+\tif (!cameraConfig) {\n+\t\tLOG(HAL, Error) << \"Failed to get supported Raw resolutions\";\n+\t\treturn supportedResolutions;\n+\t}\n+\n \tStreamConfiguration &cfg = cameraConfig->at(0);\n \tconst StreamFormats &formats = cfg.formats();\n-\tstd::vector<Size> supportedResolutions = formats.sizes(pixelFormat);\n+\tsupportedResolutions = formats.sizes(pixelFormat);\n \n \treturn supportedResolutions;\n }\n", "prefixes": [ "libcamera-devel", "2/2" ] }