Patch Detail
Show a patch.
GET /api/patches/13981/?format=api
{ "id": 13981, "url": "https://patchwork.libcamera.org/api/patches/13981/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13981/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210929133030.401961-4-umang.jain@ideasonboard.com>", "date": "2021-09-29T13:30:29", "name": "[libcamera-devel,v4,3/4] android: camera_device: Mark abortRequest() and notifyError() as const", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ef58153b75625ea228e2f896f3b99efb679547ad", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13981/mbox/", "series": [ { "id": 2586, "url": "https://patchwork.libcamera.org/api/series/2586/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2586", "date": "2021-09-29T13:30:26", "name": "Camera3RequestDescriptors std::map => std::queue", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2586/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13981/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13981/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C766C3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 Sep 2021 13:30:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D439E691B7;\n\tWed, 29 Sep 2021 15:30:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB94A691A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Sep 2021 15:30:44 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFA4F3F0;\n\tWed, 29 Sep 2021 15:30:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Tr6nGDQD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632922244;\n\tbh=HF2RWqvIo4vAjF6D7HhHAwYGz2JFm7Rf7UHkRkaVYUo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Tr6nGDQDg3h8m5cQl/sQRLeMwMHJIB4FWHxz9DU4YBdxRc6Kw4uFYaClHjapDgRRw\n\tugvFuzAGHrfftBWXAznxGvOFLoR6hepnKuKusE8juSM2owf9qSlyAOafLCSKQ8Sz/c\n\tknovSIVABalUmhB8Oe+vFjA8uqEZ7nSxiOpJIcak=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 29 Sep 2021 19:00:29 +0530", "Message-Id": "<20210929133030.401961-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210929133030.401961-1-umang.jain@ideasonboard.com>", "References": "<20210929133030.401961-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark\n\tabortRequest() and notifyError() as const", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "abortRequest() and notifyError() do not access any members of\nCameraDevice hence, these functions can be const.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_device.cpp | 4 ++--\n src/android/camera_device.h | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex e815f7a0..45350563 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n \treturn 0;\n }\n \n-void CameraDevice::abortRequest(camera3_capture_request_t *request)\n+void CameraDevice::abortRequest(camera3_capture_request_t *request) const\n {\n \tnotifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST);\n \n@@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)\n }\n \n void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n-\t\t\t camera3_error_msg_code code)\n+\t\t\t camera3_error_msg_code code) const\n {\n \tcamera3_notify_msg_t notify = {};\n \ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 9ec510d5..85497921 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -99,11 +99,11 @@ private:\n \tcreateFrameBuffer(const buffer_handle_t camera3buffer,\n \t\t\t libcamera::PixelFormat pixelFormat,\n \t\t\t const libcamera::Size &size);\n-\tvoid abortRequest(camera3_capture_request_t *request);\n+\tvoid abortRequest(camera3_capture_request_t *request) const;\n \tbool isValidRequest(camera3_capture_request_t *request) const;\n \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream,\n-\t\t\t camera3_error_msg_code code);\n+\t\t\t camera3_error_msg_code code) const;\n \tint processControls(Camera3RequestDescriptor *descriptor);\n \tstd::unique_ptr<CameraMetadata> getResultMetadata(\n \t\tconst Camera3RequestDescriptor &descriptor) const;\n", "prefixes": [ "libcamera-devel", "v4", "3/4" ] }