Patch Detail
Show a patch.
GET /api/patches/13955/?format=api
{ "id": 13955, "url": "https://patchwork.libcamera.org/api/patches/13955/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13955/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210927211933.25088-1-laurent.pinchart@ideasonboard.com>", "date": "2021-09-27T21:19:33", "name": "[libcamera-devel] libcamera: control_serializer: Fix usage of uninitialized variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f4676ac4b25c905de314653bdb9efef96d485a50", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13955/mbox/", "series": [ { "id": 2576, "url": "https://patchwork.libcamera.org/api/series/2576/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2576", "date": "2021-09-27T21:19:33", "name": "[libcamera-devel] libcamera: control_serializer: Fix usage of uninitialized variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2576/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13955/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13955/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54471BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Sep 2021 21:19:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C582D69189;\n\tMon, 27 Sep 2021 23:19:47 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DDC86012C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Sep 2021 23:19:46 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DFAA1224; \n\tMon, 27 Sep 2021 23:19:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DuWYybP9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632777585;\n\tbh=MIST+CRsLPUpbX0iXi3OZwufk6rL2yK7v9+62Ff6FIs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DuWYybP9Mz/JN2q/z5GJYc5vxnfnDaCUM0w3++I2vVZcn7d3pysYQVN48QMlCMUJf\n\tfNYjFjSdrxZh0czOd8dERHE/DNnEjiEKg2UASdr/SAcgrWJnvG21rGddWH8Ya5uUv3\n\thrkRae9lrhnxHGkGNUBVV/H5OuOLndiuBAv9JXjM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 28 Sep 2021 00:19:33 +0300", "Message-Id": "<20210927211933.25088-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: control_serializer: Fix usage\n\tof uninitialized variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The idMap variable may be used uninitialized in the\nControlSerializer::deserialize<ControlList>() function as reported by\ngcc 11:\n\n../../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlList]’:\n../../src/libcamera/control_serializer.cpp:609:33: error: ‘idMap’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n 609 | ControlList ctrls(*idMap);\n |\n\nThis is due to a missing default case in a switch/case. Fix it by adding\nthe default case.\n\nFixes: 6b1404fc4836 (\"libcamera: control_serializer: Fix usage of uninitialized variable\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/control_serializer.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: 957c5d534b42e05520de82f27b2204fa864d511a", "diff": "diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex 77b77448d61d..e87d23625ed2 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -594,6 +594,7 @@ ControlList ControlSerializer::deserialize<ControlList>(ByteStreamBuffer &buffer\n \t\t\tbreak;\n \n \t\tcase IPA_CONTROL_ID_MAP_V4L2:\n+\t\tdefault:\n \t\t\tLOG(Serializer, Fatal)\n \t\t\t\t<< \"A list of V4L2 controls requires an ControlInfoMap\";\n \t\t\treturn {};\n", "prefixes": [ "libcamera-devel" ] }