Patch Detail
Show a patch.
GET /api/patches/13898/?format=api
{ "id": 13898, "url": "https://patchwork.libcamera.org/api/patches/13898/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13898/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210923081625.60276-11-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-23T08:16:23", "name": "[libcamera-devel,10/12] ipa: ipu3: awb: Introduce Black Level Correction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4750d7e63c9bdf54cccada21a52d22291e1ce864", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13898/mbox/", "series": [ { "id": 2548, "url": "https://patchwork.libcamera.org/api/series/2548/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2548", "date": "2021-09-23T08:16:13", "name": "Improve ImgU statistics usage", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2548/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13898/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13898/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCF3ABF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Sep 2021 08:16:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8385169196;\n\tThu, 23 Sep 2021 10:16:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DBCA69192\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Sep 2021 10:16:32 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:392e:dcd2:2bf6:d61c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E634F58B;\n\tThu, 23 Sep 2021 10:16:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K4QAN99A\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632384992;\n\tbh=l94U206NID2X5uCMnUbaxmD/PKuabaMt8jDu+Ul/5m4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=K4QAN99ASFeZaBX0qeTQL++w5W+49tTpbeKz5aS9rtq3qJ4NNyIMkyQu1xRSPJvoQ\n\ttSVcoP7MgJ1kMz0gnulj5ARTpKmDc4G7bn4w7OSwuOEUN3OCpKkIMVtpc+uhkOajuw\n\tn9BBWWwuXndIpkxZ3ho3+i4tP65+5LqxAnhhhJEA=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Sep 2021 10:16:23 +0200", "Message-Id": "<20210923081625.60276-11-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210923081625.60276-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210923081625.60276-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 10/12] ipa: ipu3: awb: Introduce Black\n\tLevel Correction", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pixels output by the camera normally include a black level, because\nsensors do not always report a signal level of '0' for black. Pixels at\nor below this level should be considered black and to achieve that, we\nneed to substract an offset to all the pixels. This can be taken into\naccount by reading the lowest value of a special region on sensors which\nis not exposed to the lens. This provides a substracting factor to be\nable to adjust the expected black levels in the resultant images.\n\nFor a camera outputting 10-bit pixel values (in the range 0 to 1023) a\ntypical black level might be 64. It is a fixed value, obtained by\ncapturing a raw frame with minimum exposure and gain fixed to 1.0 while\ncovering the sensor (the darker the better). We consider it good enough\nas a very first approximation, until we measure it during a tuning\nprocess and include it in a configuration file\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex a5391653..3013870b 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -388,9 +388,17 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n \t/* The CCM matrix may change when color temperature will be used */\n \tparams->acc_param.ccm = imguCssCcmDefault;\n \n+\t/* The Optical Black Level correction values */\n+\tparams->obgrid_param.gr = 64;\n+\tparams->obgrid_param.r = 64;\n+\tparams->obgrid_param.b = 64;\n+\tparams->obgrid_param.gb = 64;\n+\n \tparams->use.acc_awb = 1;\n \tparams->use.acc_bnr = 1;\n \tparams->use.acc_ccm = 1;\n+\tparams->use.obgrid = 1;\n+\tparams->use.obgrid_param = 1;\n }\n \n } /* namespace ipa::ipu3::algorithms */\n", "prefixes": [ "libcamera-devel", "10/12" ] }