Patch Detail
Show a patch.
GET /api/patches/13894/?format=api
{ "id": 13894, "url": "https://patchwork.libcamera.org/api/patches/13894/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13894/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210923081625.60276-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-23T08:16:16", "name": "[libcamera-devel,03/12] ipa: ipu3: Change Accumulator structure layout", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f7b9ddfe9fdf1f24d86e2611be2355043f6efc2", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13894/mbox/", "series": [ { "id": 2548, "url": "https://patchwork.libcamera.org/api/series/2548/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2548", "date": "2021-09-23T08:16:13", "name": "Improve ImgU statistics usage", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2548/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13894/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13894/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42A70BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Sep 2021 08:16:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E5D36918D;\n\tThu, 23 Sep 2021 10:16:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0DD3687DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Sep 2021 10:16:30 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:392e:dcd2:2bf6:d61c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87A0645E;\n\tThu, 23 Sep 2021 10:16:30 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p3uAO2Ar\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632384990;\n\tbh=h7LU+pzmjJNo6QGA2NemyFreZybReJjSpq3dRpvEcAE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p3uAO2ArrKktUbYM8Ea6WauR/D9qfBkDJ9l1raO8lK7t5FF3v2jqYmNeebH6X3ECK\n\t07pCnRuvpqG0YK6GPpRPbaJXaqxICwaChG2qEUfNFt0+xT7hgLBXmtBINrUWVpE0td\n\thzh/VjEHz3zEvmGrPxkkTeW1vPLjg1oTDjexjX2c=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Sep 2021 10:16:16 +0200", "Message-Id": "<20210923081625.60276-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210923081625.60276-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210923081625.60276-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/12] ipa: ipu3: Change Accumulator\n\tstructure layout", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pixel component sums for the Accumulator are inconsistent with other\nsimilar structures such as the IPAFrameContext::awb::gains. Group the\nred, green, and blue sums together in a struct and store them as\nuint64_t to reduce potential architectural differences.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 24 ++++++++++++------------\n src/ipa/ipu3/algorithms/awb.h | 8 +++++---\n 2 files changed, 17 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex d780a085..d78ae4f4 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -75,13 +75,13 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n * \\var Accumulator::counted\n * \\brief Number of unsaturated cells used to calculate the sums\n *\n- * \\var Accumulator::rSum\n+ * \\var Accumulator::sum::red\n * \\brief Sum of the average red values of each unsaturated cell in the zone\n *\n- * \\var Accumulator::gSum\n+ * \\var Accumulator::sum::green\n * \\brief Sum of the average green values of each unsaturated cell in the zone\n *\n- * \\var Accumulator::bSum\n+ * \\var Accumulator::sum::blue\n * \\brief Sum of the average blue values of each unsaturated cell in the zone\n */\n \n@@ -206,10 +206,10 @@ void Awb::generateZones(std::vector<RGB> &zones)\n \t\tRGB zone;\n \t\tdouble counted = awbStats_[i].counted;\n \t\tif (counted >= kMinZonesCounted) {\n-\t\t\tzone.G = awbStats_[i].gSum / counted;\n+\t\t\tzone.G = awbStats_[i].sum.green / counted;\n \t\t\tif (zone.G >= kMinGreenLevelInZone) {\n-\t\t\t\tzone.R = awbStats_[i].rSum / counted;\n-\t\t\t\tzone.B = awbStats_[i].bSum / counted;\n+\t\t\t\tzone.R = awbStats_[i].sum.red / counted;\n+\t\t\t\tzone.B = awbStats_[i].sum.blue / counted;\n \t\t\t\tzones.push_back(zone);\n \t\t\t}\n \t\t}\n@@ -242,9 +242,9 @@ void Awb::generateAwbStats(const ipu3_uapi_stats_3a *stats,\n \t\t\t\t/* The cell is not saturated, use the current cell */\n \t\t\t\tawbStats_[awbRegionPosition].counted++;\n \t\t\t\tuint32_t greenValue = currentCell->greenRedAvg + currentCell->greenBlueAvg;\n-\t\t\t\tawbStats_[awbRegionPosition].gSum += greenValue / 2;\n-\t\t\t\tawbStats_[awbRegionPosition].rSum += currentCell->redAvg;\n-\t\t\t\tawbStats_[awbRegionPosition].bSum += currentCell->blueAvg;\n+\t\t\t\tawbStats_[awbRegionPosition].sum.green += greenValue / 2;\n+\t\t\t\tawbStats_[awbRegionPosition].sum.red += currentCell->redAvg;\n+\t\t\t\tawbStats_[awbRegionPosition].sum.blue += currentCell->blueAvg;\n \t\t\t}\n \t\t}\n \t}\n@@ -253,9 +253,9 @@ void Awb::generateAwbStats(const ipu3_uapi_stats_3a *stats,\n void Awb::clearAwbStats()\n {\n \tfor (unsigned int i = 0; i < kAwbStatsSizeX * kAwbStatsSizeY; i++) {\n-\t\tawbStats_[i].bSum = 0;\n-\t\tawbStats_[i].rSum = 0;\n-\t\tawbStats_[i].gSum = 0;\n+\t\tawbStats_[i].sum.blue = 0;\n+\t\tawbStats_[i].sum.red = 0;\n+\t\tawbStats_[i].sum.green = 0;\n \t\tawbStats_[i].counted = 0;\n \t}\n }\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex ac8ccc84..3385ebe7 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -35,9 +35,11 @@ struct Ipu3AwbCell {\n \n struct Accumulator {\n \tunsigned int counted;\n-\tunsigned long long rSum;\n-\tunsigned long long gSum;\n-\tunsigned long long bSum;\n+\tstruct {\n+\t\tuint64_t red;\n+\t\tuint64_t green;\n+\t\tuint64_t blue;\n+\t} sum;\n };\n \n class Awb : public Algorithm\n", "prefixes": [ "libcamera-devel", "03/12" ] }