Patch Detail
Show a patch.
GET /api/patches/13889/?format=api
{ "id": 13889, "url": "https://patchwork.libcamera.org/api/patches/13889/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13889/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210923072453.130346-2-umang.jain@ideasonboard.com>", "date": "2021-09-23T07:24:52", "name": "[libcamera-devel,v3,1/2] android: camera_capabilities: Clarify CameraMetadata allocation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6ae6e408fbaea6a1a397e80617074225d148417b", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13889/mbox/", "series": [ { "id": 2547, "url": "https://patchwork.libcamera.org/api/series/2547/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2547", "date": "2021-09-23T07:24:51", "name": "android: Fix generation of thumbnail for EXIF data", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2547/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13889/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13889/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 069B8BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Sep 2021 07:25:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9875169190;\n\tThu, 23 Sep 2021 09:25:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D66E69188\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Sep 2021 09:25:02 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7254945E;\n\tThu, 23 Sep 2021 09:25:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lxszN7Uy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632381902;\n\tbh=tHW+nFnwVUWK6az7ucJr8R0fqyXvpuiZHijvIBuJkkQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lxszN7Uy+EuUVpCfdJmdzLGBuNi2dBSpN2ikFRK7C2IkB1jFKwaJa9vbrlY3djOlH\n\tmAgPB+vHa0/1GttkJUgspMQAVe8JbGS+LKPlNUCX7nwy7hmY5L26PPDFA1+Z5d170h\n\t/imBorj5cm4HkPX4Ui0DgYuc7SMbVDfcdbx/I5nQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Sep 2021 12:54:52 +0530", "Message-Id": "<20210923072453.130346-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210923072453.130346-1-umang.jain@ideasonboard.com>", "References": "<20210923072453.130346-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/2] android: camera_capabilities:\n\tClarify CameraMetadata allocation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "CameraMetadata's constructor take in number of entries and number of\nbytes to be allocated for those entries. However, CameraMetadata is\nalready capable of resizing its container on the fly, in case more\nentries are added to it. Hence, the numbers passed in during the\nconstruction acts as hint values for initialization.\n\nClarify this in CameraCapabilities::requestTemplatePreview() and\nremove the \\todo, as the arguments and the \\todo gives the perspective\nthat we need to be quite accurate with the numbers of entries / bytes,\nwhich is not the case.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex e92bca42..238b44db 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1340,8 +1340,12 @@ std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplateManual() cons\n std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplatePreview() const\n {\n \t/*\n-\t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 20 entries, 35 bytes\n+\t * Give initial hint of entries and number of bytes to be allocated.\n+\t * It is deliberate that the hint is slightly larger than required, to\n+\t * avoid resizing the container.\n+\t *\n+\t * CameraMetadata is capable to resize the container on the fly, if the\n+\t * number of entries get exceeded.\n \t */\n \tauto requestTemplate = std::make_unique<CameraMetadata>(21, 36);\n \tif (!requestTemplate->isValid()) {\n", "prefixes": [ "libcamera-devel", "v3", "1/2" ] }