Patch Detail
Show a patch.
GET /api/patches/13878/?format=api
{ "id": 13878, "url": "https://patchwork.libcamera.org/api/patches/13878/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13878/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210921153515.2785148-1-kieran.bingham@ideasonboard.com>", "date": "2021-09-21T15:35:15", "name": "[libcamera-devel] gstreamer: Support planar formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e93c2ba6c31797d2e65201232d121535c0194bdb", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13878/mbox/", "series": [ { "id": 2541, "url": "https://patchwork.libcamera.org/api/series/2541/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2541", "date": "2021-09-21T15:35:15", "name": "[libcamera-devel] gstreamer: Support planar formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2541/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13878/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13878/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C47CBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Sep 2021 15:35:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF9E86918A;\n\tTue, 21 Sep 2021 17:35:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09BD260247\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Sep 2021 17:35:19 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97DB945E;\n\tTue, 21 Sep 2021 17:35:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ao7XXQQd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632238518;\n\tbh=XHMpukn1jhO7jiuSs60lHw/XarT3AJd5ruvL7j99ppU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Ao7XXQQdyvYslpMnvMzp3NsoECR0a9DgSAYeAoQUpBM910YuYkbyj/CCpGejMm3rW\n\tpKM2OT7WDm5i9XFucK1g/lHT3JwZ1u8jo3IfFwzYrS3w7wJX/1vX2qV4EUgKfVFbGZ\n\teQMy70HlUUjF9K1r22tlq9VkSM/tJzWxUwotBLks=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 21 Sep 2021 16:35:15 +0100", "Message-Id": "<20210921153515.2785148-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] gstreamer: Support planar formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Existing pipeline handlers already support planar YUV formats.\nExtend the gstreamer format map to incorporate them.\n\nWhile here, split the formats into distinct groups.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 0af91c1acb67..5636f3e7e1a6 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -16,19 +16,32 @@ static struct {\n \tGstVideoFormat gst_format;\n \tPixelFormat format;\n } format_map[] = {\n+\t/* Compressed */\n \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n+\n+\t/* RGB */\n \t{ GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n \t{ GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n \t{ GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n+\n+\t/* YUV Semiplanar */\n \t{ GST_VIDEO_FORMAT_NV12, formats::NV12 },\n \t{ GST_VIDEO_FORMAT_NV21, formats::NV21 },\n \t{ GST_VIDEO_FORMAT_NV16, formats::NV16 },\n \t{ GST_VIDEO_FORMAT_NV61, formats::NV61 },\n \t{ GST_VIDEO_FORMAT_NV24, formats::NV24 },\n+\n+\t/* YUV Packed */\n \t{ GST_VIDEO_FORMAT_UYVY, formats::UYVY },\n \t{ GST_VIDEO_FORMAT_VYUY, formats::VYUY },\n \t{ GST_VIDEO_FORMAT_YUY2, formats::YUYV },\n \t{ GST_VIDEO_FORMAT_YVYU, formats::YVYU },\n+\n+\t/* Planar Formats */\n+\t{ GST_VIDEO_FORMAT_I420, formats::YUV420 },\n+\t{ GST_VIDEO_FORMAT_YV12, formats::YVU420 },\n+\t{ GST_VIDEO_FORMAT_Y42B, formats::YUV422 },\n+\n \t/* \\todo NV42 is used in libcamera but is not mapped in GStreamer yet. */\n };\n \n", "prefixes": [ "libcamera-devel" ] }