Patch Detail
Show a patch.
GET /api/patches/13836/?format=api
{ "id": 13836, "url": "https://patchwork.libcamera.org/api/patches/13836/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13836/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210913145810.66515-9-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-13T14:58:07", "name": "[libcamera-devel,08/11] ipa: ipu3: agc: Remove unused variable count", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "af91765030d2da3fd1fad91e300ad95aba1883e0", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13836/mbox/", "series": [ { "id": 2523, "url": "https://patchwork.libcamera.org/api/series/2523/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2523", "date": "2021-09-13T14:57:59", "name": "Document all the IPU3 IPA classes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2523/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13836/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13836/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1F9EBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Sep 2021 14:58:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD0B069194;\n\tMon, 13 Sep 2021 16:58:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90E896024C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Sep 2021 16:58:15 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:edc5:688b:2ede:8b4b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B85C499;\n\tMon, 13 Sep 2021 16:58:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YIYc2/ZU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631545095;\n\tbh=qPlf4t0ZOVRRshTPLFOUUIu8JCdGeeaipQGmrQy6nn4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YIYc2/ZUhZBcCrrXF0ulhPvoQidDogzJ1MxsMnhtsTZ421htwvl5Y3dF24rHiaScI\n\tcP6vNa6ZNKD6RpDu/a4mCeumoxgclF6fdtE+JSDahJPVIF4EK4qt2gbN3TawONOPwQ\n\twqN8MkP3bdAmqtRgfkuWceDroCo9HbfOmxWWgd28=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Sep 2021 16:58:07 +0200", "Message-Id": "<20210913145810.66515-9-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 08/11] ipa: ipu3: agc: Remove unused\n\tvariable count", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When processing brightness, a local variable is incremented at each\nloop. There is no need for it, so remove it.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex e085599a..2ef998b7 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -84,7 +84,6 @@ void Agc::processBrightness(const ipu3_uapi_stats_3a *stats,\n \tuint32_t startY = topleftY * grid.width << grid.block_width_log2;\n \tuint32_t endX = (startX + (aeRegion.size().width >> grid.block_width_log2)) << grid.block_width_log2;\n \tuint32_t i, j;\n-\tuint32_t count = 0;\n \n \tuint32_t hist[knumHistogramBins] = { 0 };\n \tfor (j = topleftY;\n@@ -101,7 +100,6 @@ void Agc::processBrightness(const ipu3_uapi_stats_3a *stats,\n \t\t\t\tuint8_t Gr = currentCell->Gr_avg;\n \t\t\t\tuint8_t Gb = currentCell->Gb_avg;\n \t\t\t\thist[(Gr + Gb) / 2]++;\n-\t\t\t\tcount++;\n \t\t\t}\n \t\t}\n \t}\n", "prefixes": [ "libcamera-devel", "08/11" ] }