Patch Detail
Show a patch.
GET /api/patches/13835/?format=api
{ "id": 13835, "url": "https://patchwork.libcamera.org/api/patches/13835/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13835/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210913145810.66515-8-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-13T14:58:06", "name": "[libcamera-devel,07/11] ipu3: ipa: agc: Determine cell size from ipu3_uapi_awb_set_item", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "8f61cf961df541548d8ebd8a753d50a23e307e3b", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13835/mbox/", "series": [ { "id": 2523, "url": "https://patchwork.libcamera.org/api/series/2523/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2523", "date": "2021-09-13T14:57:59", "name": "Document all the IPU3 IPA classes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2523/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13835/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13835/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99560BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Sep 2021 14:58:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67F2A6919D;\n\tMon, 13 Sep 2021 16:58:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61A8269184\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Sep 2021 16:58:15 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:edc5:688b:2ede:8b4b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BB34B2B;\n\tMon, 13 Sep 2021 16:58:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DB48oslx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631545095;\n\tbh=D1/r6bOWaxa0Aed+GRFPuZVR/7tTNArW0YQN15hDMTU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DB48oslxSEZ2nhgi16IehB32OzkHAFUIXRn3eG87uqpSdF/Ro60WBTPvItQfd93G7\n\tg17p/IpPkJCyEDxnhVgS5smAzr0I/NjKw6NlqTwTVCvnXlP7OZ7AzEgYrmflAilRLR\n\twRnJWIDhvBrYroLa75OdZo1mkG1qfzkVr1w1pwjI=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Sep 2021 16:58:06 +0200", "Message-Id": "<20210913145810.66515-8-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 07/11] ipu3: ipa: agc: Determine cell size\n\tfrom ipu3_uapi_awb_set_item", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The kCellSize was hardcoded from the size determined by examining the\nstatistics from the ImgU. The cell definition is now described as a\nstruct. Utilise the struct size to express the cell size.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 8740dcdf..e085599a 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -48,7 +48,7 @@ static constexpr uint32_t knumHistogramBins = 256;\n static constexpr double kEvGainTarget = 0.5;\n \n /* A cell is 8 bytes and contains averages for RGB values and saturation ratio */\n-static constexpr uint8_t kCellSize = 8;\n+static constexpr uint8_t kCellSize = sizeof(ipu3_uapi_awb_set_item);\n \n Agc::Agc()\n \t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n", "prefixes": [ "libcamera-devel", "07/11" ] }